PPHA-526: Add types of tobacco smoked

Author: Themitchell

features/types_tobacco_smoking.feature

@@ -0,0 +1,40 @@
+@TypesTobaccoSmoking
+Feature: Types tobacco smoking page
+  Scenario: The page is accessible
+    Given I am logged in
+    When I go to "/types-tobacco-smoking"
+    Then there are no accessibility violations
+
+  Scenario: Form errors
+    Given I am logged in
+    When I go to "/types-tobacco-smoking"
+    And I click "Continue"
+    Then I am on "/types-tobacco-smoking"
+    And I see a form error "Select the type of tobacco you smoke or have smoked"
+    And there are no accessibility violations
+
+  Scenario: Navigating backwards and forwards
+    Given I am logged in
+    When I go to "/types-tobacco-smoking"
+    Then I see a back link to "/relatives-age-when-diagnosed"
+    When I check "Cigarettes"
+    And I submit the form
+    Then I am on "/check-your-answers"
+
+  Scenario: Checking responses and changing them
+    Given I am logged in
+    When I go to "/types-tobacco-smoking"
+    And I check "Cigarettes"
+    And I check "Cigars"
+    And I submit the form
+    When I go to "/check-your-answers"
+    Then I see "Cigarettes and Cigars" as a response to "Types of tobacco smoked" under "Smoking history"
+    And I see "/types-tobacco-smoking?change=True" as a link to change "Types of tobacco smoked" under "Smoking history"
+    When I click the link to change "Types of tobacco smoked" under "Smoking history"
+    Then I am on "/types-tobacco-smoking?change=True"
+    And I see "Cigarettes" selected
+    And I see "Cigars" selected
+    When I check "Pipe"
+    And I click "Continue"
+    Then I am on "/check-your-answers"
+    And I see "Cigarettes, Pipe, and Cigars" as a response to "Types of tobacco smoked" under "Smoking history"

lung_cancer_screening/questions/forms/types_tobacco_smoking_form.py

@@ -0,0 +1,26 @@
+from django import forms
+
+from ...nhsuk_forms.choice_field import MultipleChoiceField
+from ..models.types_tobacco_smoking_response import TypesTobaccoSmokingResponse, TypesTobaccoSmokingValues
+
+
+class TypesTobaccoSmokingForm(forms.ModelForm):
+
+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs)
+
+        self.fields["value"] = MultipleChoiceField(
+            choices=TypesTobaccoSmokingValues.choices,
+            widget=forms.CheckboxSelectMultiple,
+            label="What do you smoke?",
+            label_classes="nhsuk-fieldset__legend--l",
+            label_is_page_heading=True,
+            hint="Select all that apply",
+            error_messages={
+                "required": "Select the type of tobacco you smoke or have smoked"
+            },
+        )
+
+    class Meta:
+        model = TypesTobaccoSmokingResponse
+        fields = ['value']

lung_cancer_screening/questions/jinja2/responses.jinja

@@ -39,6 +39,14 @@
         }) }}
       </section>
 
+      <section>
+        <h2 class="nhsuk-heading-m">Smoking history</h2>
+
+        {{ summaryList({
+          "rows": response_set.smoking_history_responses_items()
+        }) }}
+      </section>
+
       <form action="{{ request.path }}" method="post">
         {{ csrf_input }}
         {{ button({

lung_cancer_screening/questions/migrations/0043_alter_ethnicityresponse_value_and_more.py

@@ -0,0 +1,39 @@
+# Generated by Django 5.2.10 on 2026-01-21 16:57
+
+import django.contrib.postgres.fields
+import django.db.models.deletion
+import lung_cancer_screening.questions.models.validators.singleton_option
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('questions', '0042_alter_educationresponse_value'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='ethnicityresponse',
+            name='value',
+            field=models.CharField(choices=[('A', 'Asian or Asian British'), ('B', 'Black, African, Caribbean or Black British'), ('M', 'Mixed or multiple ethnic groups'), ('W', 'White'), ('O', 'Other ethnic group'), ('N', 'Prefer not to say')], max_length=1),
+        ),
+        migrations.AlterField(
+            model_name='sexatbirthresponse',
+            name='value',
+            field=models.CharField(choices=[('F', 'Female'), ('M', 'Male'), ('I', 'Intersex')], max_length=1),
+        ),
+        migrations.CreateModel(
+            name='TypesTobaccoSmokingResponse',
+            fields=[
+                ('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('created_at', models.DateTimeField(auto_now_add=True)),
+                ('updated_at', models.DateTimeField(auto_now=True)),
+                ('value', django.contrib.postgres.fields.ArrayField(base_field=models.CharField(choices=[('C', 'Cigarettes'), ('G', 'Cigars'), ('P', 'Pipes'), ('E', 'E-cigarettes or vaping'), ('N', 'None of the above')], max_length=1), size=None, validators=[lung_cancer_screening.questions.models.validators.singleton_option.validate_singleton_option])),
+                ('response_set', models.OneToOneField(on_delete=django.db.models.deletion.CASCADE, related_name='types_tobacco_smoking_response', to='questions.responseset')),
+            ],
+            options={
+                'abstract': False,
+            },
+        ),
+    ]

lung_cancer_screening/questions/models/__init__.py

@@ -14,4 +14,5 @@
 from .relatives_age_when_diagnosed_response import RelativesAgeWhenDiagnosedResponse # noqa: F401
 from .respiratory_conditions_response import RespiratoryConditionsResponse # noqa: F401
 from .sex_at_birth_response import SexAtBirthResponse # noqa: F401
+from .types_tobacco_smoking_response import TypesTobaccoSmokingResponse # noqa: F401
 from .weight_response import WeightResponse # noqa: F401

lung_cancer_screening/questions/models/types_tobacco_smoking_response.py

@@ -0,0 +1,21 @@
+from django.db import models
+from django.contrib.postgres.fields import ArrayField
+
+from .base import BaseModel
+from .response_set import ResponseSet
+
+
+class TypesTobaccoSmokingValues(models.TextChoices):
+    CIGARETTES = "C", "Cigarettes"
+    ROLLED_CIGARETTES = "R", "Rolled cigarettes, or roll-ups"
+    PIPE = "P", "Pipe"
+    CIGARS = "G", "Cigars"
+    CIGARILLOS = "E", "Cigarillos"
+    SHISHAS = "S", "Shisha"
+
+
+class TypesTobaccoSmokingResponse(BaseModel):
+    response_set = models.OneToOneField(ResponseSet, on_delete=models.CASCADE, related_name='types_tobacco_smoking_response')
+    value = ArrayField(
+        models.CharField(max_length=1, choices=TypesTobaccoSmokingValues.choices)
+    )

lung_cancer_screening/questions/presenters/response_set_presenter.py

@@ -4,6 +4,7 @@
 from ..models.education_response import EducationValues
 from ..models.respiratory_conditions_response import RespiratoryConditionValues
 from ..models.family_history_lung_cancer_response import FamilyHistoryLungCancerValues
+from ..models.types_tobacco_smoking_response import TypesTobaccoSmokingValues
 
 class ResponseSetPresenter:
     DATE_FORMAT = "%-d %B %Y" # eg 8 September 2000
@@ -130,9 +131,18 @@ def respiratory_conditions(self):
             for code in self.response_set.respiratory_conditions_response.value
         ])
 
+    @property
+    def types_tobacco_smoking(self):
+        if not hasattr(self.response_set, 'types_tobacco_smoking_response'):
+            return None
+
+        return self._list_to_sentence([
+            TypesTobaccoSmokingValues(code).label
+            for code in self.response_set.types_tobacco_smoking_response.value
+        ])
 
     def eligibility_responses_items(self):
-        return [
+        items = [
             self._check_your_answer_item(
                 "Have you ever smoked tobacco?",
                 self.have_you_ever_smoked,
@@ -142,9 +152,11 @@ def eligibility_responses_items(self):
                 "Date of birth",
                 self.date_of_birth,
                 "questions:date_of_birth",
-            )
+            ),
         ]
 
+        return items
+
     def about_you_responses_items(self):
         return [
             self._check_your_answer_item(
@@ -218,6 +230,18 @@ def family_history_responses_items(self):
         return items
 
 
+    def smoking_history_responses_items(self):
+        items = [
+            self._check_your_answer_item(
+                "Types of tobacco smoked",
+                self.types_tobacco_smoking,
+                "questions:types_tobacco_smoking",
+            )
+        ]
+
+        return items
+
+
     def is_complete(self):
         return self.response_set.is_complete()
 

lung_cancer_screening/questions/tests/factories/types_tobacco_smoking_response_factory.py

@@ -0,0 +1,12 @@
+import factory
+
+from .response_set_factory import ResponseSetFactory
+from ...models.types_tobacco_smoking_response import TypesTobaccoSmokingResponse, TypesTobaccoSmokingValues
+
+
+class TypesTobaccoSmokingResponseFactory(factory.django.DjangoModelFactory):
+    class Meta:
+        model = TypesTobaccoSmokingResponse
+
+    response_set = factory.SubFactory(ResponseSetFactory)
+    value = [TypesTobaccoSmokingValues.CIGARETTES]

lung_cancer_screening/questions/tests/unit/forms/test_types_tobacco_smoking_form.py

@@ -0,0 +1,58 @@
+from django.test import TestCase, tag
+
+from ...factories.response_set_factory import ResponseSetFactory
+from ....models.types_tobacco_smoking_response import (
+    TypesTobaccoSmokingResponse,
+    TypesTobaccoSmokingValues,
+)
+from ....forms.types_tobacco_smoking_form import TypesTobaccoSmokingForm
+
+
+@tag("TypesTobaccoSmoking")
+class TestTypesTobaccoSmokingForm(TestCase):
+    def setUp(self):
+        self.response_set = ResponseSetFactory()
+        self.response = TypesTobaccoSmokingResponse.objects.create(
+            response_set=self.response_set,
+            value=["C"]
+        )
+
+    def test_is_valid_a_valid_value(self):
+        form = TypesTobaccoSmokingForm(
+            instance=self.response,
+            data={
+                "value": [TypesTobaccoSmokingValues.CIGARETTES]
+            }
+        )
+        self.assertTrue(form.is_valid())
+        self.assertEqual(
+            form.cleaned_data["value"],
+            [TypesTobaccoSmokingValues.CIGARETTES]
+        )
+
+
+    def test_is_invalid_with_an_invalid_value(self):
+        form = TypesTobaccoSmokingForm(
+            instance=self.response,
+            data={
+                "value": ["invalid"]
+            }
+        )
+        self.assertFalse(form.is_valid())
+        self.assertEqual(
+            form.errors["value"],
+            ["Select a valid choice. invalid is not one of the available choices."]
+        )
+
+    def test_is_invalid_when_no_option_is_selected(self):
+        form = TypesTobaccoSmokingForm(
+            instance=self.response,
+            data={
+                "value": []
+            }
+        )
+        self.assertFalse(form.is_valid())
+        self.assertEqual(
+            form.errors["value"],
+            ["Select the type of tobacco you smoke or have smoked"],
+        )

lung_cancer_screening/questions/tests/unit/models/test_types_tobacco_smoking_response.py

@@ -0,0 +1,34 @@
+from django.test import TestCase, tag
+
+from ...factories.response_set_factory import ResponseSetFactory
+from ...factories.types_tobacco_smoking_response_factory import TypesTobaccoSmokingResponseFactory
+
+from ....models.types_tobacco_smoking_response import TypesTobaccoSmokingResponse, TypesTobaccoSmokingValues
+
+
+@tag("TypesTobaccoSmoking")
+class TestTypesTobaccoSmokingResponse(TestCase):
+    def setUp(self):
+        self.response_set = ResponseSetFactory()
+
+    def test_has_a_valid_factory(self):
+        model = TypesTobaccoSmokingResponseFactory.build(response_set=self.response_set)
+        model.full_clean()
+
+    def test_has_response_set_as_foreign_key(self):
+        response_set = ResponseSetFactory()
+        response = TypesTobaccoSmokingResponse.objects.create(
+            response_set=response_set,
+            value=[TypesTobaccoSmokingValues.CIGARETTES]
+        )
+
+        self.assertEqual(response.response_set, response_set)
+
+    def test_has_value_as_list(self):
+        response_set = ResponseSetFactory()
+        response = TypesTobaccoSmokingResponse.objects.create(
+            response_set=response_set,
+            value=[TypesTobaccoSmokingValues.CIGARETTES, TypesTobaccoSmokingValues.CIGARS]
+        )
+
+        self.assertIsInstance(response.value, list)