Correct current with former and max age validation

Author: jamiefalcus

lung_cancer_screening/questions/forms/age_when_started_smoking_form.py

@@ -21,7 +21,7 @@ def __init__(self, *args, **kwargs):
                 "invalid": "Enter your age when you started smoking",
                 "zero_entered":"The age you started smoking must be between 1 and your current age",
                 "age_started_smoking_greater_than_current_age":"The age you started smoking must be the same as, or less than your current age",
-                "no_date_of_birth" : format_html("<a href=\"{}\">Provide your date of birth</a> before answering this question", reverse_lazy("questions:date_of_birth"))
+                "no_date_of_birth" : format_html("<a href=\"{}\">Provide your date of birth</a> before answering age when you started smoking", reverse_lazy("questions:date_of_birth"))
             }
         )
 

lung_cancer_screening/questions/forms/periods_when_you_stopped_smoking_form.py

@@ -1,4 +1,6 @@
 from django import forms
+from django.urls import reverse_lazy
+from django.utils.html import format_html
 
 from ...nhsuk_forms.integer_field import IntegerField
 from ...nhsuk_forms.typed_choice_field import TypedChoiceField
@@ -27,7 +29,7 @@ def __init__(self, *args, **kwargs):
             error_messages={
                 "required": self.required_error_message(),
                 "duration_years": self.duration_years_error_message()
-            },
+            }
         )
 
         self.fields["duration_years"] = IntegerField(
@@ -37,6 +39,9 @@ def __init__(self, *args, **kwargs):
             hint=self.duration_years_hint(),
             required=False,
             suffix="years",
+            error_messages={
+                "no_when_you_quit_smoking": format_html("<a href=\"{}\">Provide when you quit smoking</a> before answering the total number of years you stopped smoking", reverse_lazy("questions:when_you_quit_smoking"))
+            }
         )
 
     def clean_duration_years(self):
@@ -84,7 +89,7 @@ def stopped_or_quit(self):
             return "stopped or quit "
 
     def smoked_or_smoke(self):
-        if self.response_set().current_smoker():
+        if self.response_set().former_smoker():
             return "smoked"
         else:
             return "have been smoking"

lung_cancer_screening/questions/forms/when_you_quit_smoking_form.py

@@ -24,6 +24,7 @@ def __init__(self, *args, **kwargs):
                 "invalid": "Enter your age when you quit smoking",
                 "min_value":"The age you quit smoking must be between 1 and your current age",
                 "age_when_quit_smoking_greater_than_age_started":"The age you quit smoking cannot be lower than the age you started smoking",
+                "age_when_quit_smoking_greater_than_current_age" : "The age you quit smoking must be the same as, or less than, your current age",
                 "no_date_of_birth" : format_html("<a href=\"{}\">Provide your date of birth</a> before answering this question", reverse_lazy("questions:date_of_birth"))
             }
         )

lung_cancer_screening/questions/models/age_when_started_smoking_response.py

@@ -30,7 +30,19 @@ def clean(self):
             })
 
     def years_smoked_including_stopped(self):
-        return (
-            self.response_set.date_of_birth_response.age_in_years() -
-            self.value
-        )
+        if self.response_set.current_smoker():
+            return (
+                self.response_set.date_of_birth_response.age_in_years() -
+                self.value
+            )
+
+        if self.response_set.former_smoker():
+            if not hasattr(self.response_set, "when_you_quit_smoking_response"):
+                raise ValidationError({
+                    "duration_years": ValidationError(
+                        "when you quit smoking not set",
+                        code="no_when_you_quit_smoking"
+                    )
+                })
+            else:
+                return self.response_set.when_you_quit_smoking_response.value - self.value

lung_cancer_screening/questions/models/when_you_quit_smoking_response.py

@@ -1,5 +1,5 @@
 from django.db import models
-from django.core.validators import MinValueValidator
+from django.core.validators import MinValueValidator, MaxValueValidator
 from django.core.exceptions import ValidationError
 
 from .base import BaseModel
@@ -20,6 +20,7 @@ class WhenYouQuitSmokingResponse(BaseModel):
     def clean(self):
         super().clean()
         self.validates_date_of_birth_response()
+        self.validate_age_when_quit_smoking_greater_than_current_age()
         self.validates_age_started_smoking_response()
         self.validates_age_when_quit_smoking_greater_than_age_started()
 
@@ -33,6 +34,15 @@ def validates_date_of_birth_response(self):
                 )
             })
 
+    def validate_age_when_quit_smoking_greater_than_current_age(self):
+        if self.value and self.response_set.date_of_birth_response.age_in_years() < self.value:
+            raise ValidationError({
+                "value": ValidationError(
+                    "age when you quit smoking cannot be greater than current age",
+                    code="age_when_quit_smoking_greater_than_current_age"
+
+                )
+            })
 
     def validates_age_started_smoking_response(self):
         if not hasattr(self.response_set, "age_when_started_smoking_response"):