Correct deletion of when you quit smoking cause

Author: jamiefalcus

lung_cancer_screening/questions/models/have_you_ever_smoked_response.py

@@ -42,9 +42,9 @@ def is_former_smoker(self):
 
 
 @receiver(post_save, sender=HaveYouEverSmokedResponse)
-def remove_when_you_quit_smoking_if_not_current(sender, instance, **kwargs):
+def remove_when_you_quit_smoking_if_not_former_smoker(sender, instance, **kwargs):
     if (
-        not instance.is_current_smoker()
+        not instance.is_former_smoker()
         and instance.response_set
         and hasattr(instance.response_set, "when_you_quit_smoking_response")
     ):

lung_cancer_screening/questions/tests/unit/views/test_have_you_ever_smoked.py

@@ -1,8 +1,9 @@
 from django.test import TestCase, tag
 from django.urls import reverse
 
-from lung_cancer_screening.questions.tests.factories.age_when_started_smoking_response_factory import AgeWhenStartedSmokingResponseFactory
-from lung_cancer_screening.questions.tests.factories.when_you_quit_smoking_response_factory import WhenYouQuitSmokingResponseFactory
+from ...factories.age_when_started_smoking_response_factory import AgeWhenStartedSmokingResponseFactory
+from ...factories.when_you_quit_smoking_response_factory import WhenYouQuitSmokingResponseFactory
+from ...factories.have_you_ever_smoked_response_factory import HaveYouEverSmokedResponseFactory
 
 from ...factories.terms_of_use_response_factory import TermsOfUseResponseFactory
 
@@ -203,13 +204,19 @@ def test_post_redirects_if_the_user_not_a_smoker(self):
 
         self.assertRedirects(response, reverse("questions:non_smoker_exit"))
 
-
-    def test_post_resets_when_you_quit_smoking_response_if_the_user_changes_from_a_former_smoker_to_a_non_smoker(self):
+    @tag("wip")
+    def test_post_resets_when_you_quit_smoking_response_if_the_user_changes_from_a_former_smoker_to_a_smoker(self):
         response_set = ResponseSetFactory.create(
             user=self.user,
             eligible=True
         )
 
+        response_set.have_you_ever_smoked_response.delete()
+        HaveYouEverSmokedResponseFactory.create(
+            response_set=response_set,
+            value=HaveYouEverSmokedValues.YES_I_USED_TO_SMOKE_REGULARLY.value
+        )
+
         AgeWhenStartedSmokingResponseFactory.create(
             response_set=response_set,
             value=15
@@ -223,9 +230,11 @@ def test_post_resets_when_you_quit_smoking_response_if_the_user_changes_from_a_f
         response_set.save()
         response_set.refresh_from_db()
 
+        self.assertTrue(hasattr(response_set, 'when_you_quit_smoking_response'))
+
         self.client.post(
             reverse("questions:have_you_ever_smoked"),
-            {"value": HaveYouEverSmokedValues.NO_I_HAVE_NEVER_SMOKED.value }
+            {"value": HaveYouEverSmokedValues.YES_I_CURRENTLY_SMOKE.value }
         )
 
         response_set.refresh_from_db()