diff --git a/common/build.gradle b/common/build.gradle index 0e8a07620..b471069b6 100644 --- a/common/build.gradle +++ b/common/build.gradle @@ -18,7 +18,7 @@ repositories { } dependencies { - api 'ca.uhn.hapi.fhir:hapi-fhir-structures-dstu3:8.0.0' + api 'ca.uhn.hapi.fhir:hapi-fhir-structures-dstu3:8.4.0' api 'org.springframework.boot:spring-boot-starter-jdbc' api 'org.springframework.boot:spring-boot-starter-actuator' api 'org.springframework:spring-web' diff --git a/gp2gp-translator/src/main/java/uk/nhs/adaptors/pss/translator/service/SkeletonProcessingService.java b/gp2gp-translator/src/main/java/uk/nhs/adaptors/pss/translator/service/SkeletonProcessingService.java index deabc99d7..bb74a0481 100644 --- a/gp2gp-translator/src/main/java/uk/nhs/adaptors/pss/translator/service/SkeletonProcessingService.java +++ b/gp2gp-translator/src/main/java/uk/nhs/adaptors/pss/translator/service/SkeletonProcessingService.java @@ -72,7 +72,20 @@ private String normalizeSkeletonXml(String skeletonFileAsString) { } private boolean isEntireRcmrSkeleton(String normalizedSkeleton) { - return normalizedSkeleton != null && normalizedSkeleton.startsWith("")); } @@ -197,7 +209,14 @@ void When_NormalizeSkeletonXmlCalledWithXmlDeclaration_Expect_StripsDeclarationB var isRcmrMethod = SkeletonProcessingService.class.getDeclaredMethod("isEntireRcmrSkeleton", String.class); isRcmrMethod.setAccessible(true); + var document = org.mockito.Mockito.mock(Document.class); + var rootElement = org.mockito.Mockito.mock(Element.class); var xmlWithDeclaration = "\n"; + + when(xPathService.parseDocumentFromXml(any())).thenReturn(document); + when(document.getDocumentElement()).thenReturn(rootElement); + when(rootElement.getLocalName()).thenReturn("RCMR_IN030000UK06"); + var normalized = (String) normalizeMethod.invoke(skeletonProcessingService, xmlWithDeclaration); assertTrue(normalized.startsWith("