Add constraints and failing scenario

Author: dlzhry2nhs

.github/workflows/continuous-deployment.yml

@@ -6,7 +6,14 @@ on:
       - master
 
 jobs:
+  run-quality-checks:
+    uses: ./.github/workflows/quality-checks.yml
+    secrets:
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+
   deploy-internal-dev-backend:
+    needs: [run-quality-checks]
     uses: ./.github/workflows/deploy-backend.yml
     with:
       apigee_environment: internal-dev

.github/workflows/pr-deploy-and-test.yml

@@ -5,7 +5,15 @@ on:
     types: [opened, synchronize, reopened]
 
 jobs:
+  # TODO - discuss with team whether we want this constraint on PRs. My gut feel is no, but not just up to me!
+  run-quality-checks:
+    uses: ./.github/workflows/quality-checks.yml
+    secrets:
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+
   deploy-pr-backend:
+    needs: [run-quality-checks]
     uses: ./.github/workflows/deploy-backend.yml
     with:
       apigee_environment: internal-dev

.github/workflows/quality-checks.yml

@@ -1,11 +1,14 @@
 name: Quality Checks
 
 on:
-  push:
-    branches:
-      - master
-  pull_request:
-    types: [labeled, opened, synchronize, reopened, unlabeled]
+#  pull_request:
+#    types: [opened, synchronize, reopened]
+  workflow_call:
+    secrets:
+      GITHUB_TOKEN:
+        required: true
+      SONAR_TOKEN:
+        required: true
 
 env:
   SHARED_PATH: ${{ github.workspace }}/lambdas/shared

lambdas/filenameprocessor/src/file_name_processor.py

@@ -212,6 +212,9 @@ def handle_batch_file(
             error_details=str(error),
         )
 
+        # make a bad change to check quality checks job blocks deployment
+        chicken_nugget
+
         # Create ack file
         make_and_upload_ack_file(message_id, file_key, False, False, created_at_formatted_string)