VED-1005: Fix S3 replication config. (#1116)

* VED-1005: Add required metrics block to replication config.

* VED-1005: Add required delete marker config.

* VED-1005: Avoid changing the storage class when replicating.

Author: mfjarvis

infrastructure/instance/s3_config.tf

@@ -145,20 +145,28 @@ resource "aws_s3_bucket_replication_configuration" "replication" {
     priority = strcontains(var.sub_environment, "blue") ? 0 : 1
     status   = "Enabled"
 
-    filter {
-      prefix = ""
+    filter {}
+
+    delete_marker_replication {
+      status = "Disabled"
     }
 
     destination {
-      bucket        = aws_s3_bucket.batch_data_source_bucket.arn
-      storage_class = "STANDARD"
+      bucket = aws_s3_bucket.batch_data_source_bucket.arn
 
       replication_time {
         status = "Enabled"
         time {
           minutes = 15
         }
       }
+
+      metrics {
+        status = "Enabled"
+        event_threshold {
+          minutes = 15
+        }
+      }
     }
   }
 
@@ -167,20 +175,28 @@ resource "aws_s3_bucket_replication_configuration" "replication" {
     priority = strcontains(var.sub_environment, "blue") ? 1 : 0
     status   = "Disabled"
 
-    filter {
-      prefix = ""
+    filter {}
+
+    delete_marker_replication {
+      status = "Disabled"
     }
 
     destination {
-      bucket        = strcontains(aws_s3_bucket.batch_data_source_bucket.arn, "blue") ? replace(aws_s3_bucket.batch_data_source_bucket.arn, "blue", "green") : replace(aws_s3_bucket.batch_data_source_bucket.arn, "green", "blue")
-      storage_class = "STANDARD"
+      bucket = strcontains(aws_s3_bucket.batch_data_source_bucket.arn, "blue") ? replace(aws_s3_bucket.batch_data_source_bucket.arn, "blue", "green") : replace(aws_s3_bucket.batch_data_source_bucket.arn, "green", "blue")
 
       replication_time {
         status = "Enabled"
         time {
           minutes = 15
         }
       }
+
+      metrics {
+        status = "Enabled"
+        event_threshold {
+          minutes = 15
+        }
+      }
     }
   }
 }