A couple of Sonar issues

Author: dlzhry2nhs

backend/src/controller/fhir_controller.py

@@ -6,7 +6,6 @@
 from decimal import Decimal
 from typing import Optional
 from aws_lambda_typing.events import APIGatewayProxyEventV1
-from boto3 import client as boto3_client
 
 from controller.aws_apig_event_utils import get_supplier_system_header, get_path_parameter
 from controller.aws_apig_response_utils import create_response
@@ -30,9 +29,6 @@
 from parameter_parser import process_params, process_search_params, create_query_string
 import urllib.parse
 
-sqs_client = boto3_client("sqs", region_name="eu-west-2")
-queue_url = os.getenv("SQS_QUEUE_URL", "Queue_url")
-
 
 def make_controller(
     immunization_env: str = os.getenv("IMMUNIZATION_ENV"),

backend/src/repository/fhir_batch_repository.py

@@ -87,8 +87,6 @@ def __init__(self, imms: dict, vax_type: str, supplier: str, version: int):
 
 
 class ImmunizationBatchRepository:
-    def __init__(self):
-        pass
 
     def create_immunization(
         self, immunization: any, supplier_system: str, vax_type: str, table: any, is_present: bool
@@ -252,7 +250,7 @@ def _perform_dynamo_update(
                 else Attr("PK").eq(attr.pk) & Attr("DeletedAt").not_exists()
             )
             if deleted_at_required and update_reinstated == False:
-                ExpressionAttributeValues = {
+                expression_attribute_values = {
                     ":timestamp": attr.timestamp,
                     ":patient_pk": attr.patient_pk,
                     ":patient_sk": attr.patient_sk,
@@ -263,7 +261,7 @@ def _perform_dynamo_update(
                     ":respawn": "reinstated",
                 }
             else:
-                ExpressionAttributeValues = {
+                expression_attribute_values = {
                     ":timestamp": attr.timestamp,
                     ":patient_pk": attr.patient_pk,
                     ":patient_sk": attr.patient_sk,
@@ -279,7 +277,7 @@ def _perform_dynamo_update(
                 ExpressionAttributeNames={
                     "#imms_resource": "Resource",
                 },
-                ExpressionAttributeValues=ExpressionAttributeValues,
+                ExpressionAttributeValues=expression_attribute_values,
                 ReturnValues="ALL_NEW",
                 ConditionExpression=condition_expression,
             )