remove redundant enum service

Author: motola

lambdas/id_sync/src/pds_details.py

@@ -4,7 +4,7 @@
 
 import tempfile
 
-from common.api_clients.authentication import AppRestrictedAuth, Service
+from common.api_clients.authentication import AppRestrictedAuth
 from common.api_clients.pds_service import PdsService
 from common.cache import Cache
 from common.clients import get_secrets_manager_client, logger
@@ -20,7 +20,6 @@ def pds_get_patient_details(nhs_number: str) -> dict:
     try:
         cache = Cache(directory=safe_tmp_dir)
         authenticator = AppRestrictedAuth(
-            service=Service.PDS,
             secret_manager_client=get_secrets_manager_client(),
             environment=pds_env,
             cache=cache,

lambdas/shared/src/common/api_clients/authentication.py

@@ -2,34 +2,25 @@
 import json
 import time
 import uuid
-from enum import Enum
 
 import jwt
 import requests
 
+from common.api_clients.constants import API_CACHE_KEY
 from common.clients import logger
 from common.models.errors import UnhandledResponseError
 
 from ..cache import Cache
 
 
-class Service(Enum):
-    PDS = "pds"
-    IMMUNIZATION = "imms"
-
-
 class AppRestrictedAuth:
-    def __init__(self, service: Service, secret_manager_client, environment, cache: Cache):
+    def __init__(self, secret_manager_client, environment, cache: Cache):
         self.secret_manager_client = secret_manager_client
         self.cache = cache
-        self.cache_key = f"{service.value}_access_token"
+        self.cache_key = API_CACHE_KEY
 
         self.expiry = 30
-        self.secret_name = (
-            f"imms/outbound/{environment}/jwt-secrets"
-            if service == Service.PDS
-            else f"imms/immunization/{environment}/jwt-secrets"
-        )
+        self.secret_name = f"imms/outbound/{environment}/jwt-secrets"
 
         self.token_url = (
             f"https://{environment}.api.service.nhs.uk/oauth2/token"

lambdas/shared/src/common/api_clients/constants.py

@@ -3,6 +3,7 @@
 """Constants used by API clients"""
 
 DEV_ENVIRONMENT = "dev"
+API_CACHE_KEY = "api_client_access_token"
 
 
 class Constants:

lambdas/shared/src/common/api_clients/get_pds_details.py

@@ -5,7 +5,7 @@
 import os
 import tempfile
 
-from common.api_clients.authentication import AppRestrictedAuth, Service
+from common.api_clients.authentication import AppRestrictedAuth
 from common.api_clients.errors import PdsSyncException
 from common.api_clients.pds_service import PdsService
 from common.cache import Cache
@@ -20,7 +20,6 @@ def pds_get_patient_details(nhs_number: str) -> dict:
     try:
         cache = Cache(directory=safe_tmp_dir)
         authenticator = AppRestrictedAuth(
-            service=Service.PDS,
             secret_manager_client=get_secrets_manager_client(),
             environment=PDS_ENV,
             cache=cache,

lambdas/shared/src/common/api_clients/mns_setup.py

@@ -4,7 +4,7 @@
 import boto3
 from botocore.config import Config
 
-from common.api_clients.authentication import AppRestrictedAuth, Service
+from common.api_clients.authentication import AppRestrictedAuth
 from common.api_clients.constants import DEV_ENVIRONMENT
 from common.api_clients.mns_service import MnsService
 from common.api_clients.mock_mns_service import MockMnsService
@@ -23,7 +23,6 @@ def get_mns_service(mns_env: str = "int"):
         cache = Cache(directory="/tmp")
         logging.info("Creating authenticator...")
         authenticator = AppRestrictedAuth(
-            service=Service.PDS,
             secret_manager_client=boto3.client("secretsmanager", config=boto_config),
             environment=mns_env,
             cache=cache,

lambdas/shared/tests/test_common/api_clients/test_authentication.py

@@ -7,7 +7,7 @@
 import responses
 from responses import matchers
 
-from common.api_clients.authentication import AppRestrictedAuth, Service
+from common.api_clients.authentication import AppRestrictedAuth
 from common.models.errors import UnhandledResponseError
 
 
@@ -33,7 +33,7 @@ def setUp(self):
         self.cache.get.return_value = None
 
         env = "an-env"
-        self.authenticator = AppRestrictedAuth(Service.PDS, self.secret_manager_client, env, self.cache)
+        self.authenticator = AppRestrictedAuth(self.secret_manager_client, env, self.cache)
         self.url = f"https://{env}.api.service.nhs.uk/oauth2/token"
 
     @responses.activate
@@ -89,12 +89,12 @@ def test_env_mapping(self):
         """it should target int environment for none-prod environment, otherwise int"""
         # For env=none-prod
         env = "some-env"
-        auth = AppRestrictedAuth(Service.PDS, None, env, None)
+        auth = AppRestrictedAuth(None, env, None)
         self.assertTrue(auth.token_url.startswith(f"https://{env}."))
 
         # For env=prod
         env = "prod"
-        auth = AppRestrictedAuth(Service.PDS, None, env, None)
+        auth = AppRestrictedAuth(None, env, None)
         self.assertTrue(env not in auth.token_url)
 
     def test_returned_cached_token(self):
@@ -126,7 +126,7 @@ def test_update_cache(self):
             self.authenticator.get_access_token()
 
         # Then
-        self.cache.put.assert_called_once_with(f"{Service.PDS.value}_access_token", cached_token)
+        self.cache.put.assert_called_once_with("api_client_access_token", cached_token)
 
     @responses.activate
     def test_expired_token_in_cache(self):