comment out 3.11

remove -e

test

lint

Author: nhsdevws

azure/templates/post-deploy.yml

@@ -36,11 +36,11 @@ steps:
       role: "auto-ops"
       profile: "apim-dev"
       aws_account: ${{ parameters.aws_account_type }}
-  - bash: |
-      pyenv install -s 3.11.12
-      pyenv global 3.11.12
-      python --version
-    displayName: Set Python 3.11
+  # - bash: |
+  #     pyenv install -s 3.11.12
+  #     pyenv global 3.11.12
+  #     python --version
+  #   displayName: Set Python 3.11
   - bash: |
       set -e
       if ! [[ $APIGEE_ENVIRONMENT =~ .*-*sandbox ]]; then

redis_sync/tests/test_clients.py

@@ -18,7 +18,6 @@ def setUp(self):
         # patch logging
         self.logging_patch = patch("logging.getLogger")
         self.mock_logging = self.logging_patch.start()
-        # patch 
 
         self.getenv_patch = patch("os.getenv")
         self.mock_getenv = self.getenv_patch.start()
@@ -28,7 +27,7 @@ def setUp(self):
             "REDIS_HOST": self.REDIS_HOST,
             "REDIS_PORT": self.REDIS_PORT
         }.get(key, default)
-        
+
         # patch redis
         self.redis_patch = patch("redis.StrictRedis")
         self.mock_redis = self.redis_patch.start()

redis_sync/tests/test_redis_cacher.py

@@ -58,4 +58,4 @@ def test_get_cached_disease_mapping_json(self):
         self.mock_redis_client.get.return_value = cached_disease_mapping
         result = RedisCacher.get_cached_disease_mapping_json()
         self.assertEqual(result, json.loads(cached_disease_mapping))
-        self.mock_redis_client.get.assert_called_once_with(RedisCacheKey.DISEASE_MAPPING_FILE_KEY)
+        self.mock_redis_client.get.assert_called_once_with(RedisCacheKey.DISEASE_MAPPING_FILE_KEY)

redis_sync/tests/test_s3_reader.py

@@ -8,12 +8,8 @@ def setUp(self):
         self.s3_reader = S3Reader()
         self.bucket = "test-bucket"
         self.key = "test.json"
-
-        # Patch s3_client
         self.s3_client_patcher = patch("s3_reader.s3_client")
         self.mock_s3_client = self.s3_client_patcher.start()
-
-        # Patch logger.exception
         self.logger_exception_patcher = patch("logging.Logger.exception")
         self.mock_logger_exception = self.logger_exception_patcher.start()
 
@@ -23,12 +19,13 @@ def tearDown(self):
 
     def test_read_success(self):
         mock_body = MagicMock()
-        mock_body.read.return_value = b'{"foo": "bar"}'
+        mock_data = '{"test-read-ok": "test-read-ok-data"}'
+        mock_body.read.return_value = mock_data.encode('utf-8')
         self.mock_s3_client.get_object.return_value = {"Body": mock_body}
 
         result = self.s3_reader.read(self.bucket, self.key)
 
-        self.assertEqual(result, '{"foo": "bar"}')
+        self.assertEqual(result, mock_data)
         self.mock_s3_client.get_object.assert_called_once_with(Bucket=self.bucket, Key=self.key)
 
     def test_read_raises_exception(self):

terraform/package_lambda.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 set -e
-set -x
+
 echo "🚀 Nudge Packaging Lambda..."
 
 PROJECT="${1:-.}"