Skip to content

Commit 5b5150c

Browse files
committed
remove get_status_handler and tweak test files
1 parent ace52ed commit 5b5150c

5 files changed

Lines changed: 27 additions & 25 deletions

File tree

lambdas/backend/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ package: build
99

1010
test:
1111
$(TEST_ENV) python -m unittest
12-
1312
coverage-run:
1413
$(TEST_ENV) coverage run --source=src -m unittest discover
1514

lambdas/backend/src/get_status_handler.py

Lines changed: 0 additions & 3 deletions
This file was deleted.

lambdas/backend/tests/test_get_status_handler.py

Lines changed: 0 additions & 12 deletions
This file was deleted.
Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
1+
import os
12
import tempfile
23
import unittest
34

45
from local_lambda import load_string
56

67

78
class TestLoadString(unittest.TestCase):
8-
def test_load_string_reads_file_contents(self):
9-
with tempfile.NamedTemporaryFile(mode="w+", delete=False) as tmp:
10-
tmp.write("hello world")
11-
tmp.seek(0)
9+
def test_reads_file_contents(self):
10+
fd, path = tempfile.mkstemp()
11+
self.addCleanup(os.unlink, path)
12+
with os.fdopen(fd, "w") as f:
13+
f.write("hello world")
1214

13-
result = load_string(tmp.name)
14-
self.assertEqual(result, "hello world")
15+
self.assertEqual(load_string(path), "hello world")
1516

16-
def test_load_string_file_not_found(self):
17+
def test_raises_if_file_not_found(self):
1718
with self.assertRaises(FileNotFoundError):
1819
load_string("/nonexistent/file/path.py")

lambdas/backend/tests/test_timer.py

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,30 @@
55

66

77
class TestTimedDecorator(unittest.TestCase):
8+
@patch("timer.time")
89
@patch("timer.logger")
9-
def test_timed_logs_execution_time(self, mock_logger):
10+
def test_timed_logs_correct_execution_time(self, mock_logger, mock_time):
11+
mock_time.time.side_effect = [1000.0, 1000.12345]
12+
1013
@timed
1114
def sample_function():
1215
return "success"
1316

1417
result = sample_function()
18+
1519
self.assertEqual(result, "success")
20+
mock_logger.info.assert_called_once_with({"time_taken": "sample_function ran in 0.12345s"})
21+
22+
@patch("timer.time")
23+
@patch("timer.logger")
24+
def test_timed_preserves_function_name(self, mock_logger, mock_time):
25+
mock_time.time.side_effect = [0.0, 0.0]
26+
27+
@timed
28+
def my_named_function():
29+
pass
30+
31+
my_named_function()
1632

17-
mock_logger.info.assert_called_once()
33+
logged_payload = mock_logger.info.call_args[0][0]
34+
self.assertIn("my_named_function", logged_payload["time_taken"])

0 commit comments

Comments
 (0)