VED-294: Use correct log method. Fix assertions.

Author: mfjarvis

delta_backend/src/delta.py

@@ -93,7 +93,7 @@ def handle_dynamodb_response(response, error_records):
             logger.info("Successfully synched into delta")
             return True, {"statusCode": "200", "statusDesc": "Successfully synched into delta"}
         case _:
-            logger.exception("Failure response from DynamoDB")
+            logger.error(f"Failure response from DynamoDB: {response}")
             return False, {"statusCode": "500", "statusDesc": "Failure response from DynamoDB", "diagnostics": response}
 
 def handle_exception_response(response):

delta_backend/tests/test_delta.py

@@ -351,7 +351,7 @@ def test_single_error_in_multi(self):
         self.assertFalse(result)
         self.assertEqual(self.mock_delta_table.put_item.call_count, 3)
         self.assertEqual(self.mock_firehose_logger.send_log.call_count, 3)
-        self.assertEqual(self.mock_logger_exception.call_count, 1)
+        self.assertEqual(self.mock_logger_error.call_count, 1)
 
     def test_single_exception_in_multi(self):
         # Arrange
@@ -448,12 +448,15 @@ def setUp(self):
         self.logger_info_patcher = patch("logging.Logger.info")
         self.mock_logger_info = self.logger_info_patcher.start()
 
-        self.logger_exception_patcher = patch("logging.Logger.exception")
-        self.mock_logger_exception = self.logger_exception_patcher.start()
-
         self.logger_warning_patcher = patch("logging.Logger.warning")
         self.mock_logger_warning = self.logger_warning_patcher.start()
 
+        self.logger_error_patcher = patch("logging.Logger.error")
+        self.mock_logger_error = self.logger_error_patcher.start()
+
+        self.logger_exception_patcher = patch("logging.Logger.exception")
+        self.mock_logger_exception = self.logger_exception_patcher.start()
+
         self.delta_table_patcher=patch("delta.delta_table")
         self.mock_delta_table = self.delta_table_patcher.start()
 
@@ -521,7 +524,7 @@ def test_multi_record_success_with_fail(self):
             self.assertEqual(result, expected_returns[test_index-1])
             self.assertEqual(self.mock_delta_table.put_item.call_count, test_index)
 
-        self.assertEqual(self.mock_logger_exception.call_count, 1)
+        self.assertEqual(self.mock_logger_error.call_count, 1)
 
 
     def test_single_record_table_exception(self):
@@ -534,7 +537,7 @@ def test_single_record_table_exception(self):
             operation=Operation.UPDATE,
             supplier="EMIS",
         )
-        self.mock_delta_table.put_item.return_value = EXCEPTION_RESPONSE
+        self.mock_delta_table.put_item.side_effect = EXCEPTION_RESPONSE
         # Act
         result, operation_outcome = process_record(record)
 
@@ -543,7 +546,7 @@ def test_single_record_table_exception(self):
         self.assertEqual(operation_outcome["record"], imms_id)
         self.assertEqual(operation_outcome["operation_type"], Operation.UPDATE)
         self.assertEqual(operation_outcome["statusCode"], "500")
-        self.assertEqual(operation_outcome["statusDesc"], "Failure response from DynamoDB")
+        self.assertEqual(operation_outcome["statusDesc"], "Exception")
         self.assertEqual(self.mock_delta_table.put_item.call_count, 1)
         self.assertEqual(self.mock_logger_exception.call_count, 1)