Consolidate ECR image retrieval policy for redis_sync and id_sync lambdas (#1178)

edhall-nhs · web-flow · commit 53cf454050f5 · 2026-02-02T11:36:11.000Z
diff --git a/infrastructure/instance/id_sync_lambda.tf b/infrastructure/instance/id_sync_lambda.tf
@@ -71,7 +71,7 @@ resource "aws_ecr_repository_policy" "id_sync_lambda_ECRImageRetreival_policy" {
         ],
         Condition : {
           StringLike : {
-            "aws:sourceArn" : aws_lambda_function.id_sync_lambda.arn
+            "aws:sourceArn" : "arn:aws:lambda:${var.aws_region}:${var.immunisation_account_id}:function:${local.id_sync_lambda_name}"
           }
         }
       }
diff --git a/infrastructure/instance/redis_sync_lambda.tf b/infrastructure/instance/redis_sync_lambda.tf
@@ -71,7 +71,7 @@ resource "aws_ecr_repository_policy" "redis_sync_lambda_ECRImageRetreival_policy
         ],
         Condition : {
           StringLike : {
-            "aws:sourceArn" : aws_lambda_function.redis_sync_lambda.arn
+            "aws:sourceArn" : "arn:aws:lambda:${var.aws_region}:${var.immunisation_account_id}:function:${local.redis_sync_lambda_name}"
           }
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ resource "aws_ecr_repository_policy" "id_sync_lambda_ECRImageRetreival_policy" {`
`71`	`71`	`],`
`72`	`72`	`Condition : {`
`73`	`73`	`StringLike : {`
`74`		`- "aws:sourceArn" : aws_lambda_function.id_sync_lambda.arn`
	`74`	`+ "aws:sourceArn" : "arn:aws:lambda:${var.aws_region}:${var.immunisation_account_id}:function:${local.id_sync_lambda_name}"`
`75`	`75`	`}`
`76`	`76`	`}`
`77`	`77`	`}`