Update deployment workflows to disable record processor image build in continuous deployment. Adjusted output variable for image version in backend deployment workflow and refined implicit tag prefix reuse logic. Added AWS connection step in Lambda artifact deployment workflow, enhancing deployment efficiency and flexibility.

Author: Thomas-Boyle

.github/workflows/continuous-deployment.yml

@@ -20,7 +20,7 @@ jobs:
     uses: ./.github/workflows/deploy-backend.yml
     with:
       apigee_environment: internal-dev
-      build_recordprocessor_image: true
+      build_recordprocessor_image: false
       diff_base_sha: ${{ github.event.before }}
       diff_head_sha: ${{ github.sha }}
       run_diff_check: true

.github/workflows/deploy-backend.yml

@@ -39,7 +39,7 @@ on:
     outputs:
       recordprocessor_image_version:
         description: Selected immutable image selector used for recordprocessor deployment
-        value: ${{ jobs.deploy-recordprocessor-image.outputs.image_version }}
+        value: ${{ jobs.deploy-recordprocessor-image.outputs.image_uri }}
   workflow_dispatch:
     inputs:
       apigee_environment:
@@ -120,7 +120,7 @@ jobs:
       dockerfile_path: lambdas/recordprocessor/Dockerfile
       ecr_repository: imms-recordprocessor-repo
       image_tag_prefix: ${{ inputs.sub_environment }}-
-      allow_implicit_tag_prefix_reuse: ${{ startsWith(inputs.sub_environment, 'pr-') }}
+      allow_implicit_tag_prefix_reuse: ${{ inputs.sub_environment == 'internal-dev' || startsWith(inputs.sub_environment, 'pr-') }}
 
   terraform-plan:
     permissions:

.github/workflows/deploy-lambda-artifact.yml

@@ -122,6 +122,13 @@ jobs:
         with:
           fetch-depth: 0
 
+      - name: Connect to AWS
+        uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7
+        with:
+          aws-region: eu-west-2
+          role-to-assume: arn:aws:iam::${{ vars.AWS_ACCOUNT_ID }}:role/auto-ops
+          role-session-name: github-actions
+
       - name: Select build or reuse path
         id: decide
         run: |
@@ -156,6 +163,23 @@ jobs:
                 deployment_mode="build"
               elif ! git diff --quiet "${DIFF_BASE_SHA}" "${DIFF_HEAD_SHA}" -- "${paths[@]}"; then
                 deployment_mode="build"
+              elif [ -z "${IMAGE_VERSION}" ] && [ "${ALLOW_IMPLICIT_TAG_PREFIX_REUSE}" = "true" ]; then
+                reusable_tag="$(
+                  aws ecr describe-images \
+                    --repository-name "${ECR_REPOSITORY}" \
+                    --region "${AWS_REGION}" \
+                    --filter tagStatus=TAGGED \
+                    --query 'reverse(sort_by(imageDetails,&imagePushedAt))[].imageTags[]' \
+                    --output text 2>/dev/null \
+                  | tr '\t' '\n' \
+                  | grep "^${TAG_PREFIX}" \
+                  | head -n1 || true
+                )"
+
+                # If there is nothing reusable yet, bootstrap by building once.
+                if [ -z "${reusable_tag}" ]; then
+                  deployment_mode="build"
+                fi
               fi
             fi
           elif [ -z "${IMAGE_VERSION}" ]; then
@@ -164,13 +188,6 @@ jobs:
 
           echo "deployment_mode=${deployment_mode}" >> "$GITHUB_OUTPUT"
 
-      - name: Connect to AWS
-        uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7
-        with:
-          aws-region: eu-west-2
-          role-to-assume: arn:aws:iam::${{ vars.AWS_ACCOUNT_ID }}:role/auto-ops
-          role-session-name: github-actions
-
       - name: Login to Amazon ECR
         id: login-ecr
         if: ${{ steps.decide.outputs.deployment_mode == 'build' }}

lambdas/recordprocessor/src/batch_processor.py

@@ -31,7 +31,7 @@ def process_csv_to_fhir(incoming_message_body: dict) -> int:
         incoming_message_body["encoder"] = encoder
         interim_message_body = file_level_validation(incoming_message_body=incoming_message_body)
     except Exception as e:  # pylint: disable=broad-exception-caught
-        logger.error(f"File level validation failed: {e}")  # If the file is invalid, processing should cease.
+        logger.error(f"File level validation failed: {e}")  # If the file is invalid, processing should cease
         return 0
 
     file_id = interim_message_body.get("message_id")