move string literal to constant

Author: motola

lambdas/shared/src/common/api_clients/constants.py

@@ -2,6 +2,8 @@
 
 """Constants used by API clients"""
 
+DEV_ENVIRONMENT = "dev"
+
 
 class Constants:
     """Constants used for the API clients"""

lambdas/shared/src/common/api_clients/mns_setup.py

@@ -5,6 +5,7 @@
 from botocore.config import Config
 
 from common.api_clients.authentication import AppRestrictedAuth, Service
+from common.api_clients.constants import DEV_ENVIRONMENT
 from common.api_clients.mns_service import MnsService
 from common.api_clients.mock_mns_service import MockMnsService
 from common.cache import Cache
@@ -14,7 +15,7 @@
 
 
 def get_mns_service(mns_env: str = "int"):
-    if mns_env == "dev":
+    if mns_env == DEV_ENVIRONMENT:
         logging.info("Dev environment: Using MockMnsService")
         return MockMnsService(MNS_TEST_QUEUE_URL)
     else: