updated extract status text override method to allow empty list aswell as None to allow integration test to pass

Author: oneeb-nhs

src/eligibility_signposting_api/services/processors/action_rule_handler.py

@@ -111,9 +111,12 @@ def _get_actions_from_comms(action_mapper: ActionsMapper, comms: str) -> list[Su
     def _extract_status_text_override(
         actions: list[SuggestedAction] | None,
     ) -> tuple[list[SuggestedAction] | None, StatusText | None]:
-        if not actions:
+        if actions is None:
             return None, None
 
+        if len(actions) == 0:
+            return [], None
+
         override_text = None
         remaining = []
         for action in actions:
@@ -122,4 +125,4 @@ def _extract_status_text_override(
             else:
                 remaining.append(action)
 
-        return remaining or None, override_text
+        return remaining, override_text

tests/unit/services/processors/test_action_rule_handler.py

@@ -843,7 +843,7 @@ def test_extract_status_text_override_with_none_returns_none_none():
 def test_extract_status_text_override_with_empty_list_returns_none_none():
     result = ActionRuleHandler._extract_status_text_override([])
 
-    assert_that(result, is_((None, None)))
+    assert_that(result, is_(([], None)))
 
 
 def test_extract_status_text_override_with_no_override_action_leaves_actions_unchanged():
@@ -860,7 +860,7 @@ def test_extract_status_text_override_with_only_override_action_captures_text():
 
     remaining, override_text = ActionRuleHandler._extract_status_text_override(actions)
 
-    assert_that(remaining, is_(None))
+    assert_that(remaining, is_([]))
     assert_that(override_text, is_(StatusText("You maybe eligible for a vaccination")))