Fix: [AEA-0000] - do not use an environment for cdk diff (#1581)

## Summary

- Routine Change

### Details

- do not use environment for cdk diff

Author: anthony-nhs

.github/workflows/cdk_release_code.yml

@@ -25,7 +25,7 @@ on:
         required: true
         type: boolean
       DEPLOYMENT_ENVIRONMENT:
-        required: true
+        required: false
         type: string
     secrets:
       CLOUD_FORMATION_DEPLOY_ROLE:
@@ -37,7 +37,7 @@ jobs:
   deploy_cdk_code:
     runs-on: ubuntu-22.04
     name: "${{ inputs.DEPLOY_CDK_CODE && 'Deploy' || 'Diff' }} cdk app ${{ inputs.CDK_APP_NAME }}"
-    environment: ${{ inputs.DEPLOYMENT_ENVIRONMENT }}
+    environment: ${{ fromJSON(inputs.DEPLOYMENT_ENVIRONMENT != '' && format('"{0}"', inputs.DEPLOYMENT_ENVIRONMENT) || 'null') }}
     permissions:
       id-token: write
       contents: write

.github/workflows/release_all_stacks.yml

@@ -132,7 +132,6 @@ jobs:
       CDK_APP_NAME: MonitoringApp
       DEPLOY_CDK_CODE: false
       IS_PULL_REQUEST: ${{ inputs.is_pull_request }}
-      DEPLOYMENT_ENVIRONMENT: dev-account # set to dev as we are just running a diff
     secrets:
       CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.cf_create_changeset_role }} # use create changeset role as we are just doing a diff
       CDK_PULL_IMAGE_ROLE: ${{ secrets.CDK_PULL_IMAGE_ROLE }}

environmentSettings/int.json

@@ -36,8 +36,7 @@
         "NONE"
       ],
       "PrepareChangesetClaimFilters": [
-        "repo:NHSDigital/electronic-prescription-service-account-resources:ref:refs/heads/main",
-        "repo:NHSDigital/electronic-prescription-service-account-resources:environment:dev-account"
+        "repo:NHSDigital/electronic-prescription-service-account-resources:ref:refs/heads/main"
       ],
       "ArtilleryLoadTestRoleClaimFilters": [
         "NONE"

environmentSettings/prod.json

@@ -35,8 +35,7 @@
         "NONE"
       ],
       "PrepareChangesetClaimFilters": [
-        "repo:NHSDigital/electronic-prescription-service-account-resources:ref:refs/heads/main",
-        "repo:NHSDigital/electronic-prescription-service-account-resources:environment:dev-account"
+        "repo:NHSDigital/electronic-prescription-service-account-resources:ref:refs/heads/main"
       ],
       "ArtilleryLoadTestRoleClaimFilters": [
         "NONE"