Skip to content

Commit 9df31df

Browse files
committed
use new exports
1 parent 873849f commit 9df31df

9 files changed

Lines changed: 67 additions & 55 deletions

.github/scripts/create_changeset_existing_tags.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ fi
1616

1717
ROLE=$(echo "$CF_LONDON_EXPORTS" | \
1818
jq \
19-
--arg EXPORT_NAME "ci-resources:CloudFormationExecutionRole" \
19+
--arg EXPORT_NAME "iam-cdk:IAM:CloudFormationExecutionRole:Arn" \
2020
-r '.Exports[] | select(.Name == $EXPORT_NAME) | .Value')
2121

2222
if [ -z "${ROLE}" ]; then
@@ -34,6 +34,7 @@ if [ "${status}" != '"CREATE_COMPLETE"' ] && [ "${status}" != '"UPDATE_ROLLBACK_
3434
fi
3535

3636
# upload file to s3
37+
# change this to account-resources-cdk-uk:Bucket:ArtifactsBucket:Arn once other change is merged
3738
artifact_bucket_arn=$(echo "$CF_LONDON_EXPORTS" | \
3839
jq \
3940
--arg EXPORT_NAME "account-resources:ArtifactsBucket" \

.github/scripts/create_changeset_new_tags.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ CF_LONDON_EXPORTS=$(aws cloudformation list-exports --region eu-west-2 --output
1010

1111
ROLE=$(echo "$CF_LONDON_EXPORTS" | \
1212
jq \
13-
--arg EXPORT_NAME "ci-resources:CloudFormationExecutionRole" \
13+
--arg EXPORT_NAME "iam-cdk:IAM:CloudFormationExecutionRole:Arn" \
1414
-r '.Exports[] | select(.Name == $EXPORT_NAME) | .Value')
1515
if [ -z "${ROLE}" ]; then
1616
echo "could not retrieve ROLE from aws cloudformation list-exports"
@@ -27,6 +27,7 @@ if [ "${status}" != '"CREATE_COMPLETE"' ] && [ "${status}" != '"UPDATE_ROLLBACK_
2727
fi
2828

2929
# upload file to s3
30+
# change this to account-resources-cdk-uk:Bucket:ArtifactsBucket:Arn once other change is merged
3031
artifact_bucket_arn=$(echo "$CF_LONDON_EXPORTS" | \
3132
jq \
3233
--arg EXPORT_NAME "account-resources:ArtifactsBucket" \

.github/scripts/execute_changeset.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ AWS_MAX_ATTEMPTS=20
44
export AWS_MAX_ATTEMPTS
55

66
CF_LONDON_EXPORTS=$(aws cloudformation list-exports --region eu-west-2 --output json)
7+
# change this to account-resources-cdk-uk:Bucket:ArtifactsBucket:Arn once other change is merged
78
artifact_bucket_arn=$(echo "$CF_LONDON_EXPORTS" | \
89
jq \
910
--arg EXPORT_NAME "account-resources:ArtifactsBucket" \

.github/scripts/release_code.sh

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,23 @@ echo "$COMMIT_ID"
66
AWS_MAX_ATTEMPTS=10
77
export AWS_MAX_ATTEMPTS
88

9-
artifact_bucket=$(aws cloudformation list-exports --output json | jq -r '.Exports[] | select(.Name == "account-resources:ArtifactsBucket") | .Value' | grep -o '[^:]*$')
9+
CF_LONDON_EXPORTS=$(aws cloudformation list-exports --region eu-west-2 --output json)
10+
# change this to account-resources-cdk-uk:Bucket:ArtifactsBucket:Arn once other change is merged
11+
artifact_bucket_arn=$(echo "$CF_LONDON_EXPORTS" | \
12+
jq \
13+
--arg EXPORT_NAME "account-resources:ArtifactsBucket" \
14+
-r '.Exports[] | select(.Name == $EXPORT_NAME) | .Value')
15+
artifact_bucket=$(echo "$artifact_bucket_arn" | cut -d: -f6 | cut -d/ -f1)
1016
if [ -z "${artifact_bucket}" ]; then
1117
echo "could not retrieve artifact_bucket from aws cloudformation list-exports"
1218
exit 1
1319
fi
1420
export artifact_bucket
1521

16-
cloud_formation_execution_role=$(aws cloudformation list-exports --output json | jq -r '.Exports[] | select(.Name == "ci-resources:CloudFormationExecutionRole") | .Value' )
22+
cloud_formation_execution_role=$(echo "$CF_LONDON_EXPORTS" | \
23+
jq \
24+
--arg EXPORT_NAME "iam-cdk:IAM:CloudFormationExecutionRole:Arn" \
25+
-r '.Exports[] | select(.Name == $EXPORT_NAME) | .Value')
1726
if [ -z "${cloud_formation_execution_role}" ]; then
1827
echo "could not retrieve cloud_formation_execution_role from aws cloudformation list-exports"
1928
exit 1

SAMtemplates/common_lambda_resources.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@ Resources:
8686
- !Join
8787
- ","
8888
- - !Ref LambdaManagedPolicy
89-
- !ImportValue lambda-resources:LambdaInsightsLogGroupPolicy
90-
- !ImportValue account-resources:LambdaEncryptCloudwatchKMSPolicy
91-
- !ImportValue account-resources:LambdaDecryptSecretsKMSPolicy
89+
- !ImportValue account-resources-cdk-uk:IAM:LambdaInsightsLogGroupPolicy:Arn
90+
- !ImportValue account-resources-cdk-uk:IAM:LambdaEncryptCloudwatchKMSPolicy:Arn
91+
- !ImportValue secrets-cdk:IAM:LambdaDecryptSecretsKMSPolicy:Arn
9292
- !If
9393
- ShouldIncludeAdditionalPolicies
9494
- !Join

cloudformation/account_resources.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ Resources:
152152
Effect: Allow
153153
Principal:
154154
AWS:
155-
- !ImportValue ci-resources:CloudFormationExecutionRole
155+
- !ImportValue iam-cdk:IAM:CloudFormationExecutionRole:Arn
156156
- !Sub arn:aws:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-eu-west-2
157157
Action:
158158
- kms:DescribeKey
@@ -255,9 +255,9 @@ Resources:
255255
Type: AWS::IAM::ManagedPolicy
256256
Properties:
257257
Roles:
258-
- !ImportValue ci-resources:CloudFormationExecutionRoleName
259-
- !ImportValue ci-resources:CloudFormationPrepareChangesetRoleName
260-
- !ImportValue ci-resources:CloudFormationDeployRoleName
258+
- !ImportValue iam-cdk:IAM:CloudFormationExecutionRole:Name
259+
- !ImportValue iam-cdk:IAM:CloudFormationPrepareChangesetRole:Name
260+
- !ImportValue iam-cdk:IAM:CloudFormationDeployRole:Name
261261
PolicyDocument:
262262
Version: 2012-10-17
263263
Statement:
@@ -326,9 +326,9 @@ Resources:
326326
- Effect: Allow
327327
Principal:
328328
AWS:
329-
- !ImportValue ci-resources:CloudFormationDeployRole
330-
- !ImportValue ci-resources:CloudFormationExecutionRole
331-
- !ImportValue ci-resources:CloudFormationPrepareChangesetRole
329+
- !ImportValue iam-cdk:IAM:CloudFormationDeployRole:Arn
330+
- !ImportValue iam-cdk:IAM:CloudFormationExecutionRole:Arn
331+
- !ImportValue iam-cdk:IAM:CloudFormationPrepareChangesetRole:Arn
332332
Action:
333333
- s3:GetObject*
334334
- s3:PutObject*
@@ -340,7 +340,7 @@ Resources:
340340
- Effect: Allow
341341
Principal:
342342
AWS:
343-
- !ImportValue ci-resources:CloudFormationDeployRole
343+
- !ImportValue ciam-cdk:IAM:CloudFormationDeployRole:Arn
344344
Action:
345345
- s3:DeleteObject*
346346
Resource:
@@ -374,7 +374,7 @@ Resources:
374374
Type: AWS::IAM::ManagedPolicy
375375
Properties:
376376
Roles:
377-
- !ImportValue ci-resources:CloudFormationExecutionRoleName
377+
- !ImportValue iam-cdk:IAM:CloudFormationExecutionRole:Name
378378
PolicyDocument:
379379
Version: 2012-10-17
380380
Statement:
@@ -434,8 +434,8 @@ Resources:
434434
- Effect: Allow
435435
Principal:
436436
AWS:
437-
- !ImportValue ci-resources:CloudFormationDeployRole
438-
- !ImportValue ci-resources:CloudFormationExecutionRole
437+
- !ImportValue iam-cdk:IAM:CloudFormationDeployRole:Arn
438+
- !ImportValue iam-cdk:IAM:CloudFormationExecutionRole:Arn
439439
- !Sub arn:aws:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-eu-west-2
440440
Action:
441441
- s3:GetObject*
@@ -1134,7 +1134,7 @@ Resources:
11341134
Type: AWS::IAM::ManagedPolicy
11351135
Properties:
11361136
Roles:
1137-
- !ImportValue ci-resources:CloudFormationExecutionRoleName
1137+
- !ImportValue iam-cdk:IAM:CloudFormationExecutionRole:Name
11381138
PolicyDocument:
11391139
Version: 2012-10-17
11401140
Statement:
@@ -1207,7 +1207,7 @@ Resources:
12071207
Type: AWS::IAM::ManagedPolicy
12081208
Properties:
12091209
Roles:
1210-
- !ImportValue ci-resources:CloudFormationExecutionRoleName
1210+
- !ImportValue iam-cdk:IAM:CloudFormationExecutionRole:Name
12111211
PolicyDocument:
12121212
Version: 2012-10-17
12131213
Statement:
@@ -1271,7 +1271,7 @@ Resources:
12711271
Type: AWS::IAM::ManagedPolicy
12721272
Properties:
12731273
Roles:
1274-
- !ImportValue ci-resources:CloudFormationExecutionRoleName
1274+
- !ImportValue iam-cdk:IAM:CloudFormationExecutionRole:Name
12751275
PolicyDocument:
12761276
Version: 2012-10-17
12771277
Statement:

cloudformation/artillery_resources.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Resources:
5757
DestinationBucketName:
5858
!Select [
5959
5,
60-
!Split [":", !ImportValue account-resources:AuditLoggingBucket],
60+
!Split [":", !ImportValue account-resources-cdk-uk:Bucket:AuditLoggingBucket:Arn],
6161
]
6262
LogFilePrefix: artilleryIO/
6363
VersioningConfiguration:
@@ -126,7 +126,7 @@ Resources:
126126
- ","
127127
- !Join
128128
- ","
129-
- - !ImportValue account-resources:CloudwatchEncryptionKMSPolicyArn
129+
- - !ImportValue account-resources-cdk-uk:IAM:CloudwatchEncryptionKMSPolicy:Arn
130130

131131
ArtilleryWorkerPolicy:
132132
Type: AWS::IAM::ManagedPolicy
@@ -194,7 +194,7 @@ Resources:
194194
Properties:
195195
LogGroupName: artilleryio-log-group/artilleryio-cluster
196196
RetentionInDays: 30
197-
KmsKeyId: !ImportValue account-resources:CloudwatchLogsKmsKeyArn
197+
KmsKeyId: !ImportValue account-resources-cdk-uk:KMS:CloudwatchLogsKmsKey:Arn
198198

199199
ECSCluster:
200200
Type: "AWS::ECS::Cluster"

cloudformation/ci_resources.yml

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -149,34 +149,34 @@ Resources:
149149
Action:
150150
- secretsmanager:GetSecretValue
151151
Resource:
152-
- !ImportValue account-resources:PfpClientKeySecret
153-
- !ImportValue account-resources:PfpClientCertSecret
154-
- !ImportValue account-resources:PfpClientSandboxKeySecret
155-
- !ImportValue account-resources:PfpClientSandboxCertSecret
156-
- !ImportValue account-resources:PsuClientKeySecret
157-
- !ImportValue account-resources:PsuClientSandboxKeySecret
158-
- !ImportValue account-resources:PsuCACertSecret
159-
- !ImportValue account-resources:PsuCAKeySecret
160-
- !ImportValue account-resources:PsuClientCertSecret
161-
- !ImportValue account-resources:PsuClientSandboxCertSecret
162-
- !ImportValue account-resources:PSUProxygenPrivateKey
163-
- !ImportValue account-resources:PSUProxygenPublicKey
164-
- !ImportValue account-resources:CPSUProxygenPrivateKey
165-
- !ImportValue account-resources:CPSUProxygenPublicKey
166-
- !ImportValue account-resources:ClinicalTrackerClientKeySecret
167-
- !ImportValue account-resources:ClinicalTrackerClientSandboxKeySecret
168-
- !ImportValue account-resources:ClinicalTrackerCACertSecret
169-
- !ImportValue account-resources:ClinicalTrackerCAKeySecret
170-
- !ImportValue account-resources:ClinicalTrackerClientCertSecret
171-
- !ImportValue account-resources:ClinicalTrackerClientSandboxCertSecret
172-
- !ImportValue account-resources:ClinicalTrackerProxygenPrivateKey
173-
- !ImportValue account-resources:ClinicalTrackerProxygenPublicKey
174-
- !ImportValue account-resources:FhirFacadeClientKeySecret
175-
- !ImportValue account-resources:FhirFacadeClientSandboxKeySecret
176-
- !ImportValue account-resources:FhirFacadeCACertSecret
177-
- !ImportValue account-resources:FhirFacadeCAKeySecret
178-
- !ImportValue account-resources:FhirFacadeClientCertSecret
179-
- !ImportValue account-resources:FhirFacadeClientSandboxCertSecret
152+
- !ImportValue secrets-cdk:Secrets:PfpClientKeySecret:Arn
153+
- !ImportValue secrets-cdk:Secrets:PfpClientSandboxCertSecret:Arn
154+
- !ImportValue secrets-cdk:Secrets:PfpClientSandboxKeySecret:Arn
155+
- !ImportValue secrets-cdk:Secrets:PfpClientSandboxCertSecret:Arn
156+
- !ImportValue secrets-cdk:Secrets:PsuClientKeySecret:Arn
157+
- !ImportValue secrets-cdk:Secrets:PsuClientSandboxCertSecret:Arn
158+
- !ImportValue secrets-cdk:Secrets:PsuCACertSecret:Arn
159+
- !ImportValue secrets-cdk:Secrets:PsuCAKeySecret:Arn
160+
- !ImportValue secrets-cdk:Secrets:PsuClientCertSecret:Arn
161+
- !ImportValue secrets-cdk:Secrets:PsuClientSandboxCertSecret:Arn
162+
- !ImportValue secrets-cdk:Secrets:PSUProxygenPrivateKey:Arn
163+
- !ImportValue secrets-cdk:Secrets:PSUProxygenPublicKey:Arn
164+
- !ImportValue secrets-cdk:Secrets:CPSUProxygenPrivateKey:Arn
165+
- !ImportValue secrets-cdk:Secrets:CPSUProxygenPublicKey:Arn
166+
- !ImportValue secrets-cdk:Secrets:ClinicalTrackerClientKeySecret:Arn
167+
- !ImportValue secrets-cdk:Secrets:ClinicalTrackerClientSandboxKeySecret:Arn
168+
- !ImportValue secrets-cdk:Secrets:ClinicalTrackerCACertSecret:Arn
169+
- !ImportValue secrets-cdk:Secrets:ClinicalTrackerCAKeySecret:Arn
170+
- !ImportValue secrets-cdk:Secrets:ClinicalTrackerClientCertSecret:Arn
171+
- !ImportValue secrets-cdk:Secrets:ClinicalTrackerClientSandboxCertSecret:Arn
172+
- !ImportValue secrets-cdk:Secrets:ClinicalTrackerProxygenPrivateKey:Arn
173+
- !ImportValue secrets-cdk:Secrets:ClinicalTrackerProxygenPublicKey:Arn
174+
- !ImportValue secrets-cdk:Secrets:FhirFacadeClientKeySecret:Arn
175+
- !ImportValue secrets-cdk:Secrets:FhirFacadeClientSandboxKeySecret:Arn
176+
- !ImportValue secrets-cdk:Secrets:FhirFacadeCACertSecret:Arn
177+
- !ImportValue secrets-cdk:Secrets:FhirFacadeCAKeySecret:Arn
178+
- !ImportValue secrets-cdk:Secrets:FhirFacadeClientCertSecret:Arn
179+
- !ImportValue secrets-cdk:Secrets:FhirFacadeClientSandboxCertSecret:Arn
180180
- Effect: Allow
181181
Action:
182182
- kms:Decrypt

cloudformation/secrets.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Resources:
55
Type: AWS::SecretsManager::Secret
66
Properties:
77
Description: Private key for prescribing proxygen
8-
KmsKeyId: !ImportValue account-resources:SecretsKMSKeyAlias
8+
KmsKeyId: !ImportValue secrets-cdk:KMS:SecretsKMSKeyAlias:Arn
99
SecretString: ChangeMe
1010
Name: !Sub "${AWS::StackName}-Prescribing-ProxygenPrivateKey"
1111

@@ -29,7 +29,7 @@ Resources:
2929
Type: AWS::SecretsManager::Secret
3030
Properties:
3131
Description: Private key for prescribing proxygen prod
32-
KmsKeyId: !ImportValue account-resources:SecretsKMSKeyAlias
32+
KmsKeyId: !ImportValue secrets-cdk:KMS:SecretsKMSKeyAlias:Arn
3333
SecretString: ChangeMe
3434
Name: "FhirPrescribingProxygen-PrivateKey-prod"
3535

@@ -53,7 +53,7 @@ Resources:
5353
Type: AWS::SecretsManager::Secret
5454
Properties:
5555
Description: Private key for prescribing proxygen ptl
56-
KmsKeyId: !ImportValue account-resources:SecretsKMSKeyAlias
56+
KmsKeyId: !ImportValue secrets-cdk:KMS:SecretsKMSKeyAlias:Arn
5757
SecretString: ChangeMe
5858
Name: "FhirPrescribingProxygen-PrivateKey-ptl"
5959

0 commit comments

Comments
 (0)