Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Commit 12920b5

Browse files
committed
Responding to review feedback
1 parent 8cdc2d6 commit 12920b5

4 files changed

Lines changed: 5 additions & 7 deletions

File tree

src/ServiceLayer.Mesh/FileTypes/NbssAppointmentEvents/ServiceCollectionExtensions.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
using Microsoft.Extensions.DependencyInjection;
22
using ServiceLayer.Mesh.FileTypes.NbssAppointmentEvents.Validation;
33

4-
54
namespace ServiceLayer.Mesh.FileTypes.NbssAppointmentEvents;
65

76
public static class ServiceCollectionExtensions
@@ -11,7 +10,6 @@ public static IServiceCollection ConfigureNbssAppointmentEvents(this IServiceCol
1110
services.AddTransient<IFileTransformer, FileTransformer>();
1211
services.AddTransient<IFileParser, FileParser>();
1312
services.AddTransient<IStagingPersister, StagingPersister>();
14-
1513
services.AddSingleton<IValidationRunner, ValidationRunner>();
1614
services.RegisterValidators();
1715

src/ServiceLayer.Mesh/Functions/FileDiscoveryFunction.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public class FileDiscoveryFunction(
1919
[Function("FileDiscoveryFunction")]
2020
public async Task Run([TimerTrigger("%FileDiscoveryTimerExpression%")] TimerInfo myTimer)
2121
{
22-
logger.LogInformation("{functionName} started.", nameof(FileDiscoveryFunction));
22+
logger.LogInformation("{FunctionName} started.", nameof(FileDiscoveryFunction));
2323

2424
var response = await meshInboxService.GetMessagesAsync(configuration.NbssMeshMailboxId);
2525

src/ServiceLayer.Mesh/Functions/FileExtractFunction.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class FileExtractFunction(
2222
[Function("FileExtractFunction")]
2323
public async Task Run([QueueTrigger("%FileExtractQueueName%")] FileExtractQueueMessage message)
2424
{
25-
logger.LogInformation("{functionName} started. Processing fileId: {fileId}", nameof(FileExtractFunction), message.FileId);
25+
logger.LogInformation("{FunctionName} started. Processing fileId: {FileId}", nameof(FileExtractFunction), message.FileId);
2626

2727
await using var transaction = await serviceLayerDbContext.Database.BeginTransactionAsync();
2828

src/ServiceLayer.Mesh/Functions/FileTransformFunction.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public class FileTransformFunction(
3131
[Function("FileTransformFunction")]
3232
public async Task Run([QueueTrigger("%FileTransformQueueName%")] FileTransformQueueMessage message)
3333
{
34-
logger.LogInformation("{functionName} started. Processing fileId: {fileId}", nameof(FileTransformFunction),
34+
logger.LogInformation("{FunctionName} started. Processing fileId: {FileId}", nameof(FileTransformFunction),
3535
message.FileId);
3636

3737
await using var transaction = await serviceLayerDbContext.Database.BeginTransactionAsync();
@@ -62,7 +62,7 @@ public async Task Run([QueueTrigger("%FileTransformQueueName%")] FileTransformQu
6262

6363
if (file == null)
6464
{
65-
logger.LogWarning("File with id: {fileId} not found in MeshFiles table.", fileId);
65+
logger.LogWarning("File with id: {FileId} not found in MeshFiles table.", fileId);
6666
}
6767

6868
return file;
@@ -128,7 +128,7 @@ private IFileTransformer GetTransformerFor(MeshFileType type)
128128

129129
private async Task HandleTransformationError(MeshFile file, FileTransformQueueMessage message, Exception ex)
130130
{
131-
logger.LogError(ex, "An exception occurred during file transformation for fileId: {fileId}", message.FileId);
131+
logger.LogError(ex, "An exception occurred during file transformation for fileId: {FileId}", message.FileId);
132132
file.Status = MeshFileStatus.FailedTransform;
133133
file.LastUpdatedUtc = DateTime.UtcNow;
134134
await serviceLayerDbContext.SaveChangesAsync();

0 commit comments

Comments
 (0)