Merge pull request #60 from NHSDigital/8998-test-helper-validations

Add system test helper for validation errors

Author: malcolmbaig

manage_breast_screening/config/system_test_setup.py

@@ -2,7 +2,7 @@
 
 import pytest
 from django.contrib.staticfiles.testing import StaticLiveServerTestCase
-from playwright.sync_api import sync_playwright
+from playwright.sync_api import sync_playwright, expect
 
 
 @pytest.mark.system
@@ -26,3 +26,12 @@ def setUp(self):
 
     def tearDown(self):
         self.page.close()
+
+    def expect_validation_error(self, id: str, fieldset_legend: str, error_text: str):
+        summary_box = self.page.locator(".nhsuk-error-summary")
+        error_link = summary_box.locator(f"a[href='#{id}']")
+        expect(error_link).to_have_text(error_text)
+
+        fieldset = self.page.locator('fieldset').filter(has_text=fieldset_legend)
+        error_span = fieldset.locator("span").filter(has_text=error_text)
+        expect(error_span).to_have_id(id)

manage_breast_screening/record_a_mammogram/tests/system/test_user_submits_cannot_go_ahead_form.py

@@ -43,9 +43,16 @@ def when_i_submit_the_form(self):
         self.page.get_by_role("button", name="Continue").click()
 
     def then_i_should_see_validation_errors(self):
-        expect(
-            self.page.locator("#stopped_reasons-error")
-        ).to_have_text(re.compile("A reason for why this appointment cannot continue must be provided"))
+        self.expect_validation_error(
+            id="stopped_reasons-error",
+            fieldset_legend="Why has this appointment been stopped?",
+            error_text="A reason for why this appointment cannot continue must be provided",
+        )
+        self.expect_validation_error(
+            id="decision-error",
+            fieldset_legend="Does the appointment need to be rescheduled?",
+            error_text="Select whether the participant needs to be invited for another appointment"
+        )
 
     def when_i_select_a_reason_for_the_appointment_being_stopped(self):
         self.page.get_by_label("Failed identity check").check()
@@ -58,9 +65,11 @@ def and_i_choose_to_add_the_participant_to_the_reinvite_list(self):
         expect(self.page.get_by_label("Yes, add participant to reinvite list")).to_be_checked()
 
     def then_i_see_an_error_for_other_details(self):
-        expect(
-            self.page.locator("#other_details-error")
-        ).to_have_text(re.compile("Explain why this appointment cannot proceed"))
+        self.expect_validation_error(
+            id="other_details-error",
+            fieldset_legend="Why has this appointment been stopped?",
+            error_text="Explain why this appointment cannot proceed",
+        )
 
     def when_i_fill_in_other_details(self):
         self.page.locator("#other_details").fill("Explain other choice")
@@ -72,4 +81,4 @@ def then_i_see_the_clinics_page(self):
 
     def and_the_appointment_is_updated(self):
         self.appointment.refresh_from_db()
-        self.assertEqual(self.appointment.status, Appointment.Status.ATTENDED_NOT_SCREENED)
+        self.assertEqual(self.appointment.status, Appointment.Status.ATTENDED_NOT_SCREENED)