Simplify logging exceptions

Author: steventux

manage_breast_screening/dicom/tests/test_token_validator.py

@@ -65,7 +65,7 @@ def test_with_expired_signature(
     ):
         validator = TokenValidator()
         assert validator(Mock(headers={"Authorization": "Bearer abc123"})) is None
-        mock_logger.error.assert_called_with("Token is expired", exc_info=True)
+        mock_logger.exception.assert_called_with("Token is expired")
 
     @patch(
         f"{TokenValidator.__module__}.jwt.decode", side_effect=jwt.InvalidAudienceError
@@ -75,8 +75,8 @@ def test_with_invalid_claims(
     ):
         validator = TokenValidator()
         assert validator(Mock(headers={"Authorization": "Bearer abc123"})) is None
-        mock_logger.error.assert_called_with(
-            "Invalid claims. Please check the audience and issuer.", exc_info=True
+        mock_logger.exception.assert_called_with(
+            "Invalid claims. Please check the audience and issuer."
         )
 
     @patch(
@@ -87,8 +87,8 @@ def test_with_invalid_issuer(
     ):
         validator = TokenValidator()
         assert validator(Mock(headers={"Authorization": "Bearer abc123"})) is None
-        mock_logger.error.assert_called_with(
-            "Invalid claims. Please check the audience and issuer.", exc_info=True
+        mock_logger.exception.assert_called_with(
+            "Invalid claims. Please check the audience and issuer."
         )
 
     @patch(f"{TokenValidator.__module__}.jwt.decode", side_effect=jwt.InvalidTokenError)
@@ -97,16 +97,16 @@ def test_with_invalid_token(
     ):
         validator = TokenValidator()
         assert validator(Mock(headers={"Authorization": "Bearer abc123"})) is None
-        mock_logger.error.assert_called_with("Token is invalid", exc_info=True)
+        mock_logger.exception.assert_called_with("Token is invalid")
 
     @patch(f"{TokenValidator.__module__}.jwt.decode", side_effect=Exception)
     def test_with_unexpected_exception(
         self, mock_jwt_decode, mock_logger, mock_get_unverified_header, mock_urlopen
     ):
         validator = TokenValidator()
         assert validator(Mock(headers={"Authorization": "Bearer abc123"})) is None
-        mock_logger.error.assert_called_with(
-            "Unable to parse authentication token.", exc_info=True
+        mock_logger.exception.assert_called_with(
+            "Unable to parse authentication token."
         )
 
     @patch(

manage_breast_screening/dicom/token_validator.py

@@ -62,12 +62,10 @@ def _decode(self, token: str, rsa_key: dict) -> dict | None:
             )
             return payload
         except jwt.ExpiredSignatureError:
-            logger.error("Token is expired", exc_info=True)
+            logger.exception("Token is expired")
         except (jwt.InvalidAudienceError, jwt.InvalidIssuerError):
-            logger.error(
-                "Invalid claims. Please check the audience and issuer.", exc_info=True
-            )
+            logger.exception("Invalid claims. Please check the audience and issuer.")
         except jwt.InvalidTokenError:
-            logger.error("Token is invalid", exc_info=True)
+            logger.exception("Token is invalid")
         except Exception:
-            logger.error("Unable to parse authentication token.", exc_info=True)
+            logger.exception("Unable to parse authentication token.")