Add complete all and continue buttons to medical info page

- Add these buttons to the top and bottom of the page, as submit buttons
  on a form that POSTs to the current URL
- Rework RecordMedicalInformationForm to back these forms, and have its
  save function create all missing medical info review records for the
  appointment
- Have the view wrap the save call to this form in a transaction (as
  we're potentially writing multiple database records)
- Redirect to Awaiting Images when done

Author: malcolmbaig

manage_breast_screening/mammograms/forms/record_medical_information_form.py

@@ -1,18 +1,25 @@
 from django import forms
 
-from manage_breast_screening.nhsuk_forms.fields import ChoiceField
+from manage_breast_screening.participants.models import MedicalInformationSection
 
 
 class RecordMedicalInformationForm(forms.Form):
-    decision = ChoiceField(
-        label="Can imaging go ahead?",
-        choices=(
-            ("continue", "Yes, mark incomplete sections as ‘none’ or ‘no’"),
-            ("dropout", "No, screening cannot proceed"),
-        ),
-        required=True,
-        widget=forms.RadioSelect(),
-    )
+    def __init__(self, *args, appointment, user, **kwargs):
+        self.appointment = appointment
+        self.user = user
+        super().__init__(*args, **kwargs)
 
     def save(self):
-        pass
+        all_sections = [choice[0] for choice in MedicalInformationSection.choices]
+        reviewed_sections = set(
+            self.appointment.medical_information_reviews.values_list(
+                "section", flat=True
+            )
+        )
+        missing_sections = set(all_sections) - reviewed_sections
+
+        for section in missing_sections:
+            self.appointment.medical_information_reviews.create(
+                section=section,
+                reviewed_by=self.user,
+            )

manage_breast_screening/mammograms/jinja2/mammograms/record_medical_information.jinja

@@ -285,3 +285,13 @@
 {% endcall %}
 
 {% endblock %}
+
+{% block wizard_form %}
+  <form method="post">
+    {{ csrf_input }}
+    {{ button({
+      "text": "Complete all and continue",
+      "classes": "nhsuk-u-margin-bottom-4"
+    }) }}
+  </form>
+{% endblock %}

manage_breast_screening/mammograms/tests/forms/test_record_medical_information_form.py

@@ -0,0 +1,49 @@
+import pytest
+
+from manage_breast_screening.mammograms.forms import RecordMedicalInformationForm
+from manage_breast_screening.participants.models import MedicalInformationSection
+from manage_breast_screening.participants.tests.factories import AppointmentFactory
+
+
+@pytest.mark.django_db
+class TestRecordMedicalInformationForm:
+    def test_save_creates_reviews_for_all_missing_sections(self, clinical_user):
+        appointment = AppointmentFactory.create()
+
+        assert appointment.medical_information_reviews.count() == 0
+
+        form = RecordMedicalInformationForm(
+            appointment=appointment,
+            user=clinical_user,
+        )
+        form.save()
+
+        assert appointment.medical_information_reviews.count() == 5
+        all_sections = {choice[0] for choice in MedicalInformationSection.choices}
+        reviewed_sections = set(
+            appointment.medical_information_reviews.values_list("section", flat=True)
+        )
+        assert reviewed_sections == all_sections
+        for review in appointment.medical_information_reviews.all():
+            assert review.reviewed_by == clinical_user
+
+    def test_save_does_nothing_when_all_sections_already_reviewed(
+        self, clinical_user, django_assert_num_queries
+    ):
+        appointment = AppointmentFactory.create()
+
+        for section, _ in MedicalInformationSection.choices:
+            appointment.medical_information_reviews.create(
+                section=section,
+                reviewed_by=clinical_user,
+            )
+
+        assert appointment.medical_information_reviews.count() == 5
+
+        form = RecordMedicalInformationForm(
+            appointment=appointment,
+            user=clinical_user,
+        )
+        form.save()
+
+        assert appointment.medical_information_reviews.count() == 5

manage_breast_screening/mammograms/views/appointment_views.py

@@ -1,6 +1,7 @@
 import logging
 
 from django.contrib import messages
+from django.db import DatabaseError, IntegrityError, transaction
 from django.http import Http404
 from django.shortcuts import redirect, render
 from django.urls import reverse, reverse_lazy
@@ -210,15 +211,26 @@ def get_context_data(self, **kwargs):
 
         return context
 
-    def form_valid(self, form):
-        form.save()
-
-        appointment = self.appointment
+    def get_form_kwargs(self):
+        kwargs = super().get_form_kwargs()
+        kwargs["appointment"] = self.appointment
+        kwargs["user"] = self.request.user
+        return kwargs
 
-        if form.cleaned_data["decision"] == "continue":
-            return redirect("mammograms:awaiting_images", pk=appointment.pk)
-        else:
-            return redirect("mammograms:appointment_cannot_go_ahead", pk=appointment.pk)
+    def form_valid(self, form):
+        try:
+            with transaction.atomic():
+                form.save()
+            return redirect("mammograms:awaiting_images", pk=self.appointment.pk)
+        except (IntegrityError, DatabaseError):
+            messages.add_message(
+                self.request,
+                messages.WARNING,
+                "Unable to complete all sections. Please try again.",
+            )
+            return redirect(
+                "mammograms:record_medical_information", pk=self.appointment.pk
+            )
 
 
 class AppointmentCannotGoAhead(InProgressAppointmentMixin, FormView):

manage_breast_screening/tests/system/clinical/test_reviewing_medical_information.py

@@ -27,6 +27,15 @@ def test_reviewing_each_medical_information_section(self):
             self.when_i_click_next_section(section)
             self.then_the_next_section_is_in_focus(next_section, anchor)
 
+    def test_complete_all_and_continue(self):
+        self.given_i_am_logged_in_as_a_clinical_user()
+        self.and_there_is_an_appointment()
+        self.and_i_am_on_the_record_medical_information_page()
+
+        self.when_i_click_complete_all_and_continue()
+        self.then_i_am_redirected_to_the_images_page()
+        self.and_all_sections_are_reviewed()
+
     def and_there_is_an_appointment(self):
         self.participant = ParticipantFactory()
         self.screening_episode = ScreeningEpisodeFactory(participant=self.participant)
@@ -76,6 +85,24 @@ def then_the_next_section_is_in_focus(self, section_heading: str, anchor: str):
         heading = self.page.get_by_role("heading", level=2, name=section_heading)
         expect(heading).to_be_in_viewport()
 
+    def when_i_click_complete_all_and_continue(self):
+        button = self.page.get_by_role("button", name="Complete all and continue")
+        button.click()
+
+    def then_i_am_redirected_to_the_images_page(self):
+        self.expect_url("mammograms:awaiting_images", pk=self.appointment.pk)
+
+    def and_all_sections_are_reviewed(self):
+        self.page.goto(
+            self.live_server_url
+            + reverse(
+                "mammograms:record_medical_information",
+                kwargs={"pk": self.appointment.pk},
+            )
+        )
+        for section_heading, _, _ in self._medical_information_sections():
+            self.then_section_has_reviewed_tag(section_heading)
+
     def _medical_information_sections(self):
         return [
             ("Mammogram history", "symptoms", "Symptoms"),