Merge pull request #49 from NHSDigital/8998-testing-improvements

8998 Testing improvements

Author: malcolmbaig

Makefile

@@ -1,5 +1,3 @@
-
-
 include scripts/shared.mk
 
 clean:: _clean-docker  # Clean-up project resources (main) @Operations
@@ -19,6 +17,7 @@ dependencies: # Install dependencies needed to build and test the project @Pipel
 
 assets: # Compile assets @Pipeline
 	npm run compile
+	poetry run playwright install
 
 build: # Build the project artefact @Pipeline
 	docker build -t "app:$$(git rev-parse HEAD)" .

README.md

@@ -42,6 +42,8 @@ To run all the tests:
 make test
 ```
 
+Running `make config` beforehand will ensure you have necessary dependencies installed, including the browser needed by playwright for system tests.
+
 ### Dependency management
 Python dependencies are managed via [poetry](https://python-poetry.org/docs/basic-usage/).
 

manage_breast_screening/config/system_test_setup.py

@@ -1,6 +1,6 @@
 from django.contrib.staticfiles.testing import StaticLiveServerTestCase
 import os
-from playwright.sync_api import sync_playwright, expect
+from playwright.sync_api import sync_playwright
 
 class SystemTestCase(StaticLiveServerTestCase):
     @classmethod
@@ -18,6 +18,7 @@ def tearDownClass(cls):
 
     def setUp(self):
         self.page = self.browser.new_page()
+        self.page.set_default_timeout(5000)
 
     def tearDown(self):
         self.page.close()

manage_breast_screening/record_a_mammogram/tests/system/test_user_submits_cannot_go_ahead_form.py

@@ -1,4 +1,5 @@
 import re
+import pytest
 from django.urls import reverse
 from playwright.sync_api import expect
 
@@ -7,9 +8,9 @@
 from manage_breast_screening.participants.tests.factories import ParticipantFactory
 from manage_breast_screening.clinics.models import Appointment
 
-class UserSubmitsCannotGoAheadForm(SystemTestCase):
-    def setUp(self):
-        super().setUp()
+class TestUserSubmitsCannotGoAheadForm(SystemTestCase):
+    @pytest.fixture(autouse=True)
+    def before(self):
         self.participant = ParticipantFactory()
         self.screening_episode = ScreeningEpisodeFactory(participant=self.participant)
         self.appointment = AppointmentFactory(screening_episode=self.screening_episode)