Skip to content

Commit 5571aac

Browse files
committed
Add shell script linter
1 parent f2c98ea commit 5571aac

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

scripts/docker/docker.lib.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ function docker-build() {
4949

5050
# Tag the image with all the stated versions, see the documentation for more details
5151
for version in $(_get-all-effective-versions) latest; do
52-
if [ ! -z "$version" ]; then
52+
if [ -n "$version" ]; then
5353
docker tag "${tag}" "${DOCKER_IMAGE}:${version}"
5454
fi
5555
done
@@ -312,7 +312,7 @@ function _get-effective-tag() {
312312

313313
local tag=$DOCKER_IMAGE
314314
version=$(_get-effective-version)
315-
if [ ! -z "$version" ]; then
315+
if [ -n "$version" ]; then
316316
tag="${tag}:${version}"
317317
fi
318318
echo "$tag"

scripts/shared.mk

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,13 @@ HELP_SCRIPT = \
5959
} \
6060
}
6161

62+
shellscript-lint-all: # Lint all shell scripts in the scripts directory, do not fail on error, just print the error messages @Quality
63+
for file in $$(find scripts -type f -name "*.sh"); do \
64+
file=$${file} scripts/shellscript-linter.sh ||: ; \
65+
done
66+
6267
.PHONY: _install-tool _install-tools
6368
.ONESHELL:
6469
MAKEFLAGS := --no-print-directory
6570
SHELL := /bin/bash
66-
SHELLFLAGS := -cex
71+
SHELLFLAGS := -cex

0 commit comments

Comments
 (0)