save blob_name on an Appointment when reading from storage

We want to avoid reading an incoming data file of
appointments twice - so we need to store some kind
of reference to the original file the Appointment
is from. In the near future we can then check
whether an Appointment already exists from the
file before saving it `create_appointments`

Author: Harriethw

manage_breast_screening/notifications/management/commands/create_appointments.py

@@ -52,7 +52,7 @@ def handle(self, *args, **options):
                             self.stdout.write(f"{clinic} created")
 
                         appt, appt_created = self.update_or_create_appointment(
-                            row, clinic
+                            row, clinic, blob.name
                         )
                         if appt_created:
                             self.stdout.write(f"{appt} created")
@@ -93,10 +93,11 @@ def find_or_create_clinic(self, row: pandas.Series) -> tuple[Clinic, bool]:
         )
 
     def update_or_create_appointment(
-        self, row: pandas.Series, clinic: Clinic
+        self, row: pandas.Series, clinic: Clinic, blob_name: str
     ) -> tuple[Appointment, bool]:
         defaults = {
             "batch_id": row["BatchID"],
+            "blob_name": blob_name,
             "number": row["Sequence"],
             "status": row["Status"],
             "episode_type": row["Episode Type"],

manage_breast_screening/notifications/tests/integration/test_create_appointments_from_azure_storage.py

@@ -27,13 +27,11 @@ def helpers(self):
     @pytest.mark.django_db
     def test_appointments_created_from_file_stored_in_azure(self, helpers):
         today_dirname = datetime.today().strftime("%Y-%m-%d")
+        test_file_path = "ABC_20241202091221_APPT_106.dat"
+        blob_name = f"{today_dirname}/{test_file_path}"
 
-        with open(
-            helpers.get_test_file_path("ABC_20241202091221_APPT_106.dat")
-        ) as test_file:
-            BlobStorage().add(
-                f"{today_dirname}/ABC_20241202091221_APPT_106.dat", test_file.read()
-            )
+        with open(helpers.get_test_file_path(test_file_path)) as test_file:
+            BlobStorage().add(blob_name, test_file.read())
 
         Command().handle(**{"date_str": today_dirname})
 
@@ -80,3 +78,7 @@ def test_appointments_created_from_file_stored_in_azure(self, helpers):
         assert appointments[0].clinic == clinics[0]
         assert appointments[1].clinic == clinics[1]
         assert appointments[2].clinic == clinics[1]
+
+        assert appointments[0].blob_name == blob_name
+        assert appointments[1].blob_name == blob_name
+        assert appointments[2].blob_name == blob_name

manage_breast_screening/notifications/tests/management/commands/test_create_appointments.py

@@ -95,6 +95,10 @@ def test_handle_creates_records(self):
         assert appointments[1].clinic == clinics[1]
         assert appointments[2].clinic == clinics[1]
 
+        assert appointments[0].blob_name == mock_blob.name.return_value
+        assert appointments[1].blob_name == mock_blob.name.return_value
+        assert appointments[2].blob_name == mock_blob.name.return_value
+
     @pytest.mark.django_db
     def test_handles_holding_clinics(self):
         """Test does not create appointments for valid NBSS data marked as a Holding Clinic"""