sonar

Author: swebberuk

manage_breast_screening/core/tests/middleware/test_exception_logging.py

@@ -44,7 +44,7 @@ def test_process_exception_logs_with_authenticated_user(
     ):
         user = self.DummyUser(is_authenticated=True)
         request = self.DummyRequest(user=user, correlation_id="corr-id-123")
-        exception = Exception("Something went wrong")
+        exception = RuntimeError("Something went wrong")
 
         mock_logger = mock.Mock()
         monkeypatch.setattr(
@@ -55,20 +55,20 @@ def test_process_exception_logs_with_authenticated_user(
         middleware.process_exception(request, exception)
 
         mock_logger.exception.assert_called_once_with(
-            "url=/test/, method=GET, user=testuser, correlation_id=corr-id-123, exception_type=Exception Something went wrong",
+            "url=/test/, method=GET, user=testuser, correlation_id=corr-id-123, exception_type=RuntimeError Something went wrong",
             extra={
                 "url": "/test/",
                 "method": "GET",
                 "user": "testuser",
                 "correlation_id": "corr-id-123",
-                "exception_type": "Exception",
+                "exception_type": "RuntimeError",
             },
         )
 
     def test_process_exception_logs_with_anonymous_user(self, monkeypatch, middleware):
         user = self.DummyUser(is_authenticated=False)
         request = self.DummyRequest(user=user, correlation_id=None)
-        exception = Exception("Details of exception")
+        exception = RuntimeError("Details of exception")
 
         mock_logger = mock.Mock()
         monkeypatch.setattr(
@@ -79,19 +79,19 @@ def test_process_exception_logs_with_anonymous_user(self, monkeypatch, middlewar
         middleware.process_exception(request, exception)
 
         mock_logger.exception.assert_called_once_with(
-            "url=/test/, method=GET, user=Anonymous, correlation_id=None, exception_type=Exception Details of exception",
+            "url=/test/, method=GET, user=Anonymous, correlation_id=None, exception_type=RuntimeError Details of exception",
             extra={
                 "url": "/test/",
                 "method": "GET",
                 "user": "Anonymous",
                 "correlation_id": None,
-                "exception_type": "Exception",
+                "exception_type": "RuntimeError",
             },
         )
 
     def test_process_exception_logs_with_no_user(self, monkeypatch, middleware):
         request = self.DummyRequest(user=None, correlation_id="abc")
-        exception = Exception("Fail")
+        exception = RuntimeError("Fail")
 
         mock_logger = mock.Mock()
         monkeypatch.setattr(
@@ -102,19 +102,19 @@ def test_process_exception_logs_with_no_user(self, monkeypatch, middleware):
         middleware.process_exception(request, exception)
 
         mock_logger.exception.assert_called_once_with(
-            "url=/test/, method=GET, user=Anonymous, correlation_id=abc, exception_type=Exception Fail",
+            "url=/test/, method=GET, user=Anonymous, correlation_id=abc, exception_type=RuntimeError Fail",
             extra={
                 "url": "/test/",
                 "method": "GET",
                 "user": "Anonymous",
                 "correlation_id": "abc",
-                "exception_type": "Exception",
+                "exception_type": "RuntimeError",
             },
         )
 
     def test_process_exception_returns_none(self, middleware):
         request = self.DummyRequest()
-        exception = Exception("Some error")
+        exception = RuntimeError("Some error")
         result = middleware.process_exception(request, exception)
         assert result is None
 
@@ -146,7 +146,7 @@ def test_process_exception_logs_correct_path_and_method(
         request = self.DummyRequest(
             path=path, method=method, user=user, correlation_id="x"
         )
-        exception = Exception("err")
+        exception = RuntimeError("err")
 
         mock_logger = mock.Mock()
         monkeypatch.setattr(
@@ -157,13 +157,13 @@ def test_process_exception_logs_correct_path_and_method(
         middleware.process_exception(request, exception)
 
         mock_logger.exception.assert_called_once_with(
-            f"url={path}, method={method}, user=testuser, correlation_id=x, exception_type=Exception err",
+            f"url={path}, method={method}, user=testuser, correlation_id=x, exception_type=RuntimeError err",
             extra={
                 "url": path,
                 "method": method,
                 "user": "testuser",
                 "correlation_id": "x",
-                "exception_type": "Exception",
+                "exception_type": "RuntimeError",
             },
         )