Update TestAppointmentCannotGoAheadForm test case

When testing how the reinvite decision is saved:

- Use parametrize to make the test more succinct
- Assert the starting value of reinvite prior to any changes

Author: malcolmbaig

manage_breast_screening/record_a_mammogram/tests/test_forms.py

@@ -12,26 +12,17 @@ def test_decision_cannot_be_left_blank(self):
 
 @pytest.mark.django_db
 class TestAppointmentCannotGoAheadForm:
-    def test_reinvite_reflects_form_data(self):
+    @pytest.mark.parametrize("decision,reinvite_value", [("True", True), ("False", False)])
+    def test_reinvite_reflects_form_data(self, decision, reinvite_value):
         appointment = AppointmentFactory()
-        form_data = {
-            "stopped_reasons": ["failed_identity_check"],
-            "decision": "True",
-        }
-        form = AppointmentCannotGoAheadForm(form_data, instance=appointment)
-        form.is_valid()
-        form.save()
-        appointment.refresh_from_db()
-        assert appointment.reinvite is True
+        assert appointment.reinvite == False
 
         form_data = {
             "stopped_reasons": ["failed_identity_check"],
-            "decision": "False",
+            "decision": decision,
         }
         form = AppointmentCannotGoAheadForm(form_data, instance=appointment)
         form.is_valid()
         form.save()
         appointment.refresh_from_db()
-        assert appointment.reinvite is False
-
-
+        assert appointment.reinvite == reinvite_value