-
Notifications
You must be signed in to change notification settings - Fork 5
Expand file tree
/
Copy pathtest_views.py
More file actions
410 lines (343 loc) · 13.5 KB
/
test_views.py
File metadata and controls
410 lines (343 loc) · 13.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
import time
from unittest.mock import ANY, Mock
import pytest
from authlib.jose import JsonWebKey, jwt
from django.conf import settings
from django.contrib.auth import get_user_model
from django.http import HttpResponse
from django.test import Client, override_settings
from django.urls import reverse
from pytest_django.asserts import assertInHTML
from manage_breast_screening.clinics.tests.factories import UserAssignmentFactory
@pytest.fixture(autouse=True)
def demo_users():
User = get_user_model()
for first_name, last_name, role in [
("Anna", "Davies", "administrative"),
("Chloë", "Robinson", "clinical"),
("Olivia", "Morgan", "administrative"),
("Ella", "Foster", "clinical"),
]:
user = User.objects.create(
nhs_uid=f"{first_name.lower()}_{last_name.lower()}",
first_name=first_name,
last_name=last_name,
)
UserAssignmentFactory(user=user, **{role: True})
User.objects.create(
nhs_uid="priya_bains",
first_name="Priya",
last_name="Bains",
is_superuser=True,
is_staff=True,
)
@pytest.mark.django_db
def test_get_persona_login(client):
response = client.get(
reverse("auth:persona_login"),
query_params={"next": "/some-url"},
)
assert response.status_code == 200
assertInHTML("Anna Davies", response.text)
assertInHTML("Chloë Robinson", response.text)
assertInHTML("Olivia Morgan", response.text)
assertInHTML("Ella Foster", response.text)
assertInHTML('<input type="hidden" name="next" value="/some-url">', response.text)
@pytest.mark.django_db
def test_post_persona_login(client):
response = client.post(
reverse("auth:persona_login"),
{"username": "anna_davies", "next": "/some-url"},
)
assert response.status_code == 302
assert response.headers["location"] == "/current-provider/select/?next=%2Fsome-url"
@pytest.mark.django_db
def test_post_persona_login_superuser_redirects_to_admin(client):
response = client.post(
reverse("auth:persona_login"),
{"username": "priya_bains"},
)
assert response.status_code == 302
assert response.headers["location"] == "/admin/"
@pytest.mark.django_db
def test_post_persona_login_superuser_with_root_next_redirects_to_admin(client):
response = client.post(
reverse("auth:persona_login"),
{"username": "priya_bains", "next": "/"},
)
assert response.status_code == 302
assert response.headers["location"] == "/admin/"
@pytest.mark.django_db
def test_post_persona_login_superuser_with_next_redirects_to_select_provider(client):
response = client.post(
reverse("auth:persona_login"),
{"username": "priya_bains", "next": "/some-url"},
)
assert response.status_code == 302
assert response.headers["location"] == "/current-provider/select/?next=%2Fsome-url"
@pytest.mark.django_db
@override_settings(CIS2_ACR_VALUES="some-test-acr-value")
def test_cis2_login_uses_configured_acr_values(client, monkeypatch):
mock_client = Mock()
mock_redirect_response = HttpResponse(status=302)
mock_redirect_response["Location"] = "https://cis2.example.com/authorize"
mock_client.authorize_redirect.return_value = mock_redirect_response
monkeypatch.setattr(
"manage_breast_screening.auth.views.get_cis2_client",
lambda: mock_client,
)
monkeypatch.setattr(
"manage_breast_screening.auth.views.cis2_redirect_uri",
lambda: "https://testserver/auth/cis2/callback",
)
client.get(reverse("auth:cis2_login"))
mock_client.authorize_redirect.assert_called_once_with(
ANY,
"https://testserver/auth/cis2/callback",
acr_values="some-test-acr-value",
)
@pytest.mark.django_db
class TestCis2Callback:
@pytest.fixture
def mock_cis2_client_factory(self, monkeypatch):
"""Factory fixture for creating and configuring mock CIS2 clients."""
def _create_mock_client(
id_token_sub="user-123",
userinfo_sub="user-123",
id_assurance_level=3,
authentication_assurance_level=3,
):
mock_client = Mock()
mock_client.authorize_access_token.return_value = {
"userinfo": {
"sub": id_token_sub,
"id_assurance_level": id_assurance_level,
"authentication_assurance_level": authentication_assurance_level,
},
}
mock_client.userinfo.return_value = {"sub": userinfo_sub}
monkeypatch.setattr(
"manage_breast_screening.auth.views.get_cis2_client",
lambda: mock_client,
)
return mock_client
return _create_mock_client
def test_rejects_mismatched_sub(self, client, mock_cis2_client_factory):
"""Test that cis2_callback returns 400 when sub from userinfo doesn't match sub from ID token."""
mock_cis2_client_factory(
id_token_sub="user-123",
userinfo_sub="user-456",
)
response = client.get(reverse("auth:cis2_callback"))
assert response.status_code == 400
assert b"Subject mismatch in CIS2 response" in response.content
@pytest.mark.parametrize(
"acr_values,id_level,auth_level,expected_error",
[
("AAL2_OR_AAL3_ANY", 2, 2, b"Insufficient identity assurance level"),
("AAL2_OR_AAL3_ANY", 3, 1, b"Insufficient authentication assurance level"),
("AAL3_ANY", 3, 2, b"Insufficient authentication assurance level"),
("AAL3_ANY", None, 3, b"Insufficient identity assurance level"),
("AAL3_ANY", 3, None, b"Insufficient authentication assurance level"),
],
ids=[
"id_assurance_level_too_low",
"auth_assurance_level_too_low_for_aal2",
"auth_assurance_level_too_low_for_aal3",
"id_assurance_level_none",
"auth_assurance_level_none",
],
)
def test_rejects_insufficient_assurance_levels(
self,
client,
mock_cis2_client_factory,
acr_values,
id_level,
auth_level,
expected_error,
):
"""Test that cis2_callback rejects authentication when assurance levels are insufficient."""
with override_settings(CIS2_ACR_VALUES=acr_values):
mock_cis2_client_factory(
id_assurance_level=id_level,
authentication_assurance_level=auth_level,
)
response = client.get(reverse("auth:cis2_callback"))
assert response.status_code == 403
assert expected_error in response.content
@pytest.mark.parametrize(
"acr_values,id_level,auth_level",
[
("AAL2_OR_AAL3_ANY", 3, 2),
("AAL3_ANY", 3, 3),
("AAL3_ANY", "3", "3"),
],
ids=[
"aal2_valid",
"aal3_valid",
"levels_provided_as_strings",
],
)
def test_accepts_valid_assurance_levels(
self,
client,
monkeypatch,
mock_cis2_client_factory,
acr_values,
id_level,
auth_level,
):
"""Test that cis2_callback accepts valid assurance levels."""
with override_settings(CIS2_ACR_VALUES=acr_values):
mock_cis2_client_factory(
id_assurance_level=id_level,
authentication_assurance_level=auth_level,
)
mock_user = Mock()
mock_user.nhs_uid = "user-123"
mock_user.is_superuser = False
mock_authenticate = Mock(return_value=mock_user)
mock_login = Mock()
monkeypatch.setattr(
"manage_breast_screening.auth.views.authenticate",
mock_authenticate,
)
monkeypatch.setattr(
"manage_breast_screening.auth.views.auth_login",
mock_login,
)
response = client.get(reverse("auth:cis2_callback"))
assert response.status_code == 302
assert "/current-provider/select/" in response.headers["location"]
mock_authenticate.assert_called_once_with(
ANY, cis2_sub="user-123", cis2_userinfo={"sub": "user-123"}
)
mock_login.assert_called_once_with(ANY, mock_user)
def test_superuser_redirects_to_admin(
self, client, monkeypatch, mock_cis2_client_factory
):
"""Superusers should always be sent to the admin site after login."""
mock_cis2_client_factory()
mock_user = Mock()
mock_user.nhs_uid = "user-123"
mock_user.is_superuser = True
monkeypatch.setattr(
"manage_breast_screening.auth.views.authenticate",
Mock(return_value=mock_user),
)
monkeypatch.setattr("manage_breast_screening.auth.views.auth_login", Mock())
response = client.get(reverse("auth:cis2_callback"))
assert response.status_code == 302
assert response.headers["location"] == "/admin/"
@pytest.mark.django_db
class TestJwksView:
def test_returns_single_key_when_only_current_key_configured(self, client):
response = client.get(reverse("auth:jwks"))
assert response.status_code == 200
keys = response.json()["keys"]
assert len(keys) == 1
assert keys[0]["kty"] == "RSA"
assert keys[0]["use"] == "sig"
assert keys[0]["alg"] == "RS512"
assert "kid" in keys[0]
@override_settings(CIS2_OLD_PRIVATE_KEY=settings.CIS2_CLIENT_PRIVATE_KEY)
def test_returns_two_keys_when_old_key_configured(self, client):
response = client.get(reverse("auth:jwks"))
assert response.status_code == 200
keys = response.json()["keys"]
assert len(keys) == 2
assert all(k["kty"] == "RSA" for k in keys)
def test_returns_500_on_error(self, client, monkeypatch):
monkeypatch.setattr(
"manage_breast_screening.auth.views.public_jwk_from_rsa_private_key",
Mock(side_effect=Exception("boom")),
)
response = client.get(reverse("auth:jwks"))
assert response.status_code == 500
assert response.json() == {"keys": []}
@pytest.mark.django_db
class TestCis2BackChannelLogout:
@pytest.fixture
def cis2_jwk(self):
return JsonWebKey.generate_key(
"RSA", 2048, is_private=True, options={"kid": "test-key-1"}
)
@pytest.fixture
def mock_cis2_client(self, monkeypatch, cis2_jwk):
mock_client = Mock()
mock_client.load_server_metadata.return_value = {"issuer": "test-issuer"}
mock_client.fetch_jwk_set.return_value = {
"keys": [cis2_jwk.as_dict(is_private=False)]
}
monkeypatch.setattr(
"manage_breast_screening.auth.views.get_cis2_client",
lambda: mock_client,
)
return mock_client
def _make_logout_token(self, jwk, sub, *, overrides=None):
now = int(time.time())
payload = {
"iss": "test-issuer",
"aud": settings.CIS2_CLIENT_ID,
"iat": now,
"exp": now + 300,
"events": {"https://schemas.openid.net/event/backchannel-logout": {}},
"sub": sub,
"sid": "not-used",
"jti": "not-used",
}
if overrides:
payload.update(overrides)
token = jwt.encode(
{"alg": "RS256", "kid": jwk.kid},
payload,
jwk.as_dict(is_private=True),
)
return token.decode("utf-8")
def test_logs_out_user_for_valid_token(self, mock_cis2_client, cis2_jwk):
User = get_user_model()
user = User.objects.create_user(nhs_uid="user-123", email="user@example.com")
# Sign in on one client (representing the user's browser session)
user_client = Client()
user_client.force_login(user)
assert user.session_set.count() == 1
token = self._make_logout_token(cis2_jwk, sub=user.nhs_uid)
response = Client().post(
reverse("auth:cis2_back_channel_logout"),
data={"logout_token": token},
)
assert response.status_code == 200
assert user.session_set.count() == 0
def test_rejects_request_with_missing_logout_token(self):
response = Client().post(reverse("auth:cis2_back_channel_logout"), data={})
assert response.status_code == 400
assert b"Missing logout_token" in response.content
def test_rejects_expired_token(self, mock_cis2_client, cis2_jwk):
User = get_user_model()
user = User.objects.create_user(nhs_uid="user-123", email="user@example.com")
user_client = Client()
user_client.force_login(user)
now = int(time.time())
token = self._make_logout_token(
cis2_jwk,
sub=user.nhs_uid,
overrides={"iat": now - 300, "exp": now - 120},
)
response = Client().post(
reverse("auth:cis2_back_channel_logout"),
data={"logout_token": token},
)
assert response.status_code == 400
assert b"Invalid logout token" in response.content
assert user.session_set.count() == 1
def test_returns_ok_when_user_does_not_exist_locally(
self, mock_cis2_client, cis2_jwk
):
token = self._make_logout_token(cis2_jwk, sub="unknown-user")
response = Client().post(
reverse("auth:cis2_back_channel_logout"),
data={"logout_token": token},
)
assert response.status_code == 200
assert response.json() == {"status": "ok"}