Skip to content

Commit d870d0b

Browse files
fix: Issue with amend nhs numbers (#1578)
* feat: Update rule 8 transformation * test: Add playwright tests for rule 8 * fix: Test file names * chore: Simplify transform rule * chore: Add in rule8 tests to runner * fix: Updated some tests * chore: delete unused tests * chore: Small fixes * chore: push debug * fix: Remove logging * fix lookup methods * chore: Add Terraform and Docker * fix: update Unit test signature * fix: Test * fix: Update test numbers * fix: Correct rule name --------- Co-authored-by: Michael Clayson <michael.clayson1@nhs.net>
1 parent d45e5de commit d870d0b

3 files changed

Lines changed: 11 additions & 10 deletions

File tree

tests/playwright-tests/src/tests/e2e/testFiles/@DTOSS-A451-01/AMENDED1_-_CAAS_BREAST_SCREENING_COHORT.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
{
44
"validations": {
55
"apiEndpoint": "api/ExceptionManagementDataService",
6-
"NhsNumber": "9997111834",
6+
"NhsNumber": "9301065649",
77
"RuleId": 8,
8-
"RuleDescription": "Participant was transformed as transform rule: UpdatedRecordExcludedAndDMS was executed"
8+
"RuleDescription": "Participant was transformed as transform rule: TransformUpdatedRecordExcludedAndDMS was executed"
9+
910
},
1011
"meta": {
1112
"testJiraId": "@DTOSS-10451-01",

tests/playwright-tests/src/tests/e2e/testFiles/@DTOSS-A453-01/AMENDED1_-_CAAS_BREAST_SCREENING_COHORT.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
{
44
"validations": {
55
"apiEndpoint": "api/ExceptionManagementDataService",
6-
"NhsNumber": "9997111834",
6+
"NhsNumber": "9998136431",
77
"RuleId": 8,
8-
"RuleDescription": "Participant was transformed as transform rule: UpdatedRecordExcludedAndDMS was executed"
8+
"RuleDescription": "Participant was transformed as transform rule: TransformUpdatedRecordExcludedAndDMS was executed"
99
},
1010
"meta": {
1111
"testJiraId": "@DTOSS-10453-01",
@@ -19,7 +19,7 @@
1919
"record_type": "AMENDED",
2020
"change_time_stamp": null,
2121
"serial_change_number": 1,
22-
"nhs_number": 9997111834,
22+
"nhs_number": 9998136431,
2323
"superseded_by_nhs_number": null,
2424
"primary_care_provider": "A91203",
2525
"primary_care_effective_from_date": "20130319",
@@ -57,6 +57,6 @@
5757
}
5858
],
5959
"nhsNumbers": [
60-
"9997111834"
60+
"9998136431"
6161
]
6262
}

tests/playwright-tests/src/tests/e2e/testFiles/@DTOSS-A454-01/AMENDED1_-_CAAS_BREAST_SCREENING_COHORT.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
{
44
"validations": {
55
"apiEndpoint": "api/ExceptionManagementDataService",
6-
"NhsNumber": "9997111834",
6+
"NhsNumber": "9998136431",
77
"RuleId": 8,
8-
"RuleDescription": "Participant was transformed as transform rule: UpdatedRecordExcludedAndDMS was executed"
8+
"RuleDescription": "Participant was transformed as transform rule: TransformUpdatedRecordExcludedAndDMS was executed"
99
},
1010
"meta": {
1111
"testJiraId": "@DTOSS-10454-01",
@@ -19,7 +19,7 @@
1919
"record_type": "AMENDED",
2020
"change_time_stamp": null,
2121
"serial_change_number": 1,
22-
"nhs_number": 9997111834,
22+
"nhs_number": 9998136431,
2323
"superseded_by_nhs_number": null,
2424
"primary_care_provider": "B45666",
2525
"primary_care_effective_from_date": "20130319",
@@ -57,6 +57,6 @@
5757
}
5858
],
5959
"nhsNumbers": [
60-
"9997111834"
60+
"9998136431"
6161
]
6262
}

0 commit comments

Comments
 (0)