refactor: PageSize and LastResultId removed from PaginationResult Model, tests updated (#1617)

Author: Warren-Pitterson

application/CohortManager/src/Functions/Shared/Common/Pagination/PaginationResult.cs

@@ -6,9 +6,7 @@ public class PaginationResult<T>
     public bool IsFirstPage { get; set; }
     public bool HasNextPage { get; set; }
     public bool HasPreviousPage { get; set; }
-    public int? LastResultId { get; set; }
     public int TotalItems { get; set; }
     public int TotalPages { get; set; }
     public int CurrentPage { get; set; }
-    public int PageSize { get; set; }
 }

application/CohortManager/src/Functions/Shared/Common/Pagination/PaginationService.cs

@@ -31,11 +31,9 @@ public PaginationResult<T> GetPaginatedResult(IQueryable<T> source, int page = 1
             IsFirstPage = page == 1,
             HasNextPage = page < totalPages,
             HasPreviousPage = page > 1,
-            LastResultId = null, // Not used in page-based pagination
             TotalItems = totalItems,
             TotalPages = totalPages,
             CurrentPage = page,
-            PageSize = pageSize
         };
     }
 

tests/UnitTests/ScreeningDataServicesTests/ValidationExceptionDataTests/GetValidationExceptionTests/GetValidationExceptionsTests.cs

@@ -137,7 +137,6 @@ public async Task Run_NoExceptionIdQueryParameter_ReturnsAllExceptions()
             CurrentPage = 1,
             TotalItems = 3,
             TotalPages = 1,
-            PageSize = 10
         };
 
         var expectedHeaders = new Dictionary<string, string> { { "X-Total-Count", "3" } };
@@ -175,7 +174,6 @@ public async Task Run_WhenIsReportTrueWithValidDate_ReturnsReportExceptions()
             CurrentPage = 1,
             TotalItems = reportExceptions.Count,
             TotalPages = 1,
-            PageSize = 10
         };
 
         var expectedHeaders = new Dictionary<string, string> { { "X-Total-Count", "2" } };
@@ -237,7 +235,6 @@ public async Task Run_WhenIsReportTrueWithNullDate_ReturnsReportExceptions()
             CurrentPage = 1,
             TotalItems = allReportExceptions.Count,
             TotalPages = 1,
-            PageSize = 10
         };
 
         var expectedHeaders = new Dictionary<string, string> { { "X-Total-Count", allReportExceptions.Count.ToString() } };
@@ -280,7 +277,6 @@ public async Task Run_WhenIsReportTrueWithTodaysDate_ReturnsReportExceptions()
             CurrentPage = 1,
             TotalItems = todaysReportExceptions.Count,
             TotalPages = 1,
-            PageSize = 10
         };
 
         var expectedHeaders = new Dictionary<string, string> { { "X-Total-Count", todaysReportExceptions.Count.ToString() } };
@@ -343,7 +339,6 @@ public async Task Run_WithDifferentExceptionCategory_ReturnsCorrectExceptions()
             CurrentPage = 1,
             TotalItems = boExceptions.Count,
             TotalPages = 1,
-            PageSize = 10
         };
 
         var expectedHeaders = new Dictionary<string, string> { { "X-Total-Count", boExceptions.Count.ToString() } };
@@ -394,7 +389,6 @@ public async Task Run_WithMultipleFilters_AppliesAllCorrectly()
             CurrentPage = pageNumber,
             TotalItems = filteredAndSortedExceptions.Count,
             TotalPages = 2,
-            PageSize = 1
         };
 
         var expectedHeaders = new Dictionary<string, string>
@@ -487,7 +481,6 @@ public async Task Run_NoExceptionsFound_ReturnsOkWithEmptyList()
             CurrentPage = 1,
             TotalItems = 0,
             TotalPages = 0,
-            PageSize = 10
         };
 
         var expectedHeaders = new Dictionary<string, string> { { "X-Total-Count", "0" } };
@@ -553,7 +546,6 @@ public async Task Run_WithExceptionStatus_ReturnsFilteredExceptions()
             CurrentPage = 1,
             TotalItems = 2,
             TotalPages = 1,
-            PageSize = 10
         };
 
         var expectedHeaders = new Dictionary<string, string> { { "X-Total-Count", "2" } };
@@ -594,7 +586,6 @@ public async Task Run_WithSortOrder_ReturnsOrderedExceptions()
             CurrentPage = 1,
             TotalItems = sortedExceptions.Count,
             TotalPages = 1,
-            PageSize = 10
         };
 
         var expectedHeaders = new Dictionary<string, string> { { "X-Total-Count", sortedExceptions.Count.ToString() } };
@@ -635,7 +626,6 @@ public async Task Run_WithPageParameter_ReturnsPaginatedResults()
             CurrentPage = pageNumber,
             TotalItems = _exceptionList.Count,
             TotalPages = 3,
-            PageSize = 2
         };
 
         var expectedHeaders = new Dictionary<string, string> {
@@ -681,7 +671,7 @@ public async Task Run_WithPageZero_DefaultsToPage1()
             CurrentPage = 1,
             TotalItems = _exceptionList.Count,
             TotalPages = 1,
-            PageSize = 10
+
         };
 
         var expectedHeaders = new Dictionary<string, string> { { "X-Total-Count", _exceptionList.Count.ToString() } };
@@ -720,7 +710,7 @@ public async Task Run_WithNegativePage_DefaultsToPage1()
             CurrentPage = 1,
             TotalItems = _exceptionList.Count,
             TotalPages = 1,
-            PageSize = 10
+
         };
 
         var expectedHeaders = new Dictionary<string, string> { { "X-Total-Count", _exceptionList.Count.ToString() } };
@@ -780,7 +770,7 @@ public async Task Run_PaginationServiceThrowsException_ReturnsInternalServerErro
             CurrentPage = 1,
             TotalItems = reportExceptions.Count,
             TotalPages = 1,
-            PageSize = 10
+
         };
 
         var expectedHeaders = new Dictionary<string, string> { { "X-Total-Count", reportExceptions.Count.ToString() } };