Skip to content

Commit c8108c6

Browse files
committed
feat: devtest using pr number as image identifier
1 parent ea0ce3f commit c8108c6

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

.github/workflows/stage-3-build-images-devtest.yaml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ jobs:
143143
if: ${{ steps.detect-base-image-changes.outputs.BASE_IMAGE_CHANGE == 'true' || github.ref == 'refs/heads/main' }}
144144
continue-on-error: false
145145
run: |
146-
PR_NUM_TAG=${PR_NUM_TAG}
146+
PR_NUM_TAG=pr${PR_NUM_TAG}
147147
SHORT_COMMIT_HASH=$(git rev-parse --short ${GITHUB_SHA})
148148
echo $SHORT_COMMIT_HASH
149149
echo $PR_NUM_TAG
@@ -170,7 +170,7 @@ jobs:
170170
id: set-image-tags
171171
run: |
172172
173-
PR_NUM_TAG=$(echo "${GITHUB_REF}" | sed 's/refs\/pull\/\([0-9]*\)\/merge/\1/')
173+
PR_NUM_TAG=pr${PR_NUM_TAG}
174174
IMAGE_TAG="latest"
175175
176176
# if [[ ${{steps.detect-base-image-changes.outputs.BASE_IMAGE_CHANGE}} == 'true' ]]; then
@@ -201,7 +201,7 @@ jobs:
201201
function: ${{ fromJSON(needs.get-functions.outputs.FUNC_NAMES) }}
202202
if: needs.get-functions.outputs.FUNC_NAMES != '[]'
203203
outputs:
204-
pr_num_tag: ${{ env.PR_NUM_TAG }}
204+
# pr_num_tag: ${{ env.PR_NUM_TAG }}
205205
short_commit_hash: ${{ env.COMMIT_HASH_TAG }}
206206
devtest_commit_hash: ${{ env.DEVTEST_HASH_TAG }}
207207
devtest_pr_num_tag: ${{ env.DEVTEST_PR_NUM_TAG }}
@@ -239,17 +239,17 @@ jobs:
239239
run: |
240240
echo "The branch is: ${GITHUB_REF}"
241241
242-
if [[ "${GITHUB_REF}" == refs/pull/*/merge ]]; then
243-
PR_NUM_TAG=$(echo "${GITHUB_REF}" | sed 's/refs\/pull\/\([0-9]*\)\/merge/\1/')
244-
else
245-
PULLS_JSON=$(gh api /repos/{owner}/{repo}/commits/${GITHUB_SHA}/pulls)
246-
ORIGINATING_BRANCH=$(echo ${PULLS_JSON} | jq -r '.[].head.ref' | python3 -c "import sys, urllib.parse; print(urllib.parse.quote_plus(sys.stdin.read().strip()))")
247-
echo "ORIGINATING_BRANCH: ${ORIGINATING_BRANCH}"
248-
PR_NUM_TAG=$(echo ${PULLS_JSON} | jq -r '.[].number')
249-
fi
242+
# if [[ "${GITHUB_REF}" == refs/pull/*/merge ]]; then
243+
# PR_NUM_TAG=$(echo "${GITHUB_REF}" | sed 's/refs\/pull\/\([0-9]*\)\/merge/\1/')
244+
# else
245+
# PULLS_JSON=$(gh api /repos/{owner}/{repo}/commits/${GITHUB_SHA}/pulls)
246+
# ORIGINATING_BRANCH=$(echo ${PULLS_JSON} | jq -r '.[].head.ref' | python3 -c "import sys, urllib.parse; print(urllib.parse.quote_plus(sys.stdin.read().strip()))")
247+
# echo "ORIGINATING_BRANCH: ${ORIGINATING_BRANCH}"
248+
# PR_NUM_TAG=$(echo ${PULLS_JSON} | jq -r '.[].number')
249+
# fi
250250
251251
echo "PR_NUM_TAG: pr${PR_NUM_TAG}"
252-
echo "PR_NUM_TAG=pr${PR_NUM_TAG}" >> ${GITHUB_ENV}
252+
# echo "PR_NUM_TAG=pr${PR_NUM_TAG}" >> ${GITHUB_ENV}
253253
254254
DEVTEST_PR_NUM_TAG="devtest_${PR_NUM_TAG}"
255255
echo "Devtest Pr Num tag: ${DEVTEST_PR_NUM_TAG}"
@@ -300,8 +300,8 @@ jobs:
300300
export CHECK_DOCKER_IMAGE=${PROJECT_NAME}-${function}:latest
301301
export FORCE_USE_DOCKER=true
302302
303-
export PR_NUM_TAG=${PR_NUM_TAG}
304-
echo "PR_NUM_TAG=${PR_NUM_TAG}" >> ${GITHUB_ENV}
303+
# export PR_NUM_TAG=${PR_NUM_TAG}
304+
# echo "PR_NUM_TAG=${PR_NUM_TAG}" >> ${GITHUB_ENV}
305305
306306
# Push the image to the repository
307307
docker push "${repo_name}:${DEVTEST_PR_NUM_TAG}"

0 commit comments

Comments
 (0)