test: updated tests

Author: Joseph2910

application/CohortManager/src/Functions/Shared/Utilities/MappingUtilities.cs

@@ -16,15 +16,14 @@ public static class MappingUtilities
     /// <summary>
     /// Parses flags that can be Y, N, 0 or 1, such as the exception flag
     /// </summary>
-    public static short ParseStringFlag(string? flag)
+    public static short ParseStringFlag(string flag)
     {
         return flag?.ToUpper() switch
         {
             "0" => 0,
             "1" => 1,
             "Y" => 1,
             "N" => 0,
-            null => throw new ArgumentException("Invalid input"),
             _ => throw new ArgumentException("Invalid input"),
         };
     }

tests/UnitTests/SharedTests/MappingUtilitiesTests/MappingUtilitiesTests.cs

@@ -1,7 +1,7 @@
-using NHS.CohortManager.Shared.Utilities;
-
 namespace MappingUtilitiesTests;
 
+using NHS.CohortManager.Shared.Utilities;
+
 [TestClass]
 public class MappingUtilitiesTests
 {
@@ -49,7 +49,6 @@ public void ParseStringFlag_ValidInput_ReturnDate(string flag, short expectedRes
 
     [TestMethod]
     [DataRow("W")]
-    [DataRow(null)]
     public void ParseStringFlag_InvalidInput_ReturnArguementError(string flag)
     {
         //No Arrange or Act