chore: addressing comments on PR

Author: SamRobinson75684

application/CohortManager/src/Functions/CohortDistributionServices/TransformDataService/TransformDataLookupFacade.cs

@@ -63,8 +63,13 @@ public async Task<HashSet<string>> GetCachedExcludedSMUValues()
 
     public bool ValidateOutcode(string postcode)
     {
-        var parsedOutCode = ValidationHelper.ParseOutcode(postcode);
-        _ = parsedOutCode
+        //if a postcode is a dummy postcode then we want to allow the rules to know that we have a dummy postcode
+        if (postcode.StartsWith("ZZ"))
+        {
+            return false;
+        }
+
+        string parsedOutCode = ValidationHelper.ParseOutcode(postcode)
             ?? throw new TransformationException("Postcode format invalid");
 
         var result = _outcodeClient.GetSingle(parsedOutCode).Result;

application/CohortManager/src/Functions/Shared/Common/ValidationHelper.cs

@@ -103,7 +103,7 @@ public static bool ValidatePostcode(string postcode)
     }
 
     /// <summary>
-    /// Gets the outcode (1st part of postcode) from the postcode and if the postcode is a dummy code
+    /// Gets the outcode (1st part of postcode) from the postcode.
     /// </summary>
     /// <param name="postcode">a non-null string representing the postcode</param>
     /// <remarks>
@@ -113,15 +113,8 @@ public static bool ValidatePostcode(string postcode)
     public static string? ParseOutcode(string postcode)
     {
         string pattern = @"^([A-Za-z][A-Za-z]?[0-9][A-Za-z0-9]?) ?[0-9][A-Za-z]{2}$";
-        string specialDummyOutCodePattern = "^ZZ99|^ZZZSECUR$";
 
         Match match = Regex.Match(postcode, pattern, RegexOptions.IgnoreCase, TimeSpan.FromSeconds(2));
-        Match dummyOutCodePattern = Regex.Match(postcode, specialDummyOutCodePattern, RegexOptions.IgnoreCase, TimeSpan.FromSeconds(2));
-
-        if (dummyOutCodePattern.Success)
-        {
-            return dummyOutCodePattern.Groups[1].Value;
-        }
 
         if (!match.Success)
         {