fix: changing rule category on rule 54 and 12 to match requirements (#1612)

* fix: changing rule category on rule 54 and 12 to match requierments

* fix: changing rule category on rule 54 and 12 to match requierments

Author: SamRobinson75684

application/CohortManager/src/Functions/ScreeningValidationService/LookupValidation/Breast_Screening_lookupRules.json

@@ -13,7 +13,7 @@
     ],
     "Rules": [
       {
-        "RuleName": "12.BlockedParticipant.BSSelect.Fatal",
+        "RuleName": "12.BlockedParticipant.Non.Fatal",
         "Expression": "existingParticipant.BlockedFlag != \"1\"",
         "Actions": {
           "OnFailure": {
@@ -56,7 +56,7 @@
     "WorkflowName": "AMENDED",
     "Rules": [
       {
-        "RuleName": "54.ValidateBsoCode.NBO.NonFatal",
+        "RuleName": "54.ValidateBsoCode.Non.NonFatal",
         "LocalParams": [
           {
             "Name": "reasonForRemoval",

tests/UnitTests/ScreeningValidationServiceTests/LookupValidation/LookupValidationTests.cs

@@ -145,7 +145,7 @@ public async Task Run_invalidParticipant_ValidateBsoCodeRuleFails(string ReasonF
         string body = await AssertionHelper.ReadResponseBodyAsync(response);
 
         // Assert
-        StringAssert.Contains(body, "54.ValidateBsoCode.NBO.NonFatal");
+        StringAssert.Contains(body, "54.ValidateBsoCode.Non.NonFatal");
     }
 
     [TestMethod]
@@ -232,7 +232,7 @@ public async Task Run_AmendedRFRParticipantHasInvalidPostcodeAndGpPractice_Retur
         string body = await AssertionHelper.ReadResponseBodyAsync(response);
 
         // Assert
-        StringAssert.Contains(body, "54.ValidateBsoCode.NBO.NonFatal");
+        StringAssert.Contains(body, "54.ValidateBsoCode.Non.NonFatal");
     }
 
     [TestMethod]
@@ -306,7 +306,7 @@ public async Task Run_BlockedParticipant_ReturnValidationException()
         string body = await AssertionHelper.ReadResponseBodyAsync(response);
 
         // Assert
-        StringAssert.Contains(body, "12.BlockedParticipant.BSSelect.Fatal");
+        StringAssert.Contains(body, "12.BlockedParticipant.Non.Fatal");
     }
 
     [TestMethod]