DTOSS-10107 resolve PR comments

sudipnhs · sudipnhs · commit 829ccc78a361 · 2025-08-11T15:39:11.000+01:00
diff --git a/application/CohortManager/src/Functions/ScreeningValidationService/StaticValidation/Breast_Screening_staticRules.json b/application/CohortManager/src/Functions/ScreeningValidationService/StaticValidation/Breast_Screening_staticRules.json
@@ -97,7 +97,7 @@
     "Rules": [
       {
         "RuleName": "30.Postcode.NBO.NonFatal",
-        "Expression": "string.IsNullOrEmpty(participant.Postcode) OR ValidationHelper.ValidatePostcode(participant.Postcode) OR participant.Postcode == \"ZZZSECUR\" OR participant.Postcode == \"ZZ99\"",
+        "Expression": "string.IsNullOrEmpty(participant.Postcode) OR ValidationHelper.ValidatePostcode(participant.Postcode) OR participant.Postcode == \"ZZZSECUR\"",
         "Actions": {
           "OnFailure": {
             "Name": "OutputExpression",
diff --git a/tests/UnitTests/ScreeningValidationServiceTests/StaticValidation/StaticValidationTests.cs b/tests/UnitTests/ScreeningValidationServiceTests/StaticValidation/StaticValidationTests.cs
@@ -210,7 +210,6 @@ public async Task Run_DelRecord_DoNotRunCommonRules()
     [DataRow("ZZ99 9FZ")]
     [DataRow("ZZ999FZ")]
     [DataRow("ZZ99 3WZ")]
-    [DataRow("ZZ99")]
     [DataRow("ZZZSECUR")]
     public async Task Run_ValidPostcode_ReturnNoContent(string postcode)
     {

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@`
`97`	`97`	`"Rules": [`
`98`	`98`	`{`
`99`	`99`	`"RuleName": "30.Postcode.NBO.NonFatal",`
`100`		`- "Expression": "string.IsNullOrEmpty(participant.Postcode) OR ValidationHelper.ValidatePostcode(participant.Postcode) OR participant.Postcode == \"ZZZSECUR\" OR participant.Postcode == \"ZZ99\"",`
	`100`	`+ "Expression": "string.IsNullOrEmpty(participant.Postcode) OR ValidationHelper.ValidatePostcode(participant.Postcode) OR participant.Postcode == \"ZZZSECUR\"",`
`101`	`101`	`"Actions": {`
`102`	`102`	`"OnFailure": {`
`103`	`103`	`"Name": "OutputExpression",`
Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,6 @@ public async Task Run_DelRecord_DoNotRunCommonRules()`
`210`	`210`	`[DataRow("ZZ99 9FZ")]`
`211`	`211`	`[DataRow("ZZ999FZ")]`
`212`	`212`	`[DataRow("ZZ99 3WZ")]`
`213`		`- [DataRow("ZZ99")]`
`214`	`213`	`[DataRow("ZZZSECUR")]`
`215`	`214`	`public async Task Run_ValidPostcode_ReturnNoContent(string postcode)`
`216`	`215`	`{`