Merge branch 'main' into Remove-Unused-Functionality-ValidationHelperV2

Author: Joseph2910

docs/user-guides/Local_machine_setup.md

@@ -11,6 +11,8 @@
 - Signed Git commits (if you would like to contribute): \
     [Using 1Password](https://developer.1password.com/docs/ssh/git-commit-signing/) is the easiest option if you have it, otherwise use the below link for instructions \
     <https://github.com/NHSDigital/software-engineering-quality-framework/blob/main/practices/guides/commit-signing.md>
+- Added the git submodule:
+  `git submodule update --init --recursive`
 
 ## Set-up
 

tests/UnitTests/StaticTests/ValidationHelperTests.cs

@@ -20,6 +20,9 @@ public void ValidateNhsNumber_ValidNHNumbers_ReturnsTrue(string nhsNumber)
     }
 
     [TestMethod]
+    [DataRow(null)]
+    [DataRow("-1234567890")]    
+    [DataRow("1a2b3c4d5e")]
     [DataRow("1234567890")]
     [DataRow("9876543219")]
     [DataRow("123456789")]
@@ -36,39 +39,26 @@ public void ValidateNhsNumber_InvalidNHNumbers_ReturnsFalse(string nhsNumber)
     }
 
     [TestMethod]
-    [DataRow("1990-10-10")]
-    [DataRow("2002-04-06")]
-    [DataRow("1997-12-23")]
-    [DataRow("2010-01-01")]
-    [DataRow("2005-12-10")]
+    [DataRow("20000101")]               //  yyyymmdd
+    [DataRow("200001")]                 //  yyyymm
+    [DataRow("2000-01-01")]             //  yyyy-mm-dd
+    [DataRow("01/01/2000 12:00:00")]    //  dd/mm/yyyy hh:mm:ss
+    [DataRow("2000")]                   //  yyyy
     public void ValidatePastDate_ValidPastDate_ReturnsTrue(string pastDate)
     {
         var result = ValidationHelper.ValidatePastDate(pastDate);
 
         Assert.IsTrue(result);
     }
 
-
-    [TestMethod]
-    [DataRow("1990-10-10")]
-    [DataRow("2002-04-06")]
-    [DataRow("1997-12-23")]
-    [DataRow("2010-01-01")]
-    [DataRow("2005-12-10")]
-    public void ValidateDate_ValidDate_ReturnsTrue(string date)
-    {
-        var result = ValidationHelper.IsValidDate(date);
-
-        Assert.IsTrue(result);
-    }
-
     [TestMethod]
     [DataRow("9999-10-10")]
     [DataRow("3034-04-06")]
     [DataRow("6060-12-23")]
     [DataRow("7070-01-01")]
-    [DataRow("7070-01-01")]
     [DataRow("dfbgdfdggfggg")]
+    [DataRow("-2000")]   
+    [DataRow(null)]               
     public void ValidatePastDate_InvalidPastDate_ReturnsFalse(string pastDate)
     {
         var result = ValidationHelper.ValidatePastDate(pastDate);