test: added further basic unit tests around the MeshPoller and shared Caas subscribe code

Author: SamAinsworth-NHS

tests/UnitTests/DemographicServicesTests/ManageCaasSubscriptionTests/ManageCaasSubscriptionTests.cs

@@ -269,4 +269,22 @@ public void Config_MissingMailboxes_FailsValidation()
         Assert.IsTrue(results.Any(r => r.MemberNames.Contains("CaasToMailbox")));
         Assert.IsTrue(results.Any(r => r.MemberNames.Contains("CaasFromMailbox")));
     }
+
+    [TestMethod]
+    public void Config_MissingMeshApiBaseUrl_FailsValidation()
+    {
+        var cfg = new ManageCaasSubscriptionConfig
+        {
+            CaasToMailbox = "TEST_TO",
+            CaasFromMailbox = "TEST_FROM",
+            MeshCaasSharedKey = "dummy"
+        };
+
+        var context = new ValidationContext(cfg);
+        var results = new System.Collections.Generic.List<ValidationResult>();
+        var isValid = Validator.TryValidateObject(cfg, context, results, validateAllProperties: true);
+
+        Assert.IsFalse(isValid);
+        Assert.IsTrue(results.Any(r => r.MemberNames.Contains("MeshApiBaseUrl")));
+    }
 }

tests/UnitTests/DemographicServicesTests/ManageCaasSubscriptionTests/ManageCaasSubscriptionTests.csproj

@@ -21,6 +21,6 @@
     <ProjectReference Include="..\..\..\TestUtils\TestUtils.csproj" />
     <ProjectReference Include="..\..\..\..\application\CohortManager\src\Functions\Shared\Common\Common.csproj" />
     <ProjectReference Include="..\..\..\..\application\CohortManager\src\Functions\DemographicServices\ManageCaasSubscription\ManageCaasSubscription.csproj" />
+    <ProjectReference Include="..\..\..\..\application\CohortManager\src\Functions\Shared\dotnet-mesh-client\application\DotNetMeshClient\NHS.Mesh.Client\NHS.Mesh.Client.csproj" />
   </ItemGroup>
 </Project>
-

tests/UnitTests/DemographicServicesTests/ManageCaasSubscriptionTests/MeshMailboxExtensionTests.cs

@@ -0,0 +1,39 @@
+namespace NHS.CohortManager.Tests.UnitTests.DemographicServicesTests;
+
+using System.Security.Cryptography.X509Certificates;
+using System.IO;
+using System;
+using Common;
+
+[TestClass]
+public class MeshMailboxExtensionTests
+{
+    [TestMethod]
+    public async Task GetCACertificates_FromFilePath_ReturnsCollection()
+    {
+        var path = FindInParents("nems_certificate.pem");
+        Assert.IsTrue(File.Exists(path), $"Test certificate not found at {path}");
+        var certs = await MeshMailboxExtension.GetCACertificates(path, null);
+        Assert.IsNotNull(certs);
+        Assert.IsInstanceOfType(certs, typeof(X509Certificate2Collection));
+        Assert.IsTrue(certs!.Count > 0);
+    }
+
+    [TestMethod]
+    public async Task GetCACertificates_NoInputs_ReturnsNull()
+    {
+        var certs = await MeshMailboxExtension.GetCACertificates(null, null);
+        Assert.IsNull(certs);
+    }
+    private static string FindInParents(string fileName)
+    {
+        var dir = new DirectoryInfo(AppContext.BaseDirectory);
+        while (dir != null)
+        {
+            var candidate = Path.Combine(dir.FullName, fileName);
+            if (File.Exists(candidate)) return candidate;
+            dir = dir.Parent;
+        }
+        return fileName; // will fail later if not found
+    }
+}

tests/UnitTests/DemographicServicesTests/ManageCaasSubscriptionTests/MeshPollerTests.cs

@@ -0,0 +1,46 @@
+namespace NHS.CohortManager.Tests.UnitTests.DemographicServicesTests;
+
+using System.Threading.Tasks;
+using Common;
+using Microsoft.Extensions.Logging;
+using Moq;
+using NHS.MESH.Client.Contracts.Services;
+using NHS.MESH.Client.Models;
+
+[TestClass]
+public class MeshPollerTests
+{
+    private readonly Mock<ILogger<MeshPoller>> _logger = new();
+    private readonly Mock<IMeshOperationService> _meshOps = new();
+
+    [TestMethod]
+    public async Task ExecuteHandshake_Success_ReturnsTrue()
+    {
+        _meshOps
+            .Setup(m => m.MeshHandshakeAsync(It.IsAny<string>()))
+            .ReturnsAsync(new MeshResponse<HandshakeResponse> { IsSuccessful = true, Response = new HandshakeResponse { MailboxId = "MAILBOX" } });
+
+        var sut = new MeshPoller(_logger.Object, _meshOps.Object);
+        var result = await sut.ExecuteHandshake("MAILBOX");
+        Assert.IsTrue(result);
+    }
+
+    [TestMethod]
+    public async Task ExecuteHandshake_Failure_ReturnsFalse()
+    {
+        _meshOps
+            .Setup(m => m.MeshHandshakeAsync(It.IsAny<string>()))
+            .ReturnsAsync(new MeshResponse<HandshakeResponse> { IsSuccessful = false, Error = new APIErrorResponse { ErrorCode = "500", ErrorDescription = "err" } });
+
+        var sut = new MeshPoller(_logger.Object, _meshOps.Object);
+        var result = await sut.ExecuteHandshake("MAILBOX");
+        Assert.IsFalse(result);
+    }
+
+    [TestMethod]
+    public async Task ShouldExecuteHandshake_NotImplemented_Throws()
+    {
+        var sut = new MeshPoller(_logger.Object, _meshOps.Object);
+        await Assert.ThrowsExceptionAsync<NotImplementedException>(() => sut.ShouldExecuteHandshake("MAILBOX", "config.json"));
+    }
+}

tests/UnitTests/DemographicServicesTests/ManageCaasSubscriptionTests/MeshSendCaasSubscribeTests.cs

@@ -0,0 +1,79 @@
+namespace NHS.CohortManager.Tests.UnitTests.DemographicServicesTests;
+
+using System.Threading.Tasks;
+using Common;
+using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Options;
+using Moq;
+using NHS.MESH.Client.Contracts.Services;
+using NHS.MESH.Client.Models;
+
+[TestClass]
+public class MeshSendCaasSubscribeTests
+{
+    private readonly Mock<ILogger<MeshSendCaasSubscribe>> _logger = new();
+    private readonly Mock<IMeshOutboxService> _meshOutbox = new();
+
+    private MeshSendCaasSubscribe CreateSut(string workflowId = "WF-CAAS-SUB")
+    {
+        var cfg = Options.Create(new MeshSendCaasSubscribeConfig { SendCaasWorkflowId = workflowId });
+        return new MeshSendCaasSubscribe(_logger.Object, _meshOutbox.Object, cfg);
+    }
+
+    [TestMethod]
+    public async Task SendSubscriptionRequest_Success_SendsExpectedAttachment_AndReturnsMessageId()
+    {
+        // Arrange
+        string? capturedFrom = null, capturedTo = null, capturedWorkflow = null;
+        FileAttachment? capturedFile = null;
+        _meshOutbox
+            .Setup(m => m.SendCompressedMessageAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<FileAttachment>(), null, null, false))
+            .Callback((string from, string to, string workflow, FileAttachment file, string? _, string? __, bool ___) =>
+            {
+                capturedFrom = from; capturedTo = to; capturedWorkflow = workflow; capturedFile = file;
+            })
+            .ReturnsAsync(new MeshResponse<SendMessageResponse>
+            {
+                IsSuccessful = true,
+                Response = new SendMessageResponse { MessageId = "MSG123" }
+            });
+
+        var sut = CreateSut();
+
+        // Act
+        var result = await sut.SendSubscriptionRequest(9000000009L, "TO_BOX", "FROM_BOX");
+
+        // Assert
+        Assert.AreEqual("MSG123", result);
+        Assert.AreEqual("FROM_BOX", capturedFrom);
+        Assert.AreEqual("TO_BOX", capturedTo);
+        Assert.AreEqual("WF-CAAS-SUB", capturedWorkflow);
+        Assert.IsNotNull(capturedFile);
+        Assert.AreEqual("CaaSSubscribe.parquet", capturedFile!.FileName);
+        Assert.AreEqual("application/octet-stream", capturedFile.ContentType);
+        Assert.IsNotNull(capturedFile.Content);
+        Assert.IsTrue(capturedFile.Content.Length > 0);
+    }
+
+    [TestMethod]
+    public async Task SendSubscriptionRequest_Failure_ReturnsNull()
+    {
+        // Arrange
+        _meshOutbox
+            .Setup(m => m.SendCompressedMessageAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<FileAttachment>(), null, null, false))
+            .ReturnsAsync(new MeshResponse<SendMessageResponse>
+            {
+                IsSuccessful = false,
+                Error = new APIErrorResponse { ErrorCode = "500", ErrorDescription = "boom" }
+            });
+
+        var sut = CreateSut();
+
+        // Act
+        var result = await sut.SendSubscriptionRequest(9000000009L, "TO_BOX", "FROM_BOX");
+
+        // Assert
+        Assert.IsNull(result);
+    }
+}
+