fix: readded test, corrected pem mock

Author: SamAinsworth-NHS

tests/UnitTests/DemographicServicesTests/ManageCaasSubscriptionTests/MeshMailboxExtensionTests.cs

@@ -11,12 +11,29 @@ public class MeshMailboxExtensionTests
     [TestMethod]
     public async Task GetCACertificates_FromFilePath_ReturnsCollection()
     {
-        var path = FindInParents("nems_certificate.pem");
-        Assert.IsTrue(File.Exists(path), $"Test certificate not found at {path}");
-        var certs = await MeshMailboxExtension.GetCACertificates(path, null);
-        Assert.IsNotNull(certs);
-        Assert.IsInstanceOfType(certs, typeof(X509Certificate2Collection));
-        Assert.IsTrue(certs!.Count > 0);
+        // Create a temporary self-signed certificate and write as PEM to a temp file
+        using var rsa = RSA.Create(2048);
+        var req = new CertificateRequest("CN=Test", rsa, HashAlgorithmName.SHA256, RSASignaturePadding.Pkcs1);
+        using var cert = req.CreateSelfSigned(DateTimeOffset.UtcNow.AddDays(-1), DateTimeOffset.UtcNow.AddDays(1));
+        var der = cert.Export(X509ContentType.Cert);
+        var pem = "-----BEGIN CERTIFICATE-----\n"
+                + Convert.ToBase64String(der, Base64FormattingOptions.InsertLineBreaks)
+                + "\n-----END CERTIFICATE-----\n";
+
+        var tempPath = Path.Combine(Path.GetTempPath(), $"test-cert-{Guid.NewGuid():N}.pem");
+        await File.WriteAllTextAsync(tempPath, pem);
+
+        try
+        {
+            var certs = await MeshMailboxExtension.GetCACertificates(tempPath, null);
+            Assert.IsNotNull(certs);
+            Assert.IsInstanceOfType(certs, typeof(X509Certificate2Collection));
+            Assert.IsTrue(certs!.Count > 0);
+        }
+        finally
+        {
+            if (File.Exists(tempPath)) File.Delete(tempPath);
+        }
     }
 
     [TestMethod]
@@ -25,15 +42,6 @@ public async Task GetCACertificates_NoInputs_ReturnsNull()
         var certs = await MeshMailboxExtension.GetCACertificates(null, null);
         Assert.IsNull(certs);
     }
-    private static string FindInParents(string fileName)
-    {
-        var dir = new DirectoryInfo(AppContext.BaseDirectory);
-        while (dir != null)
-        {
-            var candidate = Path.Combine(dir.FullName, fileName);
-            if (File.Exists(candidate)) return candidate;
-            dir = dir.Parent;
-        }
-        return fileName; // will fail later if not found
-    }
+    // kept for potential future use; not used after temp-cert approach
+    private static string FindInParents(string fileName) => fileName;
 }

tests/UnitTests/DemographicServicesTests/ManageCaasSubscriptionTests/MeshSendCaasSubscribeTests.cs

@@ -0,0 +1,79 @@
+namespace NHS.CohortManager.Tests.UnitTests.DemographicServicesTests;
+
+using System.Threading.Tasks;
+using Common;
+using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Options;
+using Moq;
+using NHS.MESH.Client.Contracts.Services;
+using NHS.MESH.Client.Models;
+
+[TestClass]
+public class MeshSendCaasSubscribeTests
+{
+    private readonly Mock<ILogger<MeshSendCaasSubscribe>> _logger = new();
+    private readonly Mock<IMeshOutboxService> _meshOutbox = new();
+
+    private MeshSendCaasSubscribe CreateSut(string workflowId = "WF-CAAS-SUB")
+    {
+        var cfg = Options.Create(new MeshSendCaasSubscribeConfig { SendCaasWorkflowId = workflowId });
+        return new MeshSendCaasSubscribe(_logger.Object, _meshOutbox.Object, cfg);
+    }
+
+    [TestMethod]
+    public async Task SendSubscriptionRequest_Success_SendsExpectedAttachment_AndReturnsMessageId()
+    {
+        // Arrange
+        string? capturedFrom = null, capturedTo = null, capturedWorkflow = null;
+        FileAttachment? capturedFile = null;
+        _meshOutbox
+            .Setup(m => m.SendCompressedMessageAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<FileAttachment>(), null, null, false))
+            .Callback((string from, string to, string workflow, FileAttachment file, string? _, string? __, bool ___) =>
+            {
+                capturedFrom = from; capturedTo = to; capturedWorkflow = workflow; capturedFile = file;
+            })
+            .ReturnsAsync(new MeshResponse<SendMessageResponse>
+            {
+                IsSuccessful = true,
+                Response = new SendMessageResponse { MessageId = "MSG123" }
+            });
+
+        var sut = CreateSut();
+
+        // Act
+        var result = await sut.SendSubscriptionRequest(9000000009L, "TO_BOX", "FROM_BOX");
+
+        // Assert
+        Assert.AreEqual("MSG123", result);
+        Assert.AreEqual("FROM_BOX", capturedFrom);
+        Assert.AreEqual("TO_BOX", capturedTo);
+        Assert.AreEqual("WF-CAAS-SUB", capturedWorkflow);
+        Assert.IsNotNull(capturedFile);
+        Assert.AreEqual("CaaSSubscribe.parquet", capturedFile!.FileName);
+        Assert.AreEqual("application/octet-stream", capturedFile.ContentType);
+        Assert.IsNotNull(capturedFile.Content);
+        Assert.IsTrue(capturedFile.Content.Length > 0);
+    }
+
+    [TestMethod]
+    public async Task SendSubscriptionRequest_Failure_ReturnsNull()
+    {
+        // Arrange
+        _meshOutbox
+            .Setup(m => m.SendCompressedMessageAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<FileAttachment>(), null, null, false))
+            .ReturnsAsync(new MeshResponse<SendMessageResponse>
+            {
+                IsSuccessful = false,
+                Error = new APIErrorResponse { ErrorCode = "500", ErrorDescription = "boom" }
+            });
+
+        var sut = CreateSut();
+
+        // Act
+        var result = await sut.SendSubscriptionRequest(9000000009L, "TO_BOX", "FROM_BOX");
+
+        // Assert
+        Assert.IsNull(result);
+    }
+}
+