fix: Solve reliability issues

Author: Joseph2910

application/CohortManager/Set-up/scripts/get_local_settings.sh

@@ -35,7 +35,7 @@ process_files() {
         # Read the content of the found local.settings.json file and echo it into the target file
         cat "$file" >> $OUTPUT_SCRIPT
         # Check if this is the last file and add EOF accordingly
-        if [ $index -lt $file_count ]; then
+        if [[ $index -lt $file_count ]]; then
             echo -e "\nEOF" >> $OUTPUT_SCRIPT
         fi
     done

application/CohortManager/src/Web/app/api/GetValidationExceptions/route.ts

@@ -146,7 +146,7 @@ export async function GET(request: Request) {
   const isReport = searchParams.get("isReport");
   const exceptionCategory = searchParams.get("exceptionCategory");
   const reportDate = searchParams.get("reportDate");
-  const page = Math.max(1, parseInt(searchParams.get("page") || "1", 10));
+  const page = Math.max(1, Number.parseInt(searchParams.get("page") || "1", 10));
 
   // Handle single exception requests - get fresh data from store
   if (exceptionId !== null) {

application/CohortManager/src/Web/app/api/UpdateException/route.ts

@@ -48,8 +48,8 @@ export async function PUT(request: NextRequest) {
       );
     }
 
-    const exceptionId = parseInt(updateRequest.ExceptionId, 10);
-    if (isNaN(exceptionId) || exceptionId === 0) {
+    const exceptionId = Number.parseInt(updateRequest.ExceptionId, 10);
+    if (Number.isNaN(exceptionId) || exceptionId === 0) {
       console.warn("Invalid ExceptionId provided:", updateRequest.ExceptionId);
       return NextResponse.json(
         { error: "Invalid ExceptionId provided" },

application/CohortManager/src/Web/app/api/UpdateExceptionServiceNowId/route.ts

@@ -51,7 +51,7 @@ export async function PUT(request: NextRequest) {
     const exceptionId =
       typeof rawExceptionId === "number"
         ? rawExceptionId
-        : parseInt(rawExceptionId, 10);
+        : Number.parseInt(rawExceptionId, 10);
     if (!Number.isFinite(exceptionId) || exceptionId <= 0) {
       console.warn("Invalid ExceptionId provided:", rawExceptionId);
       return NextResponse.json(

application/CohortManager/src/Web/app/exceptions/[filter]/page.tsx

@@ -42,7 +42,7 @@ export default async function Page({
   const sortBy = resolvedSearchParams.sortBy === "0" ? 0 : 1;
   const currentPage = Math.max(
     1,
-    parseInt(resolvedSearchParams.page || "1", 10)
+    Number.parseInt(resolvedSearchParams.page || "1", 10)
   );
 
   const sortOptions = [

application/CohortManager/src/Web/app/exceptions/page.tsx

@@ -52,7 +52,7 @@ export default async function Page({
   const sortBy = resolvedSearchParams.sortBy === "0" ? 0 : 1;
   const currentPage = Math.max(
     1,
-    parseInt(resolvedSearchParams.page || "1", 10)
+    Number.parseInt(resolvedSearchParams.page || "1", 10)
   );
 
   const sortOptions = [

application/CohortManager/src/Web/app/lib/pagination.ts

@@ -116,12 +116,12 @@ export function extractPageFromUrl(url: string): number {
   try {
     const parsed = new URL(url);
     const value = parsed.searchParams.get(PAGE_PARAM);
-    const page = value ? parseInt(value, 10) : 1;
+    const page = value ? Number.parseInt(value, 10) : 1;
     return Number.isNaN(page) ? 1 : Math.max(1, page);
   } catch {
     const pageRegex = new RegExp(`[?&]${PAGE_PARAM}=(\\d+)`);
     const match = pageRegex.exec(url);
-    const page = match ? parseInt(match[1], 10) : 1;
+    const page = match ? Number.parseInt(match[1], 10) : 1;
     return Number.isNaN(page) ? 1 : Math.max(1, page);
   }
 }

application/CohortManager/src/Web/app/lib/utils.ts

@@ -18,7 +18,7 @@ export const formatCompactDate = (dateString: string): string => {
   if (!dateString) return "";
 
   const date = new Date(dateString);
-  if (isNaN(date.getTime())) return "";
+  if (Number.isNaN(date.getTime())) return "";
 
   const day = String(date.getDate()).padStart(2, "0");
   const month = String(date.getMonth() + 1).padStart(2, "0");
@@ -37,7 +37,7 @@ export function getCurrentDate(): string {
 
 export function formatGenderValue(gender?: number | string | null): string {
   if (gender === null || gender === undefined || gender === "") return "";
-  const genderNum = typeof gender === "string" ? parseInt(gender, 10) : gender;
+  const genderNum = typeof gender === "string" ? Number.parseInt(gender, 10) : gender;
   if (genderNum === 1) return "Male";
   if (genderNum === 2) return "Female";
   if (genderNum === 9) return "Unspecified";

scripts/azure/GetImageTagsByManifest.sh

@@ -55,28 +55,28 @@ while [[ "$#" -gt 0 ]]; do
     shift
 done
 
-if [ -z "${containerRegistry}" ]; then
+if [[ -z "${containerRegistry}" ]]; then
   echo "Please provide a container registry argument"
   exit 1
 fi
 
 # stop processing if no image name is provided
-if [ -z "${functionAppName}" ]; then
+if [[ -z "${functionAppName}" ]]; then
   echo "Please provide an image name as an argument"
   exit 1
 fi
 
-if [ -z "${subscriptionId}" ]; then
+if [[ -z "${subscriptionId}" ]]; then
   echo "Please provide a Subscription ID argument"
   exit 1
 fi
 
-if [ -z "${resourceGroup}" ]; then
+if [[ -z "${resourceGroup}" ]]; then
   echo "Please provide a resource group argument"
   exit 1
 fi
 
-if [ verbose == true ]; then
+if [[ verbose == true ]]; then
   echo "function app name: $functionAppName"
   echo "subscription Id: $subscriptionId"
   echo "resourceGroup: $resourceGroup"
@@ -88,13 +88,13 @@ fi
 digest=$(az acr repository show --name $containerRegistry --image $functionAppName:$tag --query 'digest' --output tsv 2> /dev/null)
 
 # stop processing if the image does not exist
-if [ -z "$digest" ]; then
+if [[ -z "$digest" ]]; then
   echo "Image $image not found in $containerRegistry"
   exit 1
 fi
 
 # echo the digest
-if [ verbose == true ]; then
+if [[ verbose == true ]]; then
   echo $digest
 fi
 

scripts/deployment/get-docker-names.sh

@@ -54,7 +54,7 @@ IFS=$', \n'
 
 echo "Adding Docker compose file includes..."
 files_to_process=(${COMPOSE_FILES_CSV})
-while [ ${#files_to_process[@]} -gt 0 ]; do
+while [[ ${#files_to_process[@]} -gt 0 ]]; do
     compose_file="${files_to_process[0]}"
     files_to_process=("${files_to_process[@]:1}")  # Remove the first file from the list
     includes=($(yq -r '.include[]' "${compose_file}"))
@@ -121,7 +121,7 @@ for compose_file in ${COMPOSE_FILES_CSV}; do
     echo
 done
 
-if [ ${#non_matched_changes[@]} -ne 0 ]; then
+if [[ ${#non_matched_changes[@]} -ne 0 ]]; then
     # Remove duplicates (non-matched items across several compose files)
     mapfile -t unique_changes < <(printf "%s\n" "${non_matched_changes[@]}" | sort -u)