fix: resolved PR comments - required attribute, removal of comments, debug outputs

Author: SamAinsworth-NHS

application/CohortManager/compose.core.yaml

@@ -312,7 +312,6 @@ services:
         - AzureWebJobsStorage=${AZURITE_CONNECTION_STRING}
         - ExceptionFunctionURL=http://create-exception:7070/api/CreateException
         - ManageNemsSubscriptionDataServiceURL=http://manage-nems-subscription:9081/api/NemsSubscriptionDataService
-        - ManageNemsSubscriptionBaseURL=http://manage-nems-subscription:9081
         - MeshApiBaseUrl=https://localhost:8700/messageexchange
         - MeshCaasPassword=password
         - MeshCaasSharedKey=TestKey

application/CohortManager/src/Functions/DemographicServices/ManageCaasSubscription/ManageCaasSubscriptionConfig.cs

@@ -9,10 +9,8 @@ public class ManageCaasSubscriptionConfig
     // Example: http://manage-nems-subscription:9081/api/NemsSubscriptionDataService
     public string? ManageNemsSubscriptionDataServiceURL { get; set; }
 
-    // Optional base URL to forward selected endpoints (e.g., CheckSubscriptionStatus)
-    // Example: http://manage-nems-subscription:9081
-    public string? ManageNemsSubscriptionBaseURL { get; set; }
-    public required string MeshApiBaseUrl { get; set; }
+    [Required]
+    public string? MeshApiBaseUrl { get; set; }
     public string? KeyVaultConnectionString { get; set; }
     public bool BypassServerCertificateValidation { get; set; } = false;
     public string? MeshCACertName { get; set; }

application/CohortManager/src/Functions/Shared/Common/Extensions/MeshMailboxExtension.cs

@@ -16,7 +16,7 @@ public static IHostBuilder AddMeshMailboxes(this IHostBuilder hostBuilder, MeshC
     {
         ILoggerFactory factory = LoggerFactory.Create(builder =>
         {
-            builder.AddConsole(); // or AddDebug(), AddEventSourceLogger(), etc.
+            builder.AddConsole();
             builder.AddApplicationInsights();
         });
         _logger = factory.CreateLogger("MeshMailboxExtension");

application/CohortManager/src/Functions/Shared/Common/Mesh/MeshSendCaasSubscribe.cs

@@ -31,9 +31,7 @@ public async Task<string> SendSubscriptionRequest(long nhsNumber, string toMailb
             Content = content,
             ContentType = "application/octet-stream"
         };
-
-        await File.WriteAllBytesAsync("Testpremesh.parquet", content);
-
+        
         var result = await _meshOutboxService.SendCompressedMessageAsync(fromMailbox, toMailbox, _config.SendCaasWorkflowId, file);
         if (!result.IsSuccessful)
         {