Skip to content

Commit d38c8ef

Browse files
authored
DS-2400 Integration Test and Unit Python package Bug (#1011)
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2400>** ## Description of Changes This fixes an issue with a python package after an update to a dependency removed a underlying function. Fixed by removing pytest-bdd package version pinning. Also included in this PR is a temp fix for the build image codebuild jobs. A 20 second sleep has been put in place to give time for the aws ecr security image scan to be ready, before it's checked. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
1 parent 5d5c9ee commit d38c8ef

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

application/requirements-dev.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ locust
55
moto
66
pandas
77
pytest
8-
pytest-bdd == 6.1.1
8+
pytest-bdd
99
pytest-cov
1010
pytest-flakefinder
1111
pytest-html

infrastructure/stacks/development-and-deployment-tools/batch-buildspecs/build-deploy-test-release-batch-jobs/build-arm-image.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,6 @@ phases:
3131

3232
post_build:
3333
commands:
34+
# Temp solution for issue with the scan not being available in time for the aws-ecr-get-security-scan make target
35+
- sleep 20
3436
- make aws-ecr-get-security-scan REPOSITORY=$LAMBDA TAG=$CODEBUILD_RESOLVED_SOURCE_VERSION SHOW_ALL_WARNINGS=true FAIL_ON_WARNINGS=true

0 commit comments

Comments
 (0)