Skip to content

Commit bf18174

Browse files
ajmu1JackPlowmanCorbiscmabe13mik3ola
authored
Release/29.0 (#1122)
# Release Branch Pull Request ## Description of Changes This release was focused around fixing quality check report issue and addressing vulnerabilities in utils and python libs --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Matthew Begley <60427904+mabe13@users.noreply.github.com> Co-authored-by: Jack Plowman <62281988+JackPlowman@users.noreply.github.com> Co-authored-by: Corbisc <95412908+Corbisc@users.noreply.github.com> Co-authored-by: Matthew Begley <60427904+mabe13@users.noreply.github.com> Co-authored-by: mabe13 <matthewbegley@nhs.net> Co-authored-by: Michael Olaw <michael.olaw1@nhs.net> Co-authored-by: Jack Plowman <jack.plowman1@nhs.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vamsi Jonnagadda <vamsijonnagadda@ICTs-MacBook-Pro.local> Co-authored-by: vkjonnagadda <32249251+vkjonnagadda@users.noreply.github.com> Co-authored-by: Thomas Judd-Cooper <me@tomjuddcooper.co.uk> Co-authored-by: Sindhu Natarajan <nsindhupriya@hotmail.co.uk> Co-authored-by: Sindhu <nsindhu26@gmail.com> Co-authored-by: ThomasC-Kainos <106971950+ThomasC-Kainos@users.noreply.github.com> Co-authored-by: ManithaSrinivasa <manitha.srinivasa@accenture.com> Co-authored-by: ajmu1 <ajmu1@hscic.gov.uk> Co-authored-by: ManithaSrinivasa <142212846+ManithaSrinivasa@users.noreply.github.com>
1 parent 3fe5a6a commit bf18174

33 files changed

Lines changed: 179 additions & 67 deletions

File tree

.github/CODEOWNERS

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
/.github @nhsd-exeter/maintainers
2-
/build/automation/lib @nhsd-exeter/maintainers
3-
/build/automation/init.mk @nhsd-exeter/maintainers
4-
/.gitignore @nhsd-exeter/maintainers
5-
/project.code-workspace @nhsd-exeter/maintainers
1+
/.github @NHSDigital/data-sourcing-ftrs/maintainers
2+
/build/automation/lib @NHSDigital/data-sourcing-ftrs/maintainers
3+
/build/automation/init.mk @NHSDigital/data-sourcing-ftrs/maintainers
4+
/.gitignore @NHSDigital/data-sourcing-ftrs/maintainers
5+
/project.code-workspace @NHSDigital/data-sourcing-ftrs/maintainers

.github/workflows/code-quality.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ jobs:
3434
projectBaseDir: .
3535
args: >
3636
-Dsonar.sources=application,infrastructure,scripts,test,build/docker
37-
-Dsonar.organization=nhsd-exeter
38-
-Dsonar.projectKey=uec-dos-int
37+
-Dsonar.organization=nhsdigital
38+
-Dsonar.projectKey=nhsdigital_dos-integration
3939
-Dsonar.coverage.exclusions=tests/**,**/tests/**,infrastructure,application/dos_db_handler/**,test/**,scripts/**,application/conftest.py
4040
-Dsonar.python.coverage.reportPaths=coverage.xml
4141
-Dsonar.python.version=3.12
@@ -48,7 +48,7 @@ jobs:
4848
with:
4949
fetch-depth: 0
5050
- name: Check Markdown format
51-
uses: DavidAnson/markdownlint-cli2-action@v13
51+
uses: DavidAnson/markdownlint-cli2-action@v20
5252
with:
5353
config: .github/workflows/configs/markdownlint/.markdownlint.json
5454
- name: Check Markdown links

.github/workflows/update-pull-request-description.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Checkout
1919
uses: actions/checkout@v4
2020
- name: Get Branch Name
21-
uses: mdecoleman/pr-branch-name@2.0.0
21+
uses: mdecoleman/pr-branch-name@v3.0.0
2222
id: branch_name
2323
with:
2424
repo-token: ${{ secrets.GITHUB_TOKEN }}
@@ -30,7 +30,7 @@ jobs:
3030
run: echo "TEMPLATE_NAME=$(cat .github/PULL_REQUEST_TEMPLATE/${{ env.BRANCH_DESIGNATOR }}_pull_request_template.md > /dev/null 2>&1 && echo ${{ env.BRANCH_DESIGNATOR }}_pull_request_template.md || echo task_pull_request_template.md)" >> $GITHUB_ENV
3131
- name: Render Pull Request template
3232
id: template
33-
uses: chuhlomin/render-template@v1.5
33+
uses: chuhlomin/render-template@v1.10
3434
with:
3535
template: .github/PULL_REQUEST_TEMPLATE/${{ env.TEMPLATE_NAME }}
3636
vars: |

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ tag-commit-to-destroy-environment: # Tag git commit to destroy deployment - mand
272272
fi
273273

274274
get-environment-from-pr:
275-
ENVIRONMENT=$$(gh pr list -s merged --json number,mergeCommit,headRefName --repo=nhsd-exeter/dos-integration | jq --raw-output '.[] | select(.number == $(PR_NUMBER)) | .headRefName | sub( ".*:*/DS-(?<x>.[0-9]*).*"; "ds-\(.x)") ')
275+
ENVIRONMENT=$$(gh pr list -s merged --json number,mergeCommit,headRefName --repo=NHSDigital/dos-integration | jq --raw-output '.[] | select(.number == $(PR_NUMBER)) | .headRefName | sub( ".*:*/DS-(?<x>.[0-9]*).*"; "ds-\(.x)") ')
276276
echo $$ENVIRONMENT
277277

278278
is-environment-deployed:

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,13 +102,13 @@ The main components you will need for _basic_ development work, are your OS vers
102102
- Git
103103
- Python (The project currently runs on 3.12)
104104
- AWS CLI
105-
- Docker
105+
- Docker/Podman
106106

107107
### Clone Repository
108108

109109
Clone the repository
110110

111-
git clone git@github.com:nhsd-exeter/dos-integration.git
111+
git clone git@github.com:NHSDigital/dos-integration.git
112112
cd ./dos-integration
113113

114114
### AWS Authentication
@@ -192,7 +192,7 @@ To run ruff on you branch:
192192

193193
List all the type of test suites included and provide instructions how to execute them
194194

195-
- Unit
195+
- Unit Testing
196196
- Integration
197197
- Performance
198198

@@ -240,7 +240,7 @@ This testing is generally done by a tester
240240
Prerequisites
241241

242242
assume # Granted assume AWS Role
243-
Sign into Non-Prod VPN # To connect to lambdas within the VPC
243+
Sign into Non-Prod VPN # To connect to lambdas within the VPC
244244
IP is in the IP Allow List # To connect to the API Gateway
245245
make tester-build
246246

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
aws-lambda-powertools[tracer] ~= 2.43.0
1+
aws-lambda-powertools[tracer] ~= 3.20.0

application/common/constants.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
CLOSED_AND_HIDDEN_STATUSES = ["HIDDEN", "CLOSED"]
44

5-
PHARMACY_SERVICE_TYPE_IDS = [13, 131, 132, 134, 137, 148, 149]
5+
DISTANCE_SELLING_PHARMACY_ID = 134
6+
PHARMACY_SERVICE_TYPE_IDS = [13, 131, 132, DISTANCE_SELLING_PHARMACY_ID, 137, 148, 149]
67
PHARMACY_ORGANISATION_SUB_TYPES = ["Community", "DistanceSelling"]
78
PHARMACY_ODSCODE_LENGTH = 5
89
PHARMACY_SERVICE_TYPE_ID = 13
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
aws-lambda-powertools[tracer] ~= 2.43.0
1+
aws-lambda-powertools[tracer] ~= 3.20.0
22
psycopg[binary]
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
aws-lambda-powertools[tracer] ~= 2.43.0
1+
aws-lambda-powertools[tracer] ~= 3.20.0
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
aws-lambda-powertools[tracer] ~= 2.43.0
1+
aws-lambda-powertools[tracer] ~= 3.20.0
22
simplejson

0 commit comments

Comments
 (0)