Release/30.0 (#1137)

# Release Branch Pull Request

## Description of Changes

This release will contain upgrade of terraform core version(from v1.2.1
to v1.13.0), terraform AWS provider version(v5.68.0 to v6.14.1) and
python version upgrade(v3.12 to v3.14) for lambda and tester docker
images of DI application as well.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Matthew Begley <60427904+mabe13@users.noreply.github.com>
Co-authored-by: Jack Plowman <62281988+JackPlowman@users.noreply.github.com>
Co-authored-by: Corbisc <95412908+Corbisc@users.noreply.github.com>
Co-authored-by: Matthew Begley <60427904+mabe13@users.noreply.github.com>
Co-authored-by: mabe13 <matthewbegley@nhs.net>
Co-authored-by: Michael Olaw <michael.olaw1@nhs.net>
Co-authored-by: Jack Plowman <jack.plowman1@nhs.net>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vamsi Jonnagadda <vamsijonnagadda@ICTs-MacBook-Pro.local>
Co-authored-by: vkjonnagadda <32249251+vkjonnagadda@users.noreply.github.com>
Co-authored-by: Thomas Judd-Cooper <me@tomjuddcooper.co.uk>
Co-authored-by: Sindhu Natarajan <nsindhupriya@hotmail.co.uk>
Co-authored-by: Sindhu <nsindhu26@gmail.com>
Co-authored-by: ThomasC-Kainos <106971950+ThomasC-Kainos@users.noreply.github.com>
Co-authored-by: ManithaSrinivasa <manitha.srinivasa@accenture.com>
Co-authored-by: ajmu1 <ajmu1@hscic.gov.uk>
Co-authored-by: ManithaSrinivasa <142212846+ManithaSrinivasa@users.noreply.github.com>

Author: 15 people

.github/workflows/code-quality.yml

@@ -38,7 +38,7 @@ jobs:
             -Dsonar.projectKey=nhsdigital_dos-integration
             -Dsonar.coverage.exclusions=tests/**,**/tests/**,infrastructure,application/dos_db_handler/**,test/**,scripts/**,application/conftest.py
             -Dsonar.python.coverage.reportPaths=coverage.xml
-            -Dsonar.python.version=3.12
+            -Dsonar.python.version=3.14
             -Dsonar.exclusions=application/**/tests/**
 
   check-markdown-code-quality:

.github/workflows/configs/vale/styles/config/vocabularies/words/accept.txt

@@ -21,7 +21,7 @@ CodePipeline
 Xcode
 Tunnelblick
 // Environments
-dev
+[Dd]ev
 perf
 perf2
 nonprod
@@ -32,14 +32,20 @@ mgmt
 MGMT
 // Development/Deployment Terms
 adhoc
+rebase
+pytest
 healthcheck
-runbook
-Runbook
+[Rr]unbooks?
+Allowlist
+slack_and_infrastructure
+opening_times
+hotfixes
+automations
 undeploy
 Undeploy
+undeployed
 Onboarding
 onboarding
 // Miscellaneous
 bbbbbb
 gggggg
-[A-Z]+s

README.md

@@ -100,7 +100,7 @@ The main components you will need for _basic_ development work, are your OS vers
 
 - A VPN Client (OpenVPN or Tunnelblick are 2 NHS Digital suggested options)
 - Git
-- Python (The project currently runs on 3.12)
+- Python (The project currently runs on Python 3.14)
 - AWS CLI
 - Docker/Podman
 
@@ -192,7 +192,7 @@ To run ruff on you branch:
 
 List all the type of test suites included and provide instructions how to execute them
 
-- Unit Testing
+- Unit
 - Integration
 - Performance
 
@@ -482,7 +482,7 @@ To quick update the lambdas run the following command. Note this only updates th
 
 ### Remove deployment with commit tag
 
-You can remove a dev deployment using a single command to create a tag which then runs an AWS CodeBuild project that will remove that environment
+You can remove a dev deployment using a single command to create a tag which then starts an AWS CodeBuild project that will remove that environment
 
     make tag-commit-to-destroy-environment ENVIRONMENT=[environment to destroy] COMMIT=[short commit hash]
     e.g. make tag-commit-to-destroy-environment ENVIRONMENT=ds-363 COMMIT=2bc43dd // This destroys the ds-363 dev environment

build/automation/lib/terraform.mk

@@ -4,7 +4,7 @@ TERRAFORM_STATE_STORE = $(or $(TEXAS_TERRAFORM_STATE_STORE), state-store-$(AWS_A
 TERRAFORM_STATE_LOCK = $(or $(TEXAS_TERRAFORM_STATE_LOCK), state-lock-$(AWS_ACCOUNT_NAME))
 TERRAFORM_STATE_KEY = $(PROJECT_GROUP_SHORT)-$(PROJECT_NAME_SHORT)/$(ENVIRONMENT)
 TERRAFORM_STATE_KEY_SHARED = texas
-TERRAFORM_VERSION = $(or $(TEXAS_TERRAFORM_VERSION), 1.2.1)
+TERRAFORM_VERSION = $(or $(TEXAS_TERRAFORM_VERSION), 1.13.0)
 
 # ==============================================================================
 

build/docker/lambda/Dockerfile

@@ -1,4 +1,4 @@
-FROM public.ecr.aws/lambda/python:3.12-arm64
+FROM public.ecr.aws/lambda/python:3.14-arm64
 # Update Pip
 RUN python -m pip install --upgrade pip
 # Copy Python requirements

build/docker/tester/Dockerfile

@@ -1,4 +1,4 @@
-FROM python:3.12
+FROM python:3.14
 # Update Pip
 RUN python -m pip install --upgrade pip
 # Copy Python requirements

infrastructure/modules/s3/main.tf

@@ -8,7 +8,7 @@
 #tfsec:ignore:aws-s3-specify-public-access-block
 module "s3_bucket" {
   source  = "terraform-aws-modules/s3-bucket/aws"
-  version = "3.15.1"
+  version = "5.7.0"
   bucket  = var.name
   acl     = var.acl
 

infrastructure/stacks/api-key/.terraform.lock.hcl

@@ -5,9 +5,9 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = "~> 5.68.0"
+      version = "~> 6.14.1"
     }
-    template = {
+    random = {
       source  = "hashicorp/random"
       version = "~> 3.3.0"
     }