Skip to content

Commit d18f6c8

Browse files
Remove common repo dependency
1 parent 9ba86fa commit d18f6c8

4 files changed

Lines changed: 9 additions & 44 deletions

File tree

README.md

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,6 @@ The dev container sits on the same network, `gateway-local`, as [the `gateway-ap
116116

117117
- A container runtime such as [Docker](https://docs.docker.com/engine/install/) (Linux/WSL) or [Colima](https://github.com/abiosoft/colima) (macOS)
118118

119-
### External Dependencies
120-
121-
This project depends on the [clinical-data-common](https://github.com/NHSDigital/clinical-data-common) library for shared utilities. It is declared as a Git dependency in `gateway-api/pyproject.toml` and installed automatically by Poetry.
122-
123119
## Usage
124120

125121
The project uses `make` targets to build, deploy, and manage the application. Run these from the repository root:
@@ -157,11 +153,11 @@ Environment variables control whether stubs are used in place of the real PDS, S
157153
| Variable | Description |
158154
| --- | --- |
159155
| `PDS_URL` | The URL for the PDS FHIR API; set as `stub` to use development stub. |
160-
| `PDS_API_TOKEN`| Leave unset in development environment. |
161-
| `PDS_API_SECRET`| Leave unset in development environment. |
162-
| `PDS_API_KID`| Leave unset in development environment. |
156+
| `PDS_API_TOKEN` | Leave unset in development environment. |
157+
| `PDS_API_SECRET` | Leave unset in development environment. |
158+
| `PDS_API_KID` | Leave unset in development environment. |
163159
| `SDS_URL` | The URL for the SDS FHIR API; set as `stub` to use development stub. |
164-
| `SDS_API_TOKEN`| Leave unset in development environment. |
160+
| `SDS_API_TOKEN` | Leave unset in development environment. |
165161
| `PROVIDER_URL` | The URL for the GP Provider; set as `stub` to use development stub. |
166162
| `CDG_DEBUG` | `true`, return additional debug information when the call to the GP provider returns an error. |
167163

gateway-api/README.md

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -114,31 +114,17 @@ gateway-api/
114114
Specified under `[tool.poetry.dependencies]` in `pyproject.toml`:
115115

116116
| Package | Description |
117-
|---|---|
117+
| --- | --- |
118118
| `flask` | Web framework powering the Gateway API |
119119
| `requests` | HTTP client for calling PDS, SDS, and GP provider APIs |
120120
| `types-flask` | Type stubs for Flask (used by mypy) |
121-
| `clinical-data-common` | Shared NHSE library for common utilities ([GitHub repo](https://github.com/NHSDigital/clinical-data-common)) |
122-
123-
The `clinical-data-common` dependency is pinned to a Git tag in `pyproject.toml`:
124-
125-
```toml
126-
[tool.poetry.dependencies]
127-
clinical-data-common = { git = "https://github.com/NHSDigital/clinical-data-common.git", tag = "v0.1.0" }
128-
```
129-
130-
To update it to a newer tag or version:
131-
132-
```bash
133-
poetry update clinical-data-common
134-
```
135121

136122
### Dev Dependencies
137123

138124
Specified under `[dependency-groups] dev` in `pyproject.toml`:
139125

140126
| Package | Description |
141-
|---|---|
127+
| --- | --- |
142128
| `mypy` | Static type checker (strict mode enabled) |
143129
| `pytest` | Test runner |
144130
| `pytest-bdd` | BDD-style acceptance tests with Gherkin feature files |

gateway-api/poetry.lock

Lines changed: 3 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gateway-api/pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ readme = "README.md"
99
requires-python = ">=3.14,<4.0.0"
1010

1111
[tool.poetry.dependencies]
12-
clinical-data-common = { git = "https://github.com/NHSDigital/clinical-data-common.git", tag = "v0.1.0" }
1312
flask = "^3.1.3"
1413
types-flask = "^1.1.6"
1514
requests = "^2.33.0"

0 commit comments

Comments
 (0)