leak

Author: BJSS-russell-pollock

gateway-api/openapi.yaml

@@ -239,7 +239,7 @@ paths:
                           type: string
                           example: "Patient not found"
         '415':
-          description: Unsupported Media Type"
+          description: Unsupported Media Type - Content-Type header must be "application/fhir+json"
           content:
             application/fhir+json:
               schema:

gateway-api/src/gateway_api/app.py

@@ -116,7 +116,7 @@ def get_structured_record() -> Response:
         log_error(e)
         response.add_error_response(e)
     except Exception:
-        error = UnexpectedError(traceback=traceback.format_exc())
+        error = UnexpectedError()
         log_error(error)
         response.add_error_response(error)
 

gateway-api/src/gateway_api/get_structured_record/request.py

@@ -37,7 +37,7 @@ def __init__(self, request: Request) -> None:
         self._headers = CaseInsensitiveDict(request.headers)
         self._validate_content_type()
         try:
-            self.parameters = Parameters.model_validate(request.get_json())
+            self.parameters = Parameters.model_validate(request.get_json(silent=True))
         except (BadRequest, ValidationError) as error:
             raise InvalidRequestJSONError() from error
 

gateway-api/src/gateway_api/get_structured_record/test_response.py

@@ -62,7 +62,7 @@ def test_add_provider_response_adds_200_status(
         assert actual == 200, f"Expected status code to be 200, but got {actual}"
 
     def test_add_error_response_adds_error_response_body(self) -> None:
-        error = UnexpectedError(traceback="something broke")
+        error = UnexpectedError()
 
         response = GetStructuredRecordResponse()
         response.add_error_response(error)

schemathesis.toml

@@ -3,3 +3,6 @@ mode = "all"
 
 [checks.missing_required_header]
 expected-statuses = [400]
+
+[checks.negative_data_rejection]
+expected-statuses = [400, 401, 403, 404, 406, 415, 422, 428, "5xx"]