Review comments

Author: ian-robinson-35

bruno/gateway-api/collections/Steel_Thread/environments/localInt.yml

@@ -3,6 +3,6 @@ variables:
   - name: base_url
     value: http://localhost:5000
   - name: nhs_number
-    value: "9658218865"
+    value: "9692140466"
   - name: from_ods
     value: A20047

gateway-api/src/gateway_api/sds/test_client.py

@@ -36,7 +36,6 @@ def test_sds_client_get_org_details_success(stub: SdsFhirApiStub) -> None:
     Test SdsClient can successfully look up organization details.
 
     :param stub: SDS stub fixture.
-    :param mock_flask: Mock Flask app fixture.
     """
     client = SdsClient(base_url="https://test.com", api_key="example_api_key")
 

gateway-api/src/gateway_api/test_controller.py

@@ -1,7 +1,6 @@
 """Unit tests for :mod:`gateway_api.controller`."""
 
 from typing import Any
-from unittest.mock import Mock
 
 import pytest
 from fhir.r4 import (
@@ -25,13 +24,6 @@
 from gateway_api.sds import SdsSearchResults
 
 
-@pytest.fixture
-def mock_flask() -> Mock:
-    mock_flask = Mock()
-    mock_flask.config = {"SDS_API_TOKEN": "example"}
-    return mock_flask
-
-
 def _create_patient(nhs_number: str, gp_ods_code: str | None) -> Patient:
     general_practitioner = None
     if gp_ods_code is not None:

gateway-api/stubs/stubs/data/bundles/bundles.py

@@ -18,4 +18,4 @@ def _wrap_patient_in_bundle(patient: dict[str, Any]) -> dict[str, Any]:
         }
 
     ALICE_JONES_9999999999 = _wrap_patient_in_bundle(Patients.ALICE_JONES_9999999999)
-    INT_9658218865 = _wrap_patient_in_bundle(Patients.INT_9658218865)
+    INT_9692140466 = _wrap_patient_in_bundle(Patients.INT_9692140466)

gateway-api/stubs/stubs/data/patients/int_9658218865.json

@@ -27,4 +27,4 @@ def load_patient(filename: str) -> dict[str, Any]:
     )
     ALICE_JONES_9999999999 = load_patient("alice_jones_9999999999.json")
     ORANGE_BOX_TRIGGER_9690937278 = load_patient("orange_box_trigger_9690937278.json")
-    INT_9658218865 = load_patient("int_9658218865.json")
+    INT_9692140466 = load_patient("int_9692140466.json")

gateway-api/stubs/stubs/data/patients/patients.py

@@ -53,7 +53,7 @@ def __init__(self, strict_headers: bool = True) -> None:
             ("9000000012", Patients.INDUCE_PROVIDER_ERROR_9000000012),
             ("9000000013", Patients.BLANK_ENDPOINT_SDS_RESULT_9000000013),
             ("9690937278", Patients.ORANGE_BOX_TRIGGER_9690937278),
-            ("9658218865", Patients.INT_9658218865),
+            ("9692140466", Patients.INT_9692140466),
         ]
         for nhs_number, patient in test_patients:
             self.upsert_patient(

gateway-api/stubs/stubs/pds/stub.py

@@ -279,10 +279,10 @@ def access_record_structured(
                 json_data=Bundles.ALICE_JONES_9999999999,
             )
 
-        if nhs_number == "9658218865":
+        if nhs_number == "9692140466":
             return self._create_response(
                 status_code=200,
-                json_data=Bundles.INT_9658218865,
+                json_data=Bundles.INT_9692140466,
             )
 
         return self._create_response(