Skip to content

Commit 483e095

Browse files
[GPCAPIM-427] Remove common repo dependency (#197)
<!-- markdownlint-disable-next-line first-line-heading --> ## Description Removing common repo dependency, can add back in the future if we decide that we have a good use-case for the common repo. ## Context <!-- Why is this change required? What problem does it solve? --> ## Type of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. --> - [x] Refactoring (non-breaking change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would change existing functionality) - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I have followed the code style of the project - [ ] I have added tests to cover my changes - [ ] I have updated the documentation accordingly - [ ] This PR is a result of pair or mob programming - [ ] Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request. --- ## Sensitive Information Declaration To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including [PII (Personal Identifiable Information) / PID (Personal Identifiable Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter. - [x] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.
1 parent eb5cf39 commit 483e095

4 files changed

Lines changed: 5 additions & 40 deletions

File tree

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,6 @@ The dev container sits on the same network, `gateway-local`, as [the `gateway-ap
116116

117117
- A container runtime such as [Docker](https://docs.docker.com/engine/install/) (Linux/WSL) or [Colima](https://github.com/abiosoft/colima) (macOS)
118118

119-
### External Dependencies
120-
121-
This project depends on the [clinical-data-common](https://github.com/NHSDigital/clinical-data-common) library for shared utilities. It is declared as a Git dependency in `gateway-api/pyproject.toml` and installed automatically by Poetry.
122-
123119
## Usage
124120

125121
The project uses `make` targets to build, deploy, and manage the application. Run these from the repository root:

gateway-api/README.md

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -114,31 +114,17 @@ gateway-api/
114114
Specified under `[tool.poetry.dependencies]` in `pyproject.toml`:
115115

116116
| Package | Description |
117-
|---|---|
117+
| --- | --- |
118118
| `flask` | Web framework powering the Gateway API |
119119
| `requests` | HTTP client for calling PDS, SDS, and GP provider APIs |
120120
| `types-flask` | Type stubs for Flask (used by mypy) |
121-
| `clinical-data-common` | Shared NHSE library for common utilities ([GitHub repo](https://github.com/NHSDigital/clinical-data-common)) |
122-
123-
The `clinical-data-common` dependency is pinned to a Git tag in `pyproject.toml`:
124-
125-
```toml
126-
[tool.poetry.dependencies]
127-
clinical-data-common = { git = "https://github.com/NHSDigital/clinical-data-common.git", tag = "v0.1.0" }
128-
```
129-
130-
To update it to a newer tag or version:
131-
132-
```bash
133-
poetry update clinical-data-common
134-
```
135121

136122
### Dev Dependencies
137123

138124
Specified under `[dependency-groups] dev` in `pyproject.toml`:
139125

140126
| Package | Description |
141-
|---|---|
127+
| --- | --- |
142128
| `mypy` | Static type checker (strict mode enabled) |
143129
| `pytest` | Test runner |
144130
| `pytest-bdd` | BDD-style acceptance tests with Gherkin feature files |

gateway-api/poetry.lock

Lines changed: 3 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gateway-api/pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ readme = "README.md"
99
requires-python = ">=3.14,<4.0.0"
1010

1111
[tool.poetry.dependencies]
12-
clinical-data-common = { git = "https://github.com/NHSDigital/clinical-data-common.git", tag = "v0.1.0" }
1312
flask = "^3.1.3"
1413
types-flask = "^1.1.6"
1514
requests = "^2.33.0"

0 commit comments

Comments
 (0)