From cd24e72966ef594189f1ad133fb8790276f04eb1 Mon Sep 17 00:00:00 2001 From: Walmir Silva Date: Wed, 4 Mar 2026 21:01:02 -0300 Subject: [PATCH] ci: make workflows identical to kariricode-property-inspector pattern MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove extra failOnWarning/failOnRisky sed patches that deviated from the canonical property-inspector workflow. Keep only the single beStrictAboutCoverageMetadata patch that is the correct baseline. Only project-specific changes kept: - Package name: PropertyInspector → Sanitizer - Test baseline: 40/96 → 175/425 --- .github/workflows/ci.yml | 7 ++----- .github/workflows/code-quality.yml | 14 ++++---------- .github/workflows/release.yml | 12 +++--------- 3 files changed, 9 insertions(+), 24 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 420f3da..a5a9f76 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -42,14 +42,11 @@ jobs: - name: Initialize devkit (.kcode/ generation) run: kcode init - # Patch generated phpunit.xml.dist to suppress false-positive CI failures: - # - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes - # - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline + # Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false + # "not a valid target" warnings for classes extending vendor base classes - name: Patch phpunit.xml.dist run: | sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist - sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist - sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist # cs-fixer → phpstan (L9) → psalm → phpunit # Exit code ≠ 0 fails the job (zero-tolerance policy) diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml index 1c869c9..9da6dc4 100644 --- a/.github/workflows/code-quality.yml +++ b/.github/workflows/code-quality.yml @@ -97,14 +97,11 @@ jobs: - name: Initialize devkit run: kcode init - # Patch generated phpunit.xml.dist to suppress false-positive CI failures: - # - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes - # - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline + # Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false + # "not a valid target" warnings for classes extending vendor base classes - name: Patch phpunit.xml.dist run: | sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist - sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist - sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist # Runs PHPStan Level 9 then Psalm sequentially — both must pass - name: Run PHPStan + Psalm via kcode @@ -176,14 +173,11 @@ jobs: - name: Initialize devkit run: kcode init - # Patch generated phpunit.xml.dist to suppress false-positive CI failures: - # - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes - # - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline + # Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false + # "not a valid target" warnings for classes extending vendor base classes - name: Patch phpunit.xml.dist run: | sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist - sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist - sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist - name: Run tests with coverage (pcov) run: kcode test --coverage diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 36df3cb..f808091 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -41,14 +41,11 @@ jobs: - name: Initialize devkit run: kcode init - # Patch generated phpunit.xml.dist to suppress false-positive CI failures: - # - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes - # - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline + # Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false + # "not a valid target" warnings for classes extending vendor base classes - name: Patch phpunit.xml.dist run: | sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist - sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist - sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist # Full pipeline: cs-fixer → phpstan (L9) → psalm → phpunit (pcov) # Exit code ≠ 0 aborts the release — zero tolerance (ARFA 1.3) @@ -90,11 +87,8 @@ jobs: #[Sanitize('trim', 'capitalize')] public string $name = ''; - #[Sanitize('trim', 'filter.email')] + #[Sanitize('trim', 'email_filter')] public string $email = ''; - - #[Sanitize(['string.truncate', ['max' => 200]])] - public string $bio = ''; } $sanitizer = (new SanitizerServiceProvider())->createAttributeSanitizer();