Skip to content

Commit cd24e72

Browse files
committed
ci: make workflows identical to kariricode-property-inspector pattern
Remove extra failOnWarning/failOnRisky sed patches that deviated from the canonical property-inspector workflow. Keep only the single beStrictAboutCoverageMetadata patch that is the correct baseline. Only project-specific changes kept: - Package name: PropertyInspector → Sanitizer - Test baseline: 40/96 → 175/425
1 parent 6a181e5 commit cd24e72

3 files changed

Lines changed: 9 additions & 24 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,11 @@ jobs:
4242
- name: Initialize devkit (.kcode/ generation)
4343
run: kcode init
4444

45-
# Patch generated phpunit.xml.dist to suppress false-positive CI failures:
46-
# - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes
47-
# - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline
45+
# Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false
46+
# "not a valid target" warnings for classes extending vendor base classes
4847
- name: Patch phpunit.xml.dist
4948
run: |
5049
sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
51-
sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
52-
sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist
5350
5451
# cs-fixer → phpstan (L9) → psalm → phpunit
5552
# Exit code ≠ 0 fails the job (zero-tolerance policy)

.github/workflows/code-quality.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,11 @@ jobs:
9797
- name: Initialize devkit
9898
run: kcode init
9999

100-
# Patch generated phpunit.xml.dist to suppress false-positive CI failures:
101-
# - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes
102-
# - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline
100+
# Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false
101+
# "not a valid target" warnings for classes extending vendor base classes
103102
- name: Patch phpunit.xml.dist
104103
run: |
105104
sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
106-
sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
107-
sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist
108105
109106
# Runs PHPStan Level 9 then Psalm sequentially — both must pass
110107
- name: Run PHPStan + Psalm via kcode
@@ -176,14 +173,11 @@ jobs:
176173
- name: Initialize devkit
177174
run: kcode init
178175

179-
# Patch generated phpunit.xml.dist to suppress false-positive CI failures:
180-
# - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes
181-
# - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline
176+
# Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false
177+
# "not a valid target" warnings for classes extending vendor base classes
182178
- name: Patch phpunit.xml.dist
183179
run: |
184180
sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
185-
sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
186-
sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist
187181
188182
- name: Run tests with coverage (pcov)
189183
run: kcode test --coverage

.github/workflows/release.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,11 @@ jobs:
4141
- name: Initialize devkit
4242
run: kcode init
4343

44-
# Patch generated phpunit.xml.dist to suppress false-positive CI failures:
45-
# - beStrictAboutCoverageMetadata: "not a valid target" warnings from vendor base classes
46-
# - failOnWarning / failOnRisky: prevent risky/warning exits from blocking the pipeline
44+
# Patch generated phpunit.xml.dist — beStrictAboutCoverageMetadata causes false
45+
# "not a valid target" warnings for classes extending vendor base classes
4746
- name: Patch phpunit.xml.dist
4847
run: |
4948
sed -i 's/beStrictAboutCoverageMetadata="true"/beStrictAboutCoverageMetadata="false"/' .kcode/phpunit.xml.dist
50-
sed -i 's/failOnWarning="true"/failOnWarning="false"/' .kcode/phpunit.xml.dist
51-
sed -i 's/failOnRisky="true"/failOnRisky="false"/' .kcode/phpunit.xml.dist
5249
5350
# Full pipeline: cs-fixer → phpstan (L9) → psalm → phpunit (pcov)
5451
# Exit code ≠ 0 aborts the release — zero tolerance (ARFA 1.3)
@@ -90,11 +87,8 @@ jobs:
9087
#[Sanitize('trim', 'capitalize')]
9188
public string $name = '';
9289
93-
#[Sanitize('trim', 'filter.email')]
90+
#[Sanitize('trim', 'email_filter')]
9491
public string $email = '';
95-
96-
#[Sanitize(['string.truncate', ['max' => 200]])]
97-
public string $bio = '';
9892
}
9993
10094
$sanitizer = (new SanitizerServiceProvider())->createAttributeSanitizer();

0 commit comments

Comments
 (0)