test(filter): achieve 100% coverage for AttributeFilter

Author: walmir-silva

tests/Unit/Filter/AttributeFilterTest.php

@@ -76,4 +76,68 @@ public function testMultipleAttributesNoneMatch(): void
 
         self::assertFalse($filter->accept($meta));
     }
+
+    /**
+     * Covers L41: when the attribute name has NO backslash, shortName is null
+     * and only exact matching is done (no short-name fallback).
+     */
+    public function testAcceptsClassWithShortNameAttributeNoNamespace(): void
+    {
+        // Attribute stored/searched as plain name (no backslash)
+        $attr = self::createAttributeMetadata(name: 'Route');
+        $meta = self::createClassMetadata(attributes: ['Route' => $attr]);
+
+        // Filter with plain name — shortName branch is null (L41 covered)
+        $filter = new AttributeFilter('Route');
+
+        self::assertTrue($filter->accept($meta));
+    }
+
+    public function testRejectsWhenShortNameNoNamespaceDoesNotMatch(): void
+    {
+        $attr = self::createAttributeMetadata(name: 'Route');
+        $meta = self::createClassMetadata(attributes: ['Route' => $attr]);
+
+        // Searching for 'Command' plain name — no match
+        $filter = new AttributeFilter('Command');
+
+        self::assertFalse($filter->accept($meta));
+    }
+
+    public function testAcceptsViaShortNameFallbackOnMethod(): void
+    {
+        // Filter with FQCN, attribute stored with short name on method
+        $attr = new AttributeMetadata(name: 'Route', target: AttributeTarget::Method);
+        $method = new MethodMetadata(name: 'index', attributes: ['Route' => $attr]);
+        $meta = self::createClassMetadata(methods: ['index' => $method]);
+
+        // FQCN filter — shortName = 'Route' — matches method attribute stored as 'Route'
+        $filter = new AttributeFilter('App\\Route');
+
+        self::assertTrue($filter->accept($meta));
+    }
+
+    public function testAcceptsViaShortNameFallbackOnProperty(): void
+    {
+        // Filter with FQCN, attribute stored with short name on property
+        $attr = new AttributeMetadata(name: 'Column', target: AttributeTarget::Property);
+        $prop = new PropertyMetadata(name: 'id', attributes: ['Column' => $attr]);
+        $meta = self::createClassMetadata(properties: ['id' => $prop]);
+
+        // FQCN filter — shortName = 'Column' — matches property attribute stored as 'Column'
+        $filter = new AttributeFilter('Doctrine\\Column');
+
+        self::assertTrue($filter->accept($meta));
+    }
+
+    public function testRejectsWhenNoAttributeClassesGiven(): void
+    {
+        $attr = self::createAttributeMetadata(name: 'Route');
+        $meta = self::createClassMetadata(attributes: ['Route' => $attr]);
+
+        // Empty filter — foreach never executes → returns false
+        $filter = new AttributeFilter();
+
+        self::assertFalse($filter->accept($meta));
+    }
 }