Skip to content

Commit 9e1e135

Browse files
committed
refactor: trim docs and include retry count in poll message
- Remove Debian/Ubuntu install guide and RUSTFLAGS example from CONTRIBUTING.md (audience can figure these out) - Extract retry count to a variable and include it in the FUSE mount poll panic message https://claude.ai/code/session_01LfpnUZrgq93MVZgA3KVqE6
1 parent bf6ee32 commit 9e1e135

2 files changed

Lines changed: 4 additions & 13 deletions

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -369,17 +369,7 @@ Some integration tests require external (non-Cargo) tools that are **not** manag
369369
- `squashfuse` (provides `squashfuse`) — cross-device (`--one-file-system`) FUSE test
370370
- `fuse3` (provides `fusermount3`, `/dev/fuse`) — cross-device (`--one-file-system`) FUSE test
371371

372-
On Debian/Ubuntu:
373-
374-
```sh
375-
sudo apt install squashfs-tools squashfuse fuse3
376-
```
377-
378-
Tests that need these tools will panic with a diagnostic message if they are missing. The panic message includes the specific `RUSTFLAGS='--cfg pdu_test_skip_*'` flag to skip the test. For example:
379-
380-
```sh
381-
export RUSTFLAGS='--cfg pdu_test_skip_cross_device'
382-
```
372+
Tests that need these tools will panic with a diagnostic message if they are missing. The panic message includes the specific `RUSTFLAGS='--cfg pdu_test_skip_*'` flag to skip the test.
383373

384374
## Automated Checks
385375

tests/one_file_system.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,15 +224,16 @@ fn cross_device_excludes_mount() {
224224

225225
// Wait for the FUSE mount to become readable (exponential backoff)
226226
let wait_ms_base = 100;
227-
let poll_result = (0..5)
227+
let retries = 5;
228+
let poll_result = (0..retries)
228229
.map(|exponent| wait_ms_base << exponent)
229230
.map(Duration::from_millis)
230231
.map(sleep)
231232
.filter_map(|()| mount_point.read_dir().ok())
232233
.find_map(|mut entry| entry.next());
233234
assert!(
234235
poll_result.is_some(),
235-
"FUSE mount at {mount_point:?} not ready after retries"
236+
"FUSE mount at {mount_point:?} not ready after {retries} retries"
236237
);
237238

238239
let build_expected_tree = |one_file_system: bool| -> String {

0 commit comments

Comments
 (0)